698 Commits

• Add xmldoc remark
  smoogipoo · 2021-06-18 19:27:10 +09:00
  42c5a962fb
• Don't set entry immediately
  smoogipoo · 2021-06-18 19:23:37 +09:00
  36d51d5117
• Add exception on Apply() while loading
  smoogipoo · 2021-06-18 19:20:57 +09:00
  36d2199a02
• Use property instead of backing field consistently
  ekrctb · 2021-06-17 10:31:20 +09:00
  e7954ecb60
• Allow setting Entry of PoolableDrawableWithLifetime

  It is more convenient than using the constructor because the only limited kind of expression is allowed in a base constructor call.
  Also, the object initializer syntax can be used.

  ekrctb · 2021-06-16 16:00:08 +09:00
  117e94bc94
• Add missing CurrentSkin null check in DHO disposal
  Bartłomiej Dach · 2021-06-11 09:18:58 +02:00
  296761ade5
• Fix filename not matching type rename
  Dean Herbert · 2021-06-11 14:34:18 +09:00
  562cfe8703
• Show osu!taiko centre/rim colouring in editor timeline

  Closes #13443.

  Dean Herbert · 2021-06-11 14:17:30 +09:00
  bc3b7233ab
• Fix incorrect method referenced in xmldco

  Co-authored-by: ekrctb <32995012+ekrctb@users.noreply.github.com>

  Dean Herbert · 2021-06-09 14:20:01 +09:00
  b8df3fff9e
• Add one missing obsoletion removal date
  Dean Herbert · 2021-06-09 14:11:50 +09:00
  62199a38a8
• Remove more obsoleted members
  Dean Herbert · 2021-06-09 14:10:48 +09:00
  f41e34ae2c
• Make HitObjectContainer.Clear non-virtual

  It just call `Remove` for all entries.

  ekrctb · 2021-06-03 15:00:16 +09:00
  0ce7baa3f3
• Replace EntryCrossedBoundary with more useful RemoveRewoundEntry property

  It can be used for dynamically added entries.

  ekrctb · 2021-06-03 15:00:16 +09:00
  2c9e5b6c7e
• Factor out lifetime management logic of HitObjectContainer
  ekrctb · 2021-06-03 14:57:28 +09:00
  fe2934db1d
• Make method internal
  smoogipoo · 2021-06-02 11:11:41 +09:00
  d3d8941ec8
• Merge branch 'master' into fix-scrolling-lifetime
  smoogipoo · 2021-06-02 11:08:28 +09:00
  8ee2b3a2d2
• Merge pull request #13256 from ekrctb/update-lifetime-2

  Update DHO lifetime on entry lifetime change

  Dan Balasescu · 2021-06-02 11:07:54 +09:00
  ac83450791
• Simplify lifetime setter

  Setting entry lifetime will cause `LifetimeChanged` event and `base.LifetimeStart`/`End` will be modified in the callback.

  ekrctb · 2021-06-01 14:46:43 +09:00
  40949f6c1b
• Fix wrong code
  ekrctb · 2021-06-01 14:38:02 +09:00
  0f381f7758
• Revert invalid code transformation
  ekrctb · 2021-06-01 14:28:23 +09:00
  86020adf64
• Apply code styling suggestions

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  ekrctb · 2021-06-01 13:17:30 +09:00
  d5714e63b9
• Remove unused IScrollingHitObject interface
  ekrctb · 2021-05-31 23:17:26 +09:00
  86d1ba7ef2
• Make SetInitialLifetime public
  ekrctb · 2021-05-31 15:33:28 +09:00
  56a0a24cba
• Update drawable lifetime on entry lifetime change
  ekrctb · 2021-05-31 14:45:29 +09:00
  e25cca6fbe
• Merge pull request #13235 from ekrctb/update-lifetime-1

  Update hit object lifetime on `HitObject.DefaultsApplied`

  Dan Balasescu · 2021-05-31 14:44:40 +09:00
  8c6277f0d8
• Apply comment rewording suggestion

  Co-authored-by: Dan Balasescu <smoogipoo@smgi.me>

  ekrctb · 2021-05-31 13:41:49 +09:00
  0c101d2859
• Fix comment grammar
  ekrctb · 2021-05-30 13:06:28 +09:00
  abb77b95b4
• Add test case of DHO setting LifetimeStart in OnApply
  ekrctb · 2021-05-28 21:51:48 +09:00
  265dfe5416
• Reset lifetime on HitObject.DefaultsApplied
  ekrctb · 2021-05-28 21:35:26 +09:00
  43bf734816
• Fix wrong/misleading comment of InitialLifetimeOffset
  ekrctb · 2021-05-28 17:19:36 +09:00
  1d5e8f4a91
• Add a mention that OnApply/OnFree is performed after ApplyDefaults
  Dean Herbert · 2021-05-27 15:20:35 +09:00
  122bb05aa8
• Fix DHOs not receiving initial skin changed events
  smoogipoo · 2021-05-24 14:07:40 +09:00
  7494ddeef4
• Don't couple PoolableDrawableWithLifetime lifetime with its entry

  It turns out the incompatibility with `LifetimeManagementContainer` causes more issues than anticipated.

  ekrctb · 2021-05-20 14:56:15 +09:00
  0489ae719d
• Merge branch 'master' into always-use-lifetime-entry
  Dan Balasescu · 2021-05-18 20:10:12 +09:00
  ef81bdf63f
• Fix setting lifetime during KeepAlive is ignored
  ekrctb · 2021-05-04 16:56:48 +09:00
  aa42cf2fc0
• Throw an exception if try to modify lifetime of PoolableDrawableWithLifetime without lifetime
  ekrctb · 2021-05-04 16:04:58 +09:00
  36438175a0
• Merge branch 'master' into basic-compose-checks
  Dan Balasescu · 2021-04-30 23:41:46 +09:00
  e6eea73b8b
• Completely delegate DHO lifetime to Entry lifetime

  A downside is lifetime update is not caught by LifetimeManagementContainer if used.

  ekrctb · 2021-04-29 14:38:01 +09:00
  5aa522b1c2
• Always use LifetimeEntry to manage hit objects in HitObjectContainer

  Previously, non-pooled DHOs were immediately added as children of the HOC when Add is called. Also, non-pooled DHOs were always attached to the HOC as children.
  New behavior is that non-pooled DHOs are only added after CheckChildLifetime, and only attached to the HOC while the DHOs are alive.
  
  - LifetimeManagementContainer inheritance of HOC is removed, as it is now all DHOs are "unmanaged" (previously `AddInternal(false)`).
  - The signature of `Clear` is changed, and it is now always not disposing the children immediately.

  ekrctb · 2021-04-29 14:38:01 +09:00
  d262956146
• Merge pull request #12592 from ekrctb/fix-entry-lifetime

  Fix Setting DHO's lifetime doesn't update its entry lifetime

  Dan Balasescu · 2021-04-28 01:38:19 +09:00
  5fc731967b
• Simplify HitObjectLifetimeEntry logic a bit
  ekrctb · 2021-04-27 19:37:01 +09:00
  b87446a577
• Update osu.Game/Rulesets/Objects/Drawables/DrawableHitObject.cs

  Co-authored-by: Dan Balasescu <smoogipoo@smgi.me>

  Derrick Timmermans · 2021-04-27 11:29:16 +02:00
  3ea55314f2
• Adopt framework change of LifetimeEntry

  Override SetLifetimeStart/SetLifetimeEnd separately to track individual assignment. It is necessary to ensure real lifetime is not lost when lifetime is partially updated.

  ekrctb · 2021-04-27 17:54:18 +09:00
  3899e500d3
• Use now-public Entry.SetLifetime method
  ekrctb · 2021-04-27 15:25:05 +09:00
  c9e6ca5378
• Use overriding instead of hiding in HitObjectLifetimeEntry

  Hidden properties are used when the type is the base class. It caused issues when `DrawableHitObject` logic is factored out to `PoolableDrawableWithLifetime` because it is using the base `LifetimeEntry`, not `HitObjectLifetimeEntry`.

  ekrctb · 2021-04-27 15:23:33 +09:00
  a2c0951d94
• Add concurrent objects check

  Here we use `IHasColumn` to support rulesets with columns, and so I moved that interface out into `osu.Game` from `osu.Game.Rulesets.Mania`.
  
  We also use the same threshold as the unsnap check to ensure that no problems slip through. Specifically where an object is simultaneously not concurrent and not unsnapped but still on the same tick.

  Naxess · 2021-04-26 20:17:18 +02:00
  a3570e18dd
• Add method to safely refresh DrawableHitObject transforms
  Derrick Timmermans · 2021-04-26 20:08:40 +02:00
  08a232f7fa
• Rename DrawableObject -> PoolableDrawableWithLifetime
  ekrctb · 2021-04-26 12:06:21 +09:00
  6561a7c7d6
• freeIfInUse -> free, and add comments
  ekrctb · 2021-04-26 12:04:59 +09:00
  20e3cadd30
• Remove redundant statement (lifetime is set in base)
  ekrctb · 2021-04-26 11:47:38 +09:00
  e6474e6ff7