236 Commits

• Fix judgement offsets being zero when windows are empty
  Dean Herbert · 2020-11-05 18:58:37 +09:00
  a0b3379909
• Merge branch 'master' into drawable-hit-object-hit-state-fix
  Dean Herbert · 2020-11-05 17:07:52 +09:00
  0cadb31947
• Use BDL for top-level osu! DHOs
  smoogipoo · 2020-11-05 13:51:46 +09:00
  9a7fcadabc
• Change order of execution to be chronological
  Dean Herbert · 2020-11-04 17:14:23 +09:00
  68b7efe4d5
• Always execute UpdateHitStateTransforms (even for idle)
  Dean Herbert · 2020-11-04 17:14:23 +09:00
  831325978a
• Remove parameter from StartTime method and add obsoleted previous version
  Dean Herbert · 2020-11-04 16:39:52 +09:00
  3b6cf95f49
• Add new method handling hit state specifically

  Until now UpdateStateTransforms was applying results offsets to
  StartTime. This didn't cover the case of a HitObject with duration,
  where the call would be made with `StartTime + hitOffset` rather than
  `EndTime + hitOffset`.
  
  To resolve this, a new method has been added which should be used to
  handle hit-specific state transforms.

  Dean Herbert · 2020-11-04 16:13:14 +09:00
  7f30140b7e
• Don't force playback of (non-looping) DrawableHitObject samples after skin change
  Dean Herbert · 2020-10-07 18:18:01 +09:00
  3c3c1ce885
• Rename method back and add xmldoc
  Dean Herbert · 2020-10-05 16:24:02 +09:00
  c622adde7a
• Fix missing line
  Dean Herbert · 2020-10-05 15:12:34 +09:00
  9f43dedf59
• Don't stop non-looping samples immediately when pausing
  Dean Herbert · 2020-10-05 15:07:46 +09:00
  758088672c
• Replace object pattern match with simple conditional
  Bartłomiej Dach · 2020-10-03 08:09:10 +02:00
  2ddfd79923
• Replace comparison references to HitResult.Miss with IsHit
  Bartłomiej Dach · 2020-10-02 23:31:24 +02:00
  2b1ef16f89
• Merge pull request #10316 from smoogipoo/fix-spinner-flicker

  Fix default spinner flashing yellow glow before completion

  Dean Herbert · 2020-10-01 22:29:48 +09:00
  3069428efe
• Reword xmldocs to better describe nested events
  smoogipoo · 2020-10-01 21:54:43 +09:00
  ab33434a8a
• Remove redundant string interpolation
  smoogipoo · 2020-10-01 21:48:45 +09:00
  042c39ae1b
• Safeguard againts multiple ApplyResult() invocations
  smoogipoo · 2020-10-01 21:33:54 +09:00
  d7f9b8045c
• Merge branch 'master' into fix-hitobject-sample-stuck-on-future-seek
  Dean Herbert · 2020-10-01 16:46:14 +09:00
  b7ac779760
• Merge branch 'master' into scoring-standardisation
  smoogipoo · 2020-10-01 12:28:51 +09:00
  cb6b35116a
• Add obsoletion notice
  smoogipoo · 2020-10-01 12:28:33 +09:00
  c9f38f7bb6
• Merge branch 'fix-storyboard-sample-pausing' into fix-hitobject-sample-stuck-on-future-seek
  Dean Herbert · 2020-09-30 22:46:09 +09:00
  4b70fe8585
• Remove unused DI resolution
  Dean Herbert · 2020-09-30 15:50:53 +09:00
  6cceb42ad5
• Reverse inheritance order of SkinnableSound's pause logic
  Dean Herbert · 2020-09-30 15:45:14 +09:00
  414c40d298
• Add guard against using the wrong hit result
  smoogipoo · 2020-09-29 16:33:38 +09:00
  6264a01ecc
• Fix HitObject samples getting stuck in a playing state on seeking far into the future
  Dean Herbert · 2020-09-29 15:07:55 +09:00
  5d1c377379
• Use existing bindable flow instead
  Dean Herbert · 2020-09-29 12:50:17 +09:00
  d6f3beffb6
• Fix hit samples playing while paused / seeking in the editor
  Dean Herbert · 2020-09-28 18:17:47 +09:00
  4f0c0ea5f9
• Forcefully re-apply DrawableHitObject state transforms on post-load DefaultsApplied
  Dean Herbert · 2020-09-25 18:26:54 +09:00
  59bfa08684
• Avoid API change to DrawableHitObject
  Dean Herbert · 2020-09-24 13:28:29 +09:00
  33fad27ec2
• Reword xmldoc for legibility
  Dean Herbert · 2020-09-23 18:12:07 +09:00
  fee379b4b9
• Handle type/strength changes from samples changes
  Dean Herbert · 2020-09-23 18:09:40 +09:00
  9a0e5ac154
• Load nested hitobjects during map load
  smoogipoo · 2020-07-24 18:16:36 +09:00
  5f98195144
• Expose balance and sample loading methods in DrawableHitObject
  Dean Herbert · 2020-07-22 16:37:58 +09:00
  ac602846df
• Update state after applying hitobject
  smoogipoo · 2020-07-15 16:53:27 +09:00
  e95a1beaef
• Fix incorrect alpha application to lines on rewinding
  Dean Herbert · 2020-05-22 12:45:37 +09:00
  ce35d09e7d
• Silence hit sounds while seeking
  Dean Herbert · 2020-05-21 11:08:06 +09:00
  ce223a2bd8
• Use DrawableSample in SkinnableSound class
  Dean Herbert · 2020-05-20 20:49:01 +09:00
  c2697d3907
• Add test for final sample output
  Dean Herbert · 2020-05-19 23:28:13 +09:00
  db4e3047dd
• Make ScrollingHitObjectContainer respond to defaults applied events
  smoogipoo · 2020-05-08 18:49:58 +09:00
  22dda3fe02
• Add HitObject to DefaultsApplied event
  smoogipoo · 2020-05-08 18:49:19 +09:00
  efff2bf15d
• Add back necessary events + addition to list
  smoogipoo · 2020-04-22 18:32:59 +09:00
  93151f7612
• Remove obsolete methods
  smoogipoo · 2020-04-22 17:55:50 +09:00
  8b0274fedd
• Never run subtree masking
  Dean Herbert · 2020-04-20 20:48:35 +09:00
  8ebc2ae03d
• Move dampening to base implementation and change range to 0..1
  Dean Herbert · 2020-04-13 13:01:02 +09:00
  65b96079a0
• Merge branch 'master' of https://github.com/ppy/osu into stereo-shifted-playback
  Fire937 · 2020-04-12 01:46:32 +02:00
  22d89dbff7
• Add positional sound support for all rulesets

  The SamplePlaybackBalance is calculated in a way that the balance
  remains between -0.4 and 0.4.
  Positional sound is not supported in osu!taiko.

  Fire937 · 2020-04-12 01:33:25 +02:00
  f274ec297c
• Fix nested hitobjects potentially indirectly masked away
  smoogipoo · 2020-04-11 16:53:45 +09:00
  a84fe2525b
• Fix PositionalSound calculation implementation

  The position used to calculate the stereo balance is now the position of
  the drawable (as opposed to the position specified in the beatmap file
  previously).

  Fire937 · 2020-04-10 00:01:35 +02:00
  c17e470266
• Add stereo shifted hitsound playback support

  There is now a setting in the general settings called "Positional
  hitsounds". If the setting is enabled, the hitsounds playback will be
  shifted according to their position on the beatmap.

  Fire937 · 2020-04-09 18:12:15 +02:00
  2201e9b4ae
• Remove handle overrides
  Dean Herbert · 2020-03-30 11:59:51 +09:00
  7db9bd798c