h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2024-12-15 09:02:55 +08:00
Code Issues Releases Wiki Activity

Fix PositionalSound calculation implementation

Browse Source 
The position used to calculate the stereo balance is now the position of
the drawable (as opposed to the position specified in the beatmap file
previously).
This commit is contained in:
Fire937 2020-04-10 00:01:35 +02:00
parent 2201e9b4ae
commit c17e470266
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
osu.Game/Rulesets/Objects/Drawables/DrawableHitObject.cs
View File

@ -94,7 +94,7 @@ namespace osu.Game.Rulesets.Objects.Drawables
/// <summary>
/// The stereo balance of the samples played if <i>Positional hitsounds</i> is set.
/// </summary>
protected virtual float PositionalSound => (HitObject is IHasXPosition position) ? (position.X / 512f - 0.5f) * 0.8f : 0;
protected virtual float PositionalSound => (Position.X / 512f - 0.5f) * 0.8f;
private BindableList<HitSampleInfo> samplesBindable;
private Bindable<double> startTimeBindable;
@ -114,7 +114,6 @@ namespace osu.Game.Rulesets.Objects.Drawables
protected DrawableHitObject([NotNull] HitObject hitObject)
{
HitObject = hitObject ?? throw new ArgumentNullException(nameof(hitObject));
positionalSoundAdjustment.Value = PositionalSound;
}
[BackgroundDependencyLoader]
@ -377,7 +376,11 @@ namespace osu.Game.Rulesets.Objects.Drawables
/// Plays all the hit sounds for this <see cref="DrawableHitObject"/>.
/// This is invoked automatically when this <see cref="DrawableHitObject"/> is hit.
/// </summary>
public virtual void PlaySamples() => Samples?.Play();
public virtual void PlaySamples()
{
positionalSoundAdjustment.Value = PositionalSound;
Samples?.Play();
}
protected override void Update()
{