Dan Balasescu
|
b7c12ff61e
|
Merge pull request #10530 from peppy/fix-catch-dual-combo-counter
Fix osu!catch showing two combo counters for legacy skins
|
2020-10-16 23:52:14 +09:00 |
|
smoogipoo
|
dfbc0965e4
|
Merge branch 'master' into peppy/skinnable-health-display
|
2020-10-16 23:17:17 +09:00 |
|
Dean Herbert
|
e87f515a4f
|
Merge pull request #10522 from Morilli/legacyskin-fixes
Add support for ScorePrefix and ScoreOverlap values in legacy skins
|
2020-10-16 20:54:03 +09:00 |
|
Berkan Diler
|
cc11283143
|
Use string.Starts-/EndsWith char overloads
|
2020-10-16 11:27:02 +02:00 |
|
Dean Herbert
|
8a3bce3cc3
|
Fix osu!catch showing two combo counters for legacy skins
|
2020-10-16 18:20:17 +09:00 |
|
Dean Herbert
|
a774de2270
|
Also add support in LegacyComboCounter
|
2020-10-16 17:52:22 +09:00 |
|
Dean Herbert
|
77bf050a80
|
Ignore IgnoreHits for flashiness
|
2020-10-16 17:24:43 +09:00 |
|
Dean Herbert
|
f0b15813e2
|
Add support for both legacy styles
|
2020-10-16 17:08:46 +09:00 |
|
Dean Herbert
|
a810f56ec8
|
Move "flash on hit only" logic to binding
|
2020-10-16 17:08:46 +09:00 |
|
Dean Herbert
|
c0a1f2158c
|
Add basic component structure for skinnable health displays
|
2020-10-16 17:08:46 +09:00 |
|
Dan Balasescu
|
829241a9f0
|
Merge pull request #10521 from peppy/fix-editor-seek-interval-when-playing
Fix editor not seeking by full beat when track is playing
|
2020-10-16 13:55:03 +09:00 |
|
Dean Herbert
|
aea31d1582
|
Fix editor not seeking by full beat when track is playing
This is expected behaviour as my osu-stable, and I still stand behind
the reasoning behind it.
Closes #10519.
|
2020-10-16 13:07:00 +09:00 |
|
Dean Herbert
|
88ffcb9234
|
Update EndsWith usages
|
2020-10-16 12:58:34 +09:00 |
|
Dean Herbert
|
88f74921fb
|
Update with new r# inspections
|
2020-10-16 12:49:39 +09:00 |
|
Dan Balasescu
|
583fdc3a95
|
Merge pull request #10510 from peppy/skinnable-accuracy-display
Add legacy skinning support for accuracy display
|
2020-10-15 21:20:48 +09:00 |
|
Dan Balasescu
|
5d8cf87155
|
Merge pull request #10511 from peppy/bottom-error-display
Add support for bottom-anchored hit error display
|
2020-10-15 20:51:09 +09:00 |
|
Dan Balasescu
|
70b050f212
|
Merge branch 'master' into skinnable-accuracy-display
|
2020-10-15 20:28:57 +09:00 |
|
Dan Balasescu
|
1ce0e83e59
|
Merge branch 'master' into skinnable-score-display
|
2020-10-15 19:16:03 +09:00 |
|
Dan Balasescu
|
93dfbd5d9e
|
Merge pull request #10505 from peppy/skin-disabler-refactor
Move ISampleDisabler implementation to Player and FrameStabilityContainer
|
2020-10-15 19:14:52 +09:00 |
|
Dean Herbert
|
70806deba1
|
Add support for bottom-anchored hit error display
|
2020-10-15 19:14:02 +09:00 |
|
Dean Herbert
|
d76365ed1b
|
Make container readonly
|
2020-10-15 18:38:41 +09:00 |
|
Dan Balasescu
|
5640d33d1a
|
Merge branch 'master' into skin-disabler-refactor
|
2020-10-15 18:32:50 +09:00 |
|
Dean Herbert
|
6983978c98
|
Correct top-right element offset by finding the lower top anchor element
|
2020-10-15 18:30:44 +09:00 |
|
Dean Herbert
|
b31a3fbabb
|
Add test
|
2020-10-15 18:11:30 +09:00 |
|
Dean Herbert
|
254eba9008
|
Add and consume skinnable accuracy counter
|
2020-10-15 17:53:16 +09:00 |
|
Dean Herbert
|
90ff8ff050
|
Merge branch 'skinnable-combo-counter' into skinnable-score-display
|
2020-10-15 17:52:06 +09:00 |
|
Dean Herbert
|
37e9f331ad
|
Simplify score font lookup
|
2020-10-15 17:49:55 +09:00 |
|
Dean Herbert
|
43e5cb90e2
|
Merge branch 'skinnable-combo-counter' into skinnable-score-display
|
2020-10-15 17:30:29 +09:00 |
|
Dean Herbert
|
9f51327e4b
|
Fix completely incorrect default positioning logic
|
2020-10-15 17:29:40 +09:00 |
|
Dean Herbert
|
5b5ba7df93
|
Remove unused offset
|
2020-10-15 17:22:34 +09:00 |
|
Dean Herbert
|
d8d085ede9
|
Align top-right elements with lowest point in score display
|
2020-10-15 17:14:42 +09:00 |
|
Dean Herbert
|
74c031cfbb
|
Fix ModOverlay not including "UNRANKED" text in size
|
2020-10-15 17:14:42 +09:00 |
|
Dean Herbert
|
b210147c2e
|
Update combo counter to read from default score display's position correctly
|
2020-10-15 17:14:42 +09:00 |
|
Dean Herbert
|
950c47287c
|
Fix positioning of score display in HUD overlay
|
2020-10-15 17:14:42 +09:00 |
|
Dean Herbert
|
e1da64398e
|
Add and consume skinnable score counter
|
2020-10-15 17:14:42 +09:00 |
|
Dean Herbert
|
219cbec6bd
|
Split out DefaultScoreCounter and make ScoreCounter abstract
|
2020-10-15 16:32:30 +09:00 |
|
Dean Herbert
|
d5f2aab52e
|
Tidy up SkinnableComboCounter class slightly
|
2020-10-15 15:37:40 +09:00 |
|
Dean Herbert
|
e0210f5c4c
|
Ignore failed casts to make tests happy
|
2020-10-14 23:52:58 +09:00 |
|
Dean Herbert
|
e3eaba7b2c
|
Move ISampleDisabler implementation to Player and FrameStabilityContainer
|
2020-10-14 19:39:48 +09:00 |
|
Dean Herbert
|
ac4f56403d
|
Adjust size/position
|
2020-10-14 19:16:34 +09:00 |
|
Dean Herbert
|
7f5ea57bd4
|
Clean-up pass (best effort) on LegacyComboCounter
|
2020-10-14 19:16:34 +09:00 |
|
Dean Herbert
|
9bb8a43bce
|
Combine LegacyComboCounter and ComboCounter classes
|
2020-10-14 19:16:34 +09:00 |
|
Dean Herbert
|
fbbea48c8c
|
Add score text skinnability
|
2020-10-14 19:16:34 +09:00 |
|
Dean Herbert
|
2fce064e32
|
Add basic legacy combo counter and updating positioning logic
|
2020-10-14 19:16:34 +09:00 |
|
Dean Herbert
|
6a6718ebab
|
Allow bypassing origin/anchor setting of skinnable components
It makes little sense to set these when using RelativeSizeAxes.Both
|
2020-10-14 19:16:34 +09:00 |
|
Dean Herbert
|
899bac6ca5
|
Rename catch combo counter for clarity
|
2020-10-14 19:16:34 +09:00 |
|
Dean Herbert
|
f5623ee21e
|
Setup skinnable combo counter component with default implementation
|
2020-10-14 19:16:34 +09:00 |
|
Dean Herbert
|
60603d2918
|
Add skin components and interfaces
|
2020-10-14 19:16:34 +09:00 |
|
Dean Herbert
|
98acf1e31d
|
Make field read only
|
2020-10-14 19:16:25 +09:00 |
|
Dean Herbert
|
a7f8e26e35
|
Adjust bottom-right elements positions based on song progress display
|
2020-10-14 18:51:53 +09:00 |
|