osu-lazer

Improve safety of ongoing operation tracker

Finishing an operation started via
`OngoingOperationTracker.BeginOperation()` was risky in cases where the
operation ended at a callback on another thread (which, in the case of
multiplayer, is *most* cases). In particular, if any consumer registered
a callback that mutates transforms when the operation ends, it would
result in crashes after the framework-side safety checks.

Rework `OngoingOperationTracker` into an always-present component
residing in the drawable hierarchy, and ensure that the
`operationInProgress` bindable is always updated on the update thread.
This way consumers don't have to add local schedules in multiple places.

Bartłomiej Dach · 2021-01-09 22:45:24 +01:00

8c3955d341

Merge branch 'master' into disable-repeat-multi-actions

Dean Herbert · 2021-01-09 10:15:20 +09:00

b69fe8a274

Move out test ongoing operation tracker to higher level

Bartłomiej Dach · 2021-01-08 22:28:21 +01:00

ff60d652ed

Add simple test coverage

Salman Ahmed · 2021-01-05 06:00:15 +03:00

81355652fa

Merge branch 'master' into disable-repeat-multi-actions

Dean Herbert · 2021-01-04 23:38:29 +09:00

deb1ad7bca

Move game start logic to a higher level

Bartłomiej Dach · 2020-12-30 18:15:48 +01:00

f800448c87

Rename On{ToggleReady -> ReadyClick}

Bartłomiej Dach · 2020-12-30 16:29:36 +01:00

d34609b98e

Trim missed reference to deleted member

Bartłomiej Dach · 2020-12-29 11:53:42 +01:00

f2163a471a

Cache tracker in test scene to resolve test fails

Bartłomiej Dach · 2020-12-29 09:16:08 +01:00

274730de34

Move ready-up operation logic again to client

To salvage ready up button tests.

Bartłomiej Dach · 2020-12-29 09:16:02 +01:00

e9b0652359

Adjust tracker usages to match new API

Bartłomiej Dach · 2020-12-29 08:20:43 +01:00

db52255bbe

Merge branch 'master' into disable-repeat-multi-actions

Bartłomiej Dach · 2020-12-29 07:42:20 +01:00

f68e4fc88f

Rename variable to make more sense

It needs to be explicitly stated that the users in this list are related
to the *joined* room. Especially since it's sharing its variable name
with `SpectatorStreamingClient` where it has the opposite meaning (is a
list of *globally* playing players).

Dean Herbert · 2020-12-29 14:27:35 +09:00

e3a41f6118

Disable create room button after triggering join

Bartłomiej Dach · 2020-12-28 22:48:03 +01:00

af66e45311

Disable ready button after host click

Bartłomiej Dach · 2020-12-28 22:48:03 +01:00

47ab7c9fd6

Merge pull request #11341 from peppy/fix-leaderboard-user-handling

Fix incorrect null handling in GameplayLeaderboard

Dean Herbert · 2020-12-28 22:44:55 +09:00

9155671557

Merge pull request #11342 from bdach/fix-beatmap-not-reverting

Fix user changes in multi song select not reverting on exit without confirmation

Dean Herbert · 2020-12-28 21:56:07 +09:00

2e88036f39

Merge branch 'master' into fix-leaderboard-user-handling

Bartłomiej Dach · 2020-12-28 13:43:53 +01:00

a376a23ed7

Add failing test cases

Bartłomiej Dach · 2020-12-28 12:35:16 +01:00

fb21b7c016

Move multiplayer leaderboard test to correct namespace

Dean Herbert · 2020-12-28 20:31:08 +09:00

6254907ef9

Allow null users to still be displayed in the participant list

The fix here is correcting the access of `user.Country`. The deicision
to have null users display is because this is the best we can do (if
osu-web could not resolve the user). We still want the users in the
lobby to be aware of this user's presence, rather than hiding them from
view.

osu-stable does a similar thing, showing these users as `[Loading]`. I
decided to go with blank names instead because having *any* text there
causes confusion. We can iterate on this in future design updates.

Dean Herbert · 2020-12-28 15:03:44 +09:00

046a76cb1d

Rename I{Multiplayer -> OnlinePlay}SubScreen

Bartłomiej Dach · 2020-12-25 18:07:34 +01:00

4c43a67b68

Re-namespace all files in OnlinePlay directory

Bartłomiej Dach · 2020-12-25 16:50:09 +01:00

83fb7c7a1a

Update some missed variables

Dean Herbert · 2020-12-25 23:36:09 +09:00

e421b6d34e

Fix other missed cases of changing inheritance