321 Commits

• Remove outdated warning disable

  Does not trigger any more on Rider 2020.3.2.

  Bartłomiej Dach · 2021-01-06 18:38:25 +01:00
  4998aaaa98
• Fix incorrect initial conditional

  Turns out this wasn't actually required.

  Dean Herbert · 2021-01-03 22:44:32 +09:00
  53e6a349bb
• Ensure SelectionChanged events are only sent once when selection is null
  Dean Herbert · 2021-01-03 12:53:25 +09:00
  a6d4992997
• Fix the beatmap carousel not returning to centre correctly after resizing window
  Dean Herbert · 2021-01-02 22:05:41 +09:00
  e2de5bb8f9
• Fix beatmap carousel panels getting masked away when out of scroll bounds

  Regressed in https://github.com/ppy/osu/pull/10973 due to removed masking specification.
  
  Closes #11067.

  Dean Herbert · 2020-12-03 13:26:28 +09:00
  897f593b37
• Allow scroll type to be specified

  This brings back the ability for the carousel to scroll in a classic
  way. It turns out this is generally what we want for "seek" operations
  like "random", else it's quite hard to get the expected animation.
  
  I did experiment with applying the animation after the pooled panels are
  retrieved, but in a best-case scenario there is still a gap where no
  panels are displayed during the random seek operation.

  Dean Herbert · 2020-11-27 13:54:38 +09:00
  792934f2c4
• Delegate scroll animation to panels themselves
  Dean Herbert · 2020-11-26 18:42:51 +09:00
  0a48dd8f76
• Update scroll position before applying any panel animations

  In the case of automatic scroll requirements (ie. scroll to selected) we
  are delegating the animation logic to the panels themselves. In order to
  make this work correctly, the scroll operation needs to take effect
  before any animation updates are run.

  Dean Herbert · 2020-11-26 18:33:41 +09:00
  ad258e2e52
• Move drawable carousel set movement logic into panels themselves
  Dean Herbert · 2020-11-26 18:32:43 +09:00
  6058c66edb
• Remove ScrollableContent container from carousel

  This was causing multiple issues with masking and sizing and really
  didn't need to exist in the first place. Also not sure why the pool was
  nested inside the scroll container, but it isn't any more. Probably for
  the best.

  Dean Herbert · 2020-11-26 18:28:54 +09:00
  f8db7a9902
• Ensure visible items is greater than zero before trying to display a range
  Dean Herbert · 2020-10-19 19:55:20 +09:00
  d5940193a2
• Ensure max value in clamp is at least zero
  Dean Herbert · 2020-10-19 19:10:01 +09:00
  9106e97c37
• Replace comment with link to issue
  Dean Herbert · 2020-10-19 18:41:28 +09:00
  1c2185e969
• Fix out of bounds issues
  Dean Herbert · 2020-10-19 18:41:17 +09:00
  044622a7a6
• Account for panel height when removing as off-screen
  Dean Herbert · 2020-10-19 13:13:32 +09:00
  bff3856c83
• Fix off-by-one in display range retrieval logic
  Dean Herbert · 2020-10-19 13:05:42 +09:00
  ee0efa0b4c
• Remove outdated comment logic
  Dean Herbert · 2020-10-19 13:04:12 +09:00
  4590d9b93b
• Locallise ChildItems to DrawableCarouselBeatmapSet for clarity
  Dean Herbert · 2020-10-13 19:31:29 +09:00
  5d11db7753
• Add comment about off-screen loading
  Dean Herbert · 2020-10-13 19:10:35 +09:00
  8eca28e8bc
• Unmark todo for now
  Dean Herbert · 2020-10-13 18:47:36 +09:00
  a1801f8ae4
• Avoid allocating CarouselItems for bounds checks
  Dean Herbert · 2020-10-13 18:33:31 +09:00
  40a0ab7aaa
• Remove logging
  Dean Herbert · 2020-10-13 18:18:22 +09:00
  83358d487f
• Simplify vertical position calculations by including spacing in height definition
  Dean Herbert · 2020-10-13 18:13:36 +09:00
  69650c16fc
• Fix masking issues with certain aspect ratio displays
  Dean Herbert · 2020-10-13 17:37:33 +09:00
  f3b937e358
• Fix failing tests
  Dean Herbert · 2020-10-13 17:37:33 +09:00
  1f0aa974dd
• Extract header element from base DrawableCarouselItem class
  Dean Herbert · 2020-10-13 17:37:33 +09:00
  cfec4f4fc1
• Fix x offsets of difficulties not being updated
  Dean Herbert · 2020-10-13 17:37:33 +09:00
  2aad482545
• Use expiry to avoid ToArray
  Dean Herbert · 2020-10-13 17:37:33 +09:00
  1b7e3397c6
• Better track off-screen drawables (and return to pool less often)
  Dean Herbert · 2020-10-13 17:37:33 +09:00
  075bf23714
• Replace pool/cleanup logic with simplest form possible

  This will temporarily break panels that go off-screen, as they will
  disappear immediately

  Dean Herbert · 2020-10-13 17:37:33 +09:00
  29983afcef
• Add comments and split out update steps into a more logical flow
  Dean Herbert · 2020-10-13 17:37:33 +09:00
  06e84c8eb3
• Move transform clean-up to pooling free call
  Dean Herbert · 2020-10-13 17:37:33 +09:00
  20b54fb904
• Store y positions inside items rather than in a separate array
  Dean Herbert · 2020-10-13 17:37:33 +09:00
  f6aa448523
• Add logging
  Dean Herbert · 2020-10-13 17:37:33 +09:00
  b92c22ad42
• Add back difficulty panel spacing
  Dean Herbert · 2020-10-13 17:37:33 +09:00
  fd8654cff3
• Fix single results not showing up
  Dean Herbert · 2020-10-13 17:37:33 +09:00
  ce67f65084
• Fix incorrect vertical offsets when difficulties are filtered away
  Dean Herbert · 2020-10-13 17:37:33 +09:00
  220c8ba2c4
• Add initial pass of vertical transforms
  Dean Herbert · 2020-10-13 17:37:33 +09:00
  8847cedf29
• Base bounds checks on +1 (to avoid worrying about current item heights)
  Dean Herbert · 2020-10-13 17:37:33 +09:00
  15325f5f51
• Temporarily disable masking temporarily to fix panels disappearing at extents
  Dean Herbert · 2020-10-13 17:37:33 +09:00
  bb03c5d77c
• Fix scroll to selected beatmap
  Dean Herbert · 2020-10-13 17:37:33 +09:00
  c5a6f4b453
• Add back left offset for selected set
  Dean Herbert · 2020-10-13 17:37:33 +09:00
  5c2f134665
• Add back panel padding
  Dean Herbert · 2020-10-13 17:37:33 +09:00
  ca1f5dcada
• Load more components asynchronously after pool resolution
  Dean Herbert · 2020-10-13 17:37:33 +09:00
  0400b34349
• Avoid performing eager selection constantly on adding ranges of new children
  Dean Herbert · 2020-10-13 17:37:33 +09:00
  f3b24b9bb5
• Add basic pooling setup
  Dean Herbert · 2020-10-13 17:37:33 +09:00
  0a978c6131
• Add basic range-based invalidation
  Dean Herbert · 2020-10-13 17:37:33 +09:00
  f17d661c1a
• Refactor how drawable carousel items are constructed
  Dean Herbert · 2020-10-13 17:37:33 +09:00
  3143224e5b
• Update outdated comment
  Dean Herbert · 2020-07-13 13:08:41 +09:00
  0718e9e4b6
• Fix correct filter criteria not being applied to beatmap carousel if beatmaps take too long to load
  Dean Herbert · 2020-07-12 22:33:41 +09:00
  ab11a112b7