315 Commits

• Move shared implementation to a named function
  Dean Herbert · 2020-12-14 13:56:46 +09:00
  b81dbfc192
• Remove EffectiveXBindable (setting Value was not handled)

  And use orthogonal `OriginalXBindable` and `XOffsetBindable`.

  ekrctb · 2020-12-14 13:39:07 +09:00
  5b5e883904
• Fix comment
  ekrctb · 2020-12-14 13:18:32 +09:00
  0ad256a762
• Revert "Remove X setter from CatchHitObject"

  This reverts commit 7cbbd74d

  ekrctb · 2020-12-14 13:18:14 +09:00
  d96399ea42
• Remove X setter from CatchHitObject
  ekrctb · 2020-12-14 11:38:07 +09:00
  7cbbd74df2
• Add some more doc comment
  ekrctb · 2020-12-14 11:32:34 +09:00
  f621d977fc
• Use OriginalX for CatchHitObject.X instead of EffectiveX

  And explicitly implement IHasXPosition interface to prevent use of the X property.
  It should be preferred for beatmap conversion purpose.

  ekrctb · 2020-12-14 11:26:05 +09:00
  36529bdd1b
• Add doc comments to catch hit object X properties
  ekrctb · 2020-12-14 11:15:49 +09:00
  089f3bebf5
• XBindable -> EffectiveXBindable in catch DHO
  ekrctb · 2020-12-14 11:05:26 +09:00
  cd2db59900
• Replace CatchHitObject.X usage to EffectiveX and OriginalX
  ekrctb · 2020-12-14 11:03:14 +09:00
  96f3e0dad8
• Obsolete X getter
  ekrctb · 2020-12-14 11:03:10 +09:00
  c1f3f1c231
• Separate asymmetric CatchHitObject.X to EffectiveX and OriginalX
  ekrctb · 2020-12-14 11:03:03 +09:00
  8da502da44
• Add some spacing to interface class
  Dean Herbert · 2020-12-11 16:43:00 +09:00
  c0d20d8ce4
• Combine DisplayRadius and Scale to DisplaySize
  ekrctb · 2020-12-10 20:43:01 +09:00
  2634c6b8d9
• Add ScalingContainer back

  Don't want to set DHO.Scale or DHO.Rotation because because DHO may be transformed by mods.
  DHO.Size is also assigned for drawable visualizer

  ekrctb · 2020-12-10 19:42:01 +09:00
  e097b6e61c
• Remove unneeded lifetime assignment
  ekrctb · 2020-12-09 10:47:04 +09:00
  775c4bad97
• Move classes to separate files
  ekrctb · 2020-12-09 10:40:42 +09:00
  da2f3d4473
• Revert rename error
  ekrctb · 2020-12-09 10:25:35 +09:00
  b80204642e
• Rename to CopyStateFrom, and add comment
  ekrctb · 2020-12-08 23:35:24 +09:00
  1212ffd24f
• Add doc comments a bit
  ekrctb · 2020-12-08 23:11:22 +09:00
  5ca98b0033
• Pool caught objects and dropped objects
  ekrctb · 2020-12-08 22:38:10 +09:00
  749d5380ca
• Introduce IHasCatchObjectState implemented by DHO and CaughtObject
  ekrctb · 2020-12-08 21:29:26 +09:00
  a32dac00dd
• Make object on the catcher plate separate CaughtObject class
  ekrctb · 2020-12-08 21:11:40 +09:00
  c301223d8c
• Remove ScaleContainer and flatten the Drawable tree of catch DHO
  ekrctb · 2020-12-08 20:37:08 +09:00
  004c705aa9
• Merge branch 'master' into fruit-piece-in-place
  Dan Balasescu · 2020-12-08 17:42:34 +09:00
  1757b9c3e7
• Restore catcher state on revert judgement result
  ekrctb · 2020-12-08 15:03:03 +09:00
  cb76a2d7b5
• Merge branch 'master' into fruit-piece-in-place
  ekrctb · 2020-12-07 18:57:42 +09:00
  b2e5658d23
• Don't inherit Fruit from Banana
  ekrctb · 2020-12-07 14:10:17 +09:00
  c1d39b6401
• Don't inherit DrawableFruit from DrawableBanana

  - A banana cannot be hyper

  ekrctb · 2020-12-07 14:08:50 +09:00
  7f1ad1040d
• Allow PulpFormation to update formation dynamically

  Pulps are lazily allocated but never deallocated for a DrawableFruit

  ekrctb · 2020-12-07 13:56:22 +09:00
  b8f1c499a4
• Refactor catch default piece to allow reuse

  But Fruit in-place update is still incomplete,
  as child drawables are recreated when reused.

  ekrctb · 2020-12-07 13:14:00 +09:00
  0d73bf8488
• Don't recreate pieces when catch DHO is reused
  ekrctb · 2020-12-07 12:59:03 +09:00
  d51d2c5331
• Adjust namespace
  ekrctb · 2020-12-07 12:35:24 +09:00
  d18397acad
• Move piece files of Catch ruleset
  ekrctb · 2020-12-07 12:34:38 +09:00
  b4b9312e0f
• Merge branch 'master' into caught-object-refactor
  Dean Herbert · 2020-12-04 14:12:33 +09:00
  aa24890aff
• Merge pull request #11055 from ekrctb/catch-stateless-rng
  Dean Herbert · 2020-12-04 13:08:30 +09:00
  0134ac94a7
• Simplify the fruit stacking code

  It is now more clear that
  the expression of distance checking is probably unintended (a bug)

  ekrctb · 2020-12-03 16:44:36 +09:00
  873f2363c1
• Use transformation to set fruit rotation
  ekrctb · 2020-12-03 12:13:14 +09:00
  2e8195e059
• Make RandomSeed a property, not a bindable
  ekrctb · 2020-12-02 20:53:47 +09:00
  fdcfa81e46
• Set banana combo colour using random seed
  ekrctb · 2020-12-02 17:12:30 +09:00
  08848e49de
• Use deterministic randomness in catch hit object
  ekrctb · 2020-12-02 16:54:18 +09:00
  8b6161a51c
• Introduce RandomSeed in catch DHO
  ekrctb · 2020-12-02 16:53:01 +09:00
  e7c0e9834f
• Fix bananas not playing sounds
  smoogipoo · 2020-12-02 15:22:54 +09:00
  946613e803
• Merge pull request #11033 from smoogipoo/immutable-hit-samples

  Make HitSampleInfo immutable

  Dean Herbert · 2020-12-02 14:44:26 +09:00
  71a121389b
• Fix bad equality comparer implementations
  smoogipoo · 2020-12-01 18:13:53 +09:00
  6b4a6c12c8
• Implement equality comparers for HitSampleInfo
  smoogipoo · 2020-12-01 16:04:08 +09:00
  199710b941
• Make HitSampleInfo immutable
  smoogipoo · 2020-12-01 15:37:51 +09:00
  5760e1c1fc
• Use hit object pooling for BananaShower.
  ekrctb · 2020-11-30 19:22:40 +09:00
  70628235e3
• Use hit object pooling for JuiceStream.

  - Use `Clear(false)` to not dispose pooled children.
  - Don't set nested DHO `Origin`.
  - Simplify the layout (remove custom `Origin`).

  ekrctb · 2020-11-30 19:19:14 +09:00
  9611aaf09e
• Use hit object pooling for Fruit and Banana.
  ekrctb · 2020-11-30 19:07:50 +09:00
  b76ae525b2