144 Commits

• Store RawTime in JudgementResult
  ekrctb · 2023-02-09 17:15:37 +09:00
  258de3b2d8
• Merge branch 'maximum-judgement-offset-in-hit-object' into revert-result-in-playfield
  ekrctb · 2023-02-09 16:47:58 +09:00
  5f0636c330
• Remove JudgementResultEntry

  It is not needed anymore as TimeAbsolute is stored raw.

  ekrctb · 2023-01-27 19:35:44 +09:00
  27578c48f5
• Store Result.TimeAbsolute separately from offset

  Calculating from TimeOffset is bad because it loses precision.
  The result time won't change anymore
  even If `HitObject.GetEndTime()` changes later.

  ekrctb · 2023-01-24 15:35:06 +09:00
  efef97d5be
• Remove unused code
  ekrctb · 2023-01-24 14:15:17 +09:00
  e66e43e17c
• Move judgement result revert logic to Playfield

  Previously, some judgement results were not reverted
  when the source DHO is not alive (e.g. frames skipped in editor).
  Now, all results are reverted in the exact reverse order.

  ekrctb · 2023-01-19 19:57:13 +09:00
  812a4b412a
• Fix judgement text never being added to hierarchy
  Bartłomiej Dach · 2022-12-24 09:37:40 +01:00
  80de5dac66
• Remove unused resolved member
  Bartłomiej Dach · 2022-12-24 09:34:30 +01:00
  f973befcd4
• Move judgement text creation to base class and tidy things up
  Dean Herbert · 2022-12-24 12:22:36 +08:00
  5e9fb1063a
• Combine base class for JudgementPiece
  Dean Herbert · 2022-12-24 03:32:13 +08:00
  727ac00f6d
• Partial everything
  Dan Balasescu · 2022-11-27 00:00:27 +09:00
  7bc8908ca9
• Merge branch 'master' into taiko-judgement-fixes
  Dan Balasescu · 2022-11-11 15:48:33 +09:00
  5bdbf56f43
• Add "Component" prefix to lookup naming
  Dean Herbert · 2022-11-09 17:46:43 +09:00
  1aa0e40f2f
• Rename ISkinComponent to ISkinLookup
  Dean Herbert · 2022-11-09 17:46:43 +09:00
  c908969d9b
• Apply nullability to skinning support classes
  Dean Herbert · 2022-11-09 13:59:13 +09:00
  bf26dbffc2
• Remove unnecessary centering logic in DrawableJudgement
  Dean Herbert · 2022-11-07 17:19:32 +09:00
  2b72c3833b
• Update usages of RemoveInternal
  Dean Herbert · 2022-08-29 15:57:40 +09:00
  105aa01e7d
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Increase HP lost for misses
  Dan Balasescu · 2022-05-20 17:53:14 +09:00
  b29172ea45
• Make Meh judgements not drain HP
  Dan Balasescu · 2022-05-20 15:36:30 +09:00
  3fdff7bbcb
• Fix osu! judgements getting scaled twice over different durations
  Dean Herbert · 2021-09-02 16:31:43 +09:00
  b907c2f4f6
• Ensure proxied judgement content is correctly depth-ordered
  Bartłomiej Dach · 2021-08-01 15:21:31 +02:00
  f868a201f5
• Remove redundant arguments
  PercyDan54 · 2021-07-05 23:52:39 +08:00
  e1c646b9b2
• Remove more obsoleted members
  Dean Herbert · 2021-06-09 14:10:48 +09:00
  f41e34ae2c
• Remove obsoleted DrawableJudgement methods

  Undated, but change was made on 2020-11-18.

  Dean Herbert · 2021-06-09 14:09:23 +09:00
  a87226ab10
• Remove obsolete code
  smoogipoo · 2021-04-09 13:56:58 +09:00
  8293b06c0a
• Adjust scoring values to better fit osu!mania
  smoogipoo · 2021-04-05 13:28:46 +09:00
  3acc612a67
• Fix taiko leaving behind empty judgements on legacy skins
  Bartłomiej Dach · 2021-03-06 16:02:20 +01:00
  06e42b4b4c
• Fix default judgement text mispositioned for one frame
  smoogipoo · 2021-01-14 12:33:33 +09:00
  d5878db615
• Uncomment incorrectly commented lines
  Dean Herbert · 2020-11-25 12:11:44 +09:00
  c46d655832
• Remove left over logging line
  Dean Herbert · 2020-11-24 15:28:03 +09:00
  1682260677
• Fix DrawableJudgement not always animating correctly on skin change

  If the skin is changed before gameplay has started (at the loading
  screen) it is possible for a sequence of events to occur which results
  in the animation not being played:
  
  - `SkinReloadableDrawable` runs its BDL load (and calls `OnSkinChanged`
    once)
  - User changes skin, triggering `DrawableJudgement`'s skin change
    handling (binding directly on the `SkinSource` locally)
  - This will call `PrepareDrawables` and reinitialise the
    `SkinnableDrawable` child hierarchy, then immediately apply the
  animations to it.
  - The new `SkinnableDrawable` will then get the `SkinChanged` event and
    schedule a handler for it, which will run on its first Update call.
  - Any added animations will be lost as a result.
  
  Fixed by binding directly to the `SkinnableDrawable`'s `OnSkinChanged`.
  This has the added bonus of not needing to reinitialise the child
  hierarchy on skin change (which felt a bit weird in the first place).

  Dean Herbert · 2020-11-24 15:23:53 +09:00
  ee33f62809
• Add comment covering intentional call to ClearTransformsAfter
  Dean Herbert · 2020-11-23 15:20:59 +09:00
  19faa2b9bb
• Rewind judgement transforms before clearing
  Bartłomiej Dach · 2020-11-21 17:56:49 +01:00
  9f997db958
• Don't show default judgements in front of objects for now
  Dean Herbert · 2020-11-20 16:30:58 +09:00
  53b6d90ab4
• Move CanBeNull specification to the interface
  Dean Herbert · 2020-11-20 16:30:48 +09:00
  a00e0d7279
• Show main judgement content above hitobjects
  Dean Herbert · 2020-11-20 16:25:48 +09:00
  7fe0923fcf
• Add null check for disposal safety
  Dean Herbert · 2020-11-19 14:04:43 +09:00
  ba735584fa
• Update xmldoc to match new behaviour
  Dean Herbert · 2020-11-18 19:38:38 +09:00
  b3bec81b79
• Reduce nesting of skinned component to reduce exposed surface
  Dean Herbert · 2020-11-18 19:34:27 +09:00
  8522ddc61e
• Fix animation playback not running on skin change
  Dean Herbert · 2020-11-18 19:03:34 +09:00
  ee8804b50b
• Update animations for new/old miss style and add fades
  Dean Herbert · 2020-11-18 19:03:34 +09:00
  c47e70da9b
• Fix hit lighting dictating lifetime even when not present in skin
  Dean Herbert · 2020-11-18 19:03:34 +09:00
  9d3de5bca0
• Handle DrawableJudgement lifetime more flexibly
  Dean Herbert · 2020-11-18 19:03:34 +09:00
  72a15ef2dc
• Remove fades from DrawableJudgement itself
  Dean Herbert · 2020-11-18 19:03:34 +09:00
  94886a09b2
• Remove redundant this. qualifier
  Bartłomiej Dach · 2020-11-17 20:11:13 +01:00
  875d7dec79
• Move result type to ctor
  Dean Herbert · 2020-11-17 15:43:54 +09:00
  8247e6ce91
• Add xmldoc coverage of Apply()
  Dean Herbert · 2020-11-17 15:03:26 +09:00
  e4f1e52422
• Move all extended animation logic out of DrawableJudgement
  Dean Herbert · 2020-11-17 14:59:34 +09:00
  f465dd5a5e
• Make Apply non-virtual
  Dean Herbert · 2020-11-17 14:05:13 +09:00
  9dfa4249e0