38601 Commits

Author	SHA1	Message	Date
Dean Herbert	eb7586b517	Ensure collection edit textbox commits on focus loss ... As discussed in https://github.com/ppy/osu/discussions/23739	2023-06-04 12:51:03 +09:00
Bartłomiej Dach	474f7c2bc0	Fix code quality inspection	2023-06-03 16:50:58 +02:00
Bartłomiej Dach	a9d4556647	Merge branch 'master' into update-multiplayer-room-diff-range	2023-06-03 16:50:09 +02:00
Bartłomiej Dach	0b841eda71	Merge pull request #23719 from peppy/disable-tablet-support-on-error ... Automatically disable tablet support on error	2023-06-03 12:25:06 +02:00
Dean Herbert	8063d50369	Merge pull request #23730 from smoogipoo/reduce-legacy-diffcalc-mod-init ... Fix legacy mod difficulty calculation creating all mods unnecessarily	2023-06-02 22:22:19 +09:00
Dan Balasescu	bfe80fe143	Fix legacy diffcalc creating all mods unnecessarily	2023-06-02 17:37:43 +09:00
Dean Herbert	c33ddedca0	Disable all tablet handlers to guard against a grim future	2023-06-02 08:48:47 +09:00
Bartłomiej Dach	f8289927d2	Merge pull request #23720 from peppy/fix-mouse-disappear-screenshot-fail ... Fix mouse cursor potentially disappearing for good if screenshot capture fails	2023-06-01 23:09:23 +02:00
Bartłomiej Dach	8433813677	Merge branch 'master' into editor-timeline-fix	2023-06-01 21:18:08 +02:00
Bartłomiej Dach	c2d89a32a9	Adjust inline comment	2023-06-01 21:18:00 +02:00
Andrei Zavatski	03eb7c7830	Fix nullability	2023-06-01 21:21:01 +03:00
Andrei Zavatski	949fe32740	Use combined area of children as a mask instead	2023-06-01 15:32:17 +03:00
Dean Herbert	00bf79d51f	Merge pull request #23691 from smoogipoo/mania-scroll-speed ... Replace mania scroll "time" with scroll "speed"	2023-06-01 17:23:27 +09:00
Dean Herbert	289f0e9862	Use FireAndForget to avoid unobserved exception	2023-06-01 15:50:37 +09:00
Dean Herbert	0a7d5a51d4	Fix mouse cursor potentially disappearing for good if screenshot capture fails	2023-06-01 15:50:13 +09:00
Dean Herbert	9f8a13480b	Automatically disable tablet support on error ... Closes #23710.	2023-06-01 15:16:48 +09:00
Dean Herbert	55a3847036	Merge pull request #23708 from peppy/labelled-slider-visibility ... Adjust background colour used in `LabelledDrawable`s to allow visibility of some elements	2023-06-01 13:08:17 +09:00
Bartłomiej Dach	d78df0b084	Merge pull request #23695 from peppy/realm-startup-error-handling ... Adjust realm startup for added reliability	2023-05-31 22:46:58 +02:00
Dean Herbert	7bc3b2072c	Update framework	2023-06-01 00:44:13 +09:00
Dean Herbert	20439e80f6	Adjust background colour used in LabelledDrawables to allow visibility of sliders	2023-05-31 23:24:21 +09:00
Dean Herbert	812def124f	Merge pull request #23661 from peppy/fix-multiplayer-present-crash ... Fix `OnResume` / `OnSuspending` potentially getting called before `OnEntering` on a sub screen	2023-05-31 19:43:30 +09:00
Dean Herbert	18eb15bfa5	Gracefully handle failures in cleaning up pending file deletions	2023-05-31 19:39:43 +09:00
Bartłomiej Dach	2e81cae201	Move comment to more correct place	2023-05-30 23:18:34 +02:00
Bartłomiej Dach	62d1774407	Apply same comment & reworded condition to suspend too	2023-05-30 21:54:56 +02:00
Andrei Zavatski	d119447a10	Fix editor timeline hitobjects popping in	2023-05-30 16:41:42 +03:00
Dean Herbert	741ee84ed6	Add comment and use full conditional similar to extension method ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2023-05-30 18:38:28 +09:00
Dean Herbert	14a376c041	Merge branch 'master' into scorev2	2023-05-30 14:34:43 +09:00
Dean Herbert	4e0f40bee5	Split out multiplier retrieval into a function and use a default multiplier for all rulesets	2023-05-30 14:20:26 +09:00
Dean Herbert	fd919879c3	Merge branch 'master' into acc-challenge	2023-05-30 13:24:34 +09:00
Dean Herbert	a0be526266	Adjust realm backup procedure to hard fail if running out of attempts ... Previously, if the backup procedure failed, startup would continue and the user's realm database may be deleted. I think in such a fail case I'd rather the game didn't startup so the user gets in touch (or reads the log files themselves) rather than potentially losing data.	2023-05-30 13:04:34 +09:00
Dean Herbert	79694897be	Ensure a potential exception from cleanupPendingDeletions doesn't mark realm corrupt ... The whole restructure here is to move the nested call out of the `try-catch`. I noticed this while looking at a corrupt database issue a user reported (https://github.com/ppy/osu/discussions/23694). It's not the first time we've seen a corrupt database error where the "corrupt" version works just fine on a second attempt. Maybe this isn't the issue and it's just a transitive file access violation but it definitely feels like this should be fixed regardless.	2023-05-30 13:00:17 +09:00
Dean Herbert	61d9b50993	Merge pull request #23640 from 17steen/make_pause_menu_translatable ... Make GameplayMenuOverlay translatable	2023-05-30 09:36:19 +09:00
Bartłomiej Dach	5604dfb758	Merge branch 'master' into acc-challenge	2023-05-29 22:33:57 +02:00
Bartłomiej Dach	314a0f80f3	Reword setting name & description	2023-05-29 22:12:37 +02:00
Bartłomiej Dach	36f60def6d	Merge pull request #23679 from cdwcgt/percentage-format-slider ... Format percentage based on significant decimal digits	2023-05-29 21:18:23 +02:00
Dan Balasescu	1c199b83e3	Replace mania scroll "time" with scroll "speed"	2023-05-29 21:22:23 +09:00
Dean Herbert	b3ca409339	Rename a few remaining CountAccuracyJudgement variable	2023-05-29 20:08:22 +09:00
Dean Herbert	1558723420	Merge branch 'master' into scorev2	2023-05-29 20:06:32 +09:00
Dean Herbert	df662afbd5	Pass ScoreProcessorStatistics to FrameHeader, rather than the full processor	2023-05-29 20:00:42 +09:00
Dean Herbert	1a6d9e9ff0	Apply NRT to GameplayLeaderboardScore and change GetDisplayedScore handling ... I don't feel too confident with the default scoring function being assigned in the constructor to a publicly settable delegate. This just feels a bit more elegant, and handles the (likely-never-used) case where we need to restore the default function. An alternative would be to provide the function as a `ctor` argument, but I believe that wasn't done here to allow using the `ILeaderboardScore` interface.	2023-05-29 20:00:29 +09:00
Dean Herbert	fcd7a1d51a	Move GetDisplayScore xmldoc to interface and remove getter	2023-05-29 19:41:53 +09:00
Dean Herbert	9a886125ad	Ensure GameplayScoreCounter's display score is updated on ScoringMode change ... This isn't strictly required, but only because of a kind of hacky behaviour where `HUDOverlay` will recreate all components on a scoring mode change currently (see 8f6df5ea0f/osu.Game/Screens/Play/HUDOverlay.cs (L410-L418)). Best we do this just in case that happens to go away in the future.	2023-05-29 19:00:02 +09:00
Dean Herbert	22be045de3	Apply NRT to GameplayScoreCounter	2023-05-29 18:48:17 +09:00
Dean Herbert	a789d1e49c	Add xmldoc and change naming around ScoreProcessorStatistics a bit	2023-05-29 18:38:16 +09:00
Dean Herbert	b0501c4e5c	Actually use paused header	2023-05-29 10:24:59 +09:00
Dean Herbert	f5b258a044	Merge branch 'master' into make_pause_menu_translatable	2023-05-29 01:16:52 +09:00
cdwcgt	333e785f8b	Revert "Provides higher precision settings" ... This reverts commit ec61840e7d. 😐	2023-05-28 09:50:11 +09:00
Bartłomiej Dach	ba5f76fcc8	Merge pull request #23667 from peppy/fix-taiko-editor-placement-before-first-control-poiunt ... Fix placing objects before the first control point in the osu!taiko editor failing	2023-05-27 17:58:28 +02:00
cdwcgt	a05312c9a2	simplify format method ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2023-05-27 23:44:50 +09:00
cdwcgt	89c8ef3c9b	Format percentage based on significant decimal digits	2023-05-27 23:35:59 +09:00