71310 Commits

This Branch

This Branch

All Branches

• Add test coverage of various selection examples

  Where possible I've tried to match the test and method names of
  `TestSceneBeatmapCarousel` for easy coverage comparison.

  Dean Herbert · 2025-01-23 18:51:25 +09:00
  eaea053c7d
• Fix sort direction being flipped
  Dean Herbert · 2025-01-23 18:51:24 +09:00
  ffca90779f
• Tidy up tests in preparation for adding more
  Dean Herbert · 2025-01-23 18:51:24 +09:00
  9ab045495d
• Add selection and activation flow
  Dean Herbert · 2025-01-23 18:51:24 +09:00
  2f94456a06
• Add set-difficulty tracking in BeatmapCarouselFilterGrouping

  Rather than tracking inside individual items, let's just maintain a
  single dictionary which is refreshed every time we regenerate filters.

  Dean Herbert · 2025-01-23 18:48:44 +09:00
  ecef5e5d71
• Make CarouselItem sealed and remove BeatmapCarouselItem concept

  Less abstraction is better. As far as I can tell, we don't need a custom
  model for this. If there's any tracking to be done, it should be done
  within `BeatmapCarousel`'s implementation (or a filter).

  Dean Herbert · 2025-01-23 18:48:44 +09:00
  980f6cf18e
• Move Selected status to drawables

  Basically, I don't want bindables in `CarouselItem`. It means there
  needs to be a bind-unbind process on pooling. By moving these to the
  drawable and just updating every frame, we can simplify things a lot.

  Dean Herbert · 2025-01-23 18:48:43 +09:00
  c67c0a7fc0
• Merge pull request #31632 from peppy/beatmap-carousel-v2-cleanups

  Initial carousel additions in preparation for selection logic

  Bartłomiej Dach · 2025-01-23 10:43:12 +01:00
  beaadfa1fa
• displayedCarouselItems -> carouselItems
  Dean Herbert · 2025-01-23 15:58:35 +09:00
  ded1d9f019
• Only show loading when doing a user triggered filter
  Dean Herbert · 2025-01-23 15:51:54 +09:00
  d526835627
• Reorder carousel methods into logical regions
  Dean Herbert · 2025-01-23 15:50:57 +09:00
  6ac2dbc818
• Show selection defaults in test scene (and make prettier)
  Dean Herbert · 2025-01-23 15:50:40 +09:00
  8657576210
• Merge pull request #31509 from bdach/local-metadata-cache-corruption

  Refetch local metadata cache if corruption is detected

  Dean Herbert · 2025-01-23 02:43:14 +09:00
  bf23c67603
• Merge pull request #31616 from bdach/fix-new-combo-button-crash

  Fix crash from new combo colour selector when there are no combo colours present

  Dan Balasescu · 2025-01-22 20:48:02 +09:00
  11e84f325c
• Fix crash from new combo colour selector when there are no combo colours present

  Closes https://github.com/ppy/osu/issues/31615.

  Bartłomiej Dach · 2025-01-22 11:39:32 +01:00
  3da220b8f6
• Merge pull request #31588 from minetoblend/feature/paste-snapped

  Snap to beat divisor when pasting hitobjects in editor

  Dean Herbert · 2025-01-22 18:38:12 +09:00
  218720bca5
• Apply NRT to new class
  Dean Herbert · 2025-01-22 18:36:13 +09:00
  c94b8bf051
• Adjust code again to avoid weird throw mishandling
  Dean Herbert · 2025-01-22 18:24:01 +09:00
  6ceb348cf6
• Merge pull request #31603 from peppy/input-amendments

  Tidy up various input handling anomalies

  Dan Balasescu · 2025-01-22 18:05:06 +09:00
  63e6b0e050
• Merge pull request #31604 from peppy/fix-song-select-right-click-handling

  Fix song select right click handling

  Bartłomiej Dach · 2025-01-22 10:00:03 +01:00
  2623d8dcac
• Merge pull request #31613 from peppy/friend-notifications-bug-less

  Make friend notifications less prominent

  Dan Balasescu · 2025-01-22 17:34:23 +09:00
  631ae90130
• Remove outdated ef related catch-when usage
  Dean Herbert · 2025-01-22 17:04:30 +09:00
  26ef23c9a9
• Adjust code style slightly
  Dean Herbert · 2025-01-22 17:03:01 +09:00
  910c0022e3
• Mark friend notifications as non-important
  Dean Herbert · 2025-01-22 16:41:27 +09:00
  9e023340b0
• Switch IsImportant to init property isntead of virtual
  Dean Herbert · 2025-01-22 16:41:26 +09:00
  4cf4b8c73d
• Add transient flag for notifications which shouldn't linger in history
  Dean Herbert · 2025-01-22 16:41:26 +09:00
  fde2b22bbc
• Add test scene for clipboard snapping
  Marvin Schürz · 2025-01-21 11:02:41 +01:00
  cc7c549468
• Merge pull request #31527 from bdach/spectator-list-ready

  Show spectating users during gameplay

  Dan Balasescu · 2025-01-21 18:54:11 +09:00
  8f8246278a
• Move bindings to LoadComplete()
  Bartłomiej Dach · 2025-01-21 10:02:16 +01:00
  0265a29000
• Merge pull request #31026 from frenzibyte/ios-system-file-import

  Add special handling for file import button on iOS

  Dean Herbert · 2025-01-21 17:33:03 +09:00
  704c2ea0cc
• Add back explicit right click handling of carousel absolute scrolling
  Dean Herbert · 2025-01-21 17:24:42 +09:00
  6c27e87714
• Remove right click default for absolute scroll
  Dean Herbert · 2025-01-21 17:24:41 +09:00
  66be9f2d1b
• Add failing test coverage of random rewind button not working
  Dean Herbert · 2025-01-21 17:24:41 +09:00
  c8cc36e9af
• Remove unnecessary input blocking

  This was already done by `OverlayContainer`.

  Dean Herbert · 2025-01-21 16:40:36 +09:00
  b6e7b43b11
• Fix main menu osu logo being activated by function keys and escape
  Dean Herbert · 2025-01-21 16:40:21 +09:00
  aeca91cde2
• Fix ComposeBlueprintContainer handling nudge keys when it can't nudge
  Dean Herbert · 2025-01-21 16:40:16 +09:00
  9a12f48dcc
• Don't block Popover escape handling (just let it work in addition to GlobalAction.Back)
  Dean Herbert · 2025-01-21 16:39:45 +09:00
  3a37817ab2
• Simplify code immensely

  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Salman Alshamrani · 2025-01-21 02:20:51 -05:00
  3f51626f07
• Merge pull request #31586 from minetoblend/feature/metronome-decimals

  Display up to 2 decimal places for bpm in timing screen metronome

  Dean Herbert · 2025-01-21 16:13:10 +09:00
  0a97fb6359
• Adjust visuals slightly
  Dean Herbert · 2025-01-21 15:14:39 +09:00
  a7c9f84a93
• Fix silly mistake
  Salman Alshamrani · 2025-01-21 01:14:18 -05:00
  f133042936
• Merge pull request #31602 from peppy/fix-taiko-beat-snap-grid

  Fix beat snap grid being lines not being corectly centered to time

  Dan Balasescu · 2025-01-21 15:13:29 +09:00
  afec5baea1
• Merge branch 'master' into ios-system-file-import
  Dean Herbert · 2025-01-21 14:22:56 +09:00
  748e631976
• Fix beat snap grid being lines not being corectly centered to time

  This was pointed out as an issue in the osu!taiko editor, but actually
  affects all rulesets. Has now been fixed everywhere.
  
  ---
  
  Closes https://github.com/ppy/osu/issues/31548.
  
  osu!mania could arguable be consdiered "more correct" with the old
  display, but I don't think it's a huge deal either way (subjective at
  best).

  Dean Herbert · 2025-01-21 14:20:56 +09:00
  46ff9d1aad
• Merge pull request #31593 from Rudicito/fix-player-settings-overlay-hiding-when-slider-drag

  Fix player settings in replay hiding when dragging a slider

  Dan Balasescu · 2025-01-21 13:49:39 +09:00
  2c5b438589
• Fix settings in replay hiding when dragging a slider
  Rudi Herouard · 2025-01-20 13:43:45 +01:00
  89586d5ab2
• Merge pull request #31543 from bdach/daily-challenge-completion-marker

  Add completion marker to daily challenge profile counter

  Dean Herbert · 2025-01-20 19:29:35 +09:00
  c20b836d9c
• Merge pull request #31547 from bdach/editor/precise-move

  Add precise movement tool to osu! editor

  Dean Herbert · 2025-01-20 19:29:22 +09:00
  cf032e5e7f
• Always select text when an editor slider-textbox is focused
  Dean Herbert · 2025-01-20 16:17:39 +09:00
  dcdb8d13a9
• Merge pull request #31553 from ILW8/add-tourney-acronym-warning

  add warning text on team acronym conflict

  Dean Herbert · 2025-01-20 15:55:37 +09:00
  da6954762a