40583 Commits

This Branch

This Branch

All Branches

• Merge pull request #13396 from ekrctb/fix-circle-piece

  Fix hit circle animation is removed when a replay is rewound

  Dean Herbert · 2021-06-09 11:39:38 +09:00
  e914fbf449
• Fix hit circle animation when a replay is rewound
  ekrctb · 2021-06-09 10:53:52 +09:00
  4707918c6a
• Merge pull request #13380 from smoogipoo/fix-multi-spec-dt-doubling-2

  Fix DT being doubled in multiplayer spectator

  Dean Herbert · 2021-06-08 23:31:56 +09:00
  2021.608.0 04cc788627
• Fix DT being doubled in multiplayer spectator
  smoogipoo · 2021-06-08 22:51:42 +09:00
  c3ea1b26e1
• Merge pull request #13337 from Pasi4K5/fix-sliders-out-of-screen

  Fix sliders sometimes being outside of the playfield with osu! random mod enabled

  Dean Herbert · 2021-06-08 21:18:21 +09:00
  475788041a
• Merge pull request #13375 from smoogipoo/fix-multi-nullref

  Fix possible nullref when exiting song select too fast

  Dean Herbert · 2021-06-08 20:47:40 +09:00
  25af4dfa8a
• Merge pull request #13377 from peppy/fix-lazer-replays-getting-classic

  Move legacy `ScoreInfo` to be completely based on presence of classic mod

  Dan Balasescu · 2021-06-08 19:15:13 +09:00
  5a8cde7e6f
• Merge pull request #12970 from peppy/fix-skin-sample-lookup

  Fix default skin sample fallback logic existing within `PoolableSkinnableSample`

  Dan Balasescu · 2021-06-08 19:10:04 +09:00
  d9ac9f641a
• Add parens to declare operator precedence
  smoogipoo · 2021-06-08 18:39:52 +09:00
  0b9916b266
• Extract first version out to constant
  Dean Herbert · 2021-06-08 18:38:47 +09:00
  4ee7721c51
• Fix nullref
  Dan Balasescu · 2021-06-08 18:23:03 +09:00
  d31e3e8f1c
• Remove forgotten classic mod addition
  Dean Herbert · 2021-06-08 18:09:57 +09:00
  b287366c8b
• Move legacy ScoreInfo to be completely based on presence of classic mod
  Dean Herbert · 2021-06-08 18:00:09 +09:00
  061e3d7f26
• Update score encoder version to be higher than any existing stable version
  Dean Herbert · 2021-06-08 17:59:43 +09:00
  4d9fffc01b
• Fix a similar case with online play sub-screens
  smoogipoo · 2021-06-08 17:54:54 +09:00
  ab9290772b
• Only call OnBackButton() if the screen has finished loading
  smoogipoo · 2021-06-08 17:38:12 +09:00
  860f1aebb3
• Merge branch 'master' into fix-skin-sample-lookup
  Dean Herbert · 2021-06-08 17:37:36 +09:00
  6017ef3825
• Merge pull request #13264 from peppy/legacy-skin-default-fallback

  Allow fallback to legacy defaults from legacy skins

  Dan Balasescu · 2021-06-08 17:30:27 +09:00
  e5e3509c87
• Merge pull request #13374 from peppy/update-framework

  Update framework

  Dan Balasescu · 2021-06-08 17:09:20 +09:00
  c0fdbfba04
• Fix typo
  smoogipoo · 2021-06-08 17:09:03 +09:00
  490ab9e96a
• Fix possible nullref when exiting song select too fast
  smoogipoo · 2021-06-08 17:03:50 +09:00
  7fa0ac6ed7
• Merge branch 'master' into legacy-skin-default-fallback
  Dan Balasescu · 2021-06-08 16:54:26 +09:00
  791855dfa0
• Merge pull request #13371 from peppy/fix-poolable-sample-disposal-skin-change

  Clean up previous sample immediately on skin source change to avoid `Play` after disposal

  Dan Balasescu · 2021-06-08 16:52:59 +09:00
  e3cb6f45f5
• Merge pull request #13373 from peppy/catch-no-visibility-increase

  Don't apply visibility increase to first object in osu!catch

  Dan Balasescu · 2021-06-08 16:39:21 +09:00
  751a5e7cf3
• Update framework
  Dean Herbert · 2021-06-08 16:24:00 +09:00
  89895f6ce4
• Add null check
  Dan Balasescu · 2021-06-08 16:15:17 +09:00
  67135ce3db
• Don't apply visibility increase to first object in osu!catch

  The goal of the visibility increase is to help in cases where timing is
  an issue (by showing the approach circle etc.). This doesn't need to
  apply to catch.
  
  @smoogipoo interested as to whether you agree with this one. Visually it
  looks better to me but it does change the behaviour for only osu!catch,
  so I'm not 100% confident on it.
  
  Closes #13367.

  Dean Herbert · 2021-06-08 16:02:26 +09:00
  e388a896e8
• Merge branch 'legacy-skin-default-fallback' into fix-skin-sample-lookup
  Dean Herbert · 2021-06-08 15:19:52 +09:00
  e0f568aa8f
• Clean up previous sample immediately on skin source change to avoid Play after disposal

  This seems to be the simplest way to avoid calls to `Play` after the
  underlying sample may have been disposed. As per the issue thread, a
  local workaround is acceptable here.
  
  Closes #13223.

  Dean Herbert · 2021-06-08 15:05:18 +09:00
  f3f634e969
• Merge pull request #13370 from smoogipoo/beatmap-collections-safeguard

  Attempt to safeguard against collections database corruptions

  Dean Herbert · 2021-06-08 15:01:26 +09:00
  be53b521fc
• Attempt to safeguard against collections database corruptions
  smoogipoo · 2021-06-08 14:25:39 +09:00
  7341e474f1
• Add TODO about beatmap skin fallback support
  Dean Herbert · 2021-06-08 12:12:14 +09:00
  27e3de3ea3
• Fix slider ball layer sources
  Dean Herbert · 2021-06-08 12:10:14 +09:00
  88b87b98a8
• Remove now unused method
  Dean Herbert · 2021-06-08 12:06:42 +09:00
  06840d78cc
• Refactor animation lookup to properly handle skins providing non-animated resources
  Dean Herbert · 2021-06-08 01:17:20 +09:00
  2c1f22d7ae
• Fix FindProvider not correctly checking legacy default in SkinManager
  Dean Herbert · 2021-06-08 00:42:50 +09:00
  e7e9197f03
• Fix TaikoMascot texture animation lookups
  Dean Herbert · 2021-06-08 00:42:34 +09:00
  273d66a0e0
• Add back incorrectly reverted animation handling logic

  This reverts commit b904fa6615.

  Dean Herbert · 2021-06-08 00:17:01 +09:00
  6d56e02ddb
• Fix FindProvider incorrectly returning LegacySkinTransformer itself
  Dean Herbert · 2021-06-07 23:23:44 +09:00
  c0305343bc
• Ensure all lookups in LegacyHealthDisplay use the found provider

  Not actually needed to fix the remaining issue but does feel better

  Dean Herbert · 2021-06-07 23:23:12 +09:00
  08701b5eab
• Merge pull request #13365 from bdach/catch-colour-error-meter

  Fix colour hit error meter not working with empty hit windows

  Dan Balasescu · 2021-06-07 21:13:30 +09:00
  6ebac0b462
• Adjust test scene to avoid cross-test interference

  * Move steps from ctor to a separate basic test.
  * Wait for barrage to complete in basic test, as not doing so polluted
    state of other tests.
  * Reset score processor after every test.

  Bartłomiej Dach · 2021-06-07 13:16:07 +02:00
  1b4771655a
• Move empty window check to bar error meter

  It's not valid in the base `HitErrorMeter`, as the colour meter only
  displays colour for a given judgement, so it is still valid to add new
  items to it even if the hit window is 0, as misses are still possible.

  Bartłomiej Dach · 2021-06-07 13:16:07 +02:00
  0531c2dcd9
• Add failing assertions to hit error meter test
  Bartłomiej Dach · 2021-06-07 13:16:07 +02:00
  37d062c7cd
• Remove bogus CatchHitWindows

  `CatchHitWindows` were a vestige from the past, and were not actually
  used anywhere except for the hit error meter test, giving off an
  appearance that the hit error meter was working properly.
  `CatchHitObject` actually specifies empty hit windows.

  Bartłomiej Dach · 2021-06-07 13:16:07 +02:00
  122a624b7f
• Merge pull request #13364 from Susko3/android-add-mime-type-x-osu-archive

  Add `application/x-osu-archive` mime type to Android `IntentFilter`s

  Dan Balasescu · 2021-06-07 19:30:15 +09:00
  b32191f924
• Merge pull request #13360 from peppy/fix-slider-repeat-arrow-rotation-editor
  Bartłomiej Dach · 2021-06-07 12:22:41 +02:00
  8d7a250c6e
• Merge branch 'master' into fix-slider-repeat-arrow-rotation-editor
  Dan Balasescu · 2021-06-07 18:46:25 +09:00
  3225bc2c71
• Merge pull request #13362 from peppy/fix-background-screen-reload

  Stop `BackgroundScreenDefault` from reloading beatmap background when already correct

  Dan Balasescu · 2021-06-07 18:44:47 +09:00
  ee256083e3
• add application/x-osu-archive mime type to Android IntentFilters
  Susko3 · 2021-06-07 11:24:48 +02:00
  a0fbf29b98