8937 Commits

• Merge branch 'master' into editor-test-play
  Bartłomiej Dach · 2024-07-03 13:54:47 +02:00
  e73faaefd2
• Merge branch 'master' into grids-2
  Bartłomiej Dach · 2024-07-03 10:57:05 +02:00
  17ce9cd162
• Merge pull request #28707 from bdach/remove-breaks

  Add option to remove breaks via timeline context menu

  Dean Herbert · 2024-07-03 16:29:25 +09:00
  824a00b018
• Remove unused using directive
  Salman Ahmed · 2024-07-03 07:11:35 +03:00
  abfdf90b54
• Add failing test coverage for changing banks/samples not working on node samples
  Bartłomiej Dach · 2024-07-02 16:21:56 +02:00
  6453522b34
• Add test coverage
  Bartłomiej Dach · 2024-07-02 15:02:09 +02:00
  3f08605277
• Add test coverage
  Bartłomiej Dach · 2024-07-02 14:34:36 +02:00
  3d61a217ec
• Expand test coverage

  - Covers fail case that wasn't covered before
  - Removes arbitrary wait step that was inevitably going to cause
    intermittent test failures

  Bartłomiej Dach · 2024-06-28 09:30:28 +02:00
  ace6427d40
• Merge branch 'master' into fix/editor-test-exit
  Bartłomiej Dach · 2024-06-28 09:17:40 +02:00
  b36e0f0875
• Merge pull request #28638 from OliBomby/beat-divisor

  Fix editor not loading arbitrary beat divisors

  Bartłomiej Dach · 2024-06-27 13:31:44 +02:00
  e35744118c
• Add test coverage for correct beat divisor save
  Bartłomiej Dach · 2024-06-27 12:38:29 +02:00
  772a68cb3e
• Add failing test case

  Includes a refactor of `ThemeComparisonTestScene` to allow accessing a manual input manager.

  Salman Ahmed · 2024-06-27 06:41:44 +03:00
  e4335a543e
• Remove unused local variable
  Dean Herbert · 2024-06-26 16:22:25 +09:00
  ac235cb506
• Implement carousel container for daily challenge screen
  Bartłomiej Dach · 2024-06-26 08:49:00 +02:00
  006184ed2f
• Remove unused using statements
  Dean Herbert · 2024-06-26 14:50:53 +09:00
  0c8279c5df
• Fix intermittent failure in online menu banner tests
  Salman Ahmed · 2024-06-26 08:39:55 +03:00
  fa46d8e6c9
• Merge pull request #28589 from bdach/scale-handling-crash

  Fix crashes when opening scale/rotation popovers during selection box operations

  Dean Herbert · 2024-06-26 00:11:03 +09:00
  aadb104851
• Add missing base calls for safety
  Dean Herbert · 2024-06-25 23:41:43 +09:00
  d722be16e3
• Implement score breakdown display for daily challenge screen
  Bartłomiej Dach · 2024-06-24 10:09:10 +02:00
  66b093b17e
• Merge branch 'master' into timeline-drag-selection-crash
  Dean Herbert · 2024-06-20 15:16:10 +09:00
  14104e57d4
• Merge branch 'master' into break-autogeneration
  Dean Herbert · 2024-06-19 21:49:17 +09:00
  00443403b6
• Fix test failures due to automatic break generation kicking in
  Bartłomiej Dach · 2024-06-19 11:32:08 +02:00
  8757e08c2c
• Adjust calls to GetContainingInputManager()
  Bartłomiej Dach · 2024-06-18 07:41:19 +02:00
  659505f711
• Merge pull request #23443 from OliBomby/edit-nodesample

  Make NodeSamples editable

  Dean Herbert · 2024-06-18 11:12:02 +09:00
  316125d47a
• Merge pull request #28468 from bdach/daily-challenge/event-feed

  Implement event feed view for daily challenge screen

  Dean Herbert · 2024-06-17 20:16:48 +09:00
  a6f09bc626
• Merge pull request #28480 from bdach/storyboard-pass-fail-show

  Implement toggling visibility of pass and fail storyboard layers

  Dean Herbert · 2024-06-16 11:08:00 +09:00
  15fbad0097
• Apply NRT to test scene
  Dean Herbert · 2024-06-15 17:26:57 +08:00
  6bd633f8ce
• Implement toggling visibility of pass and fail storyboard layers

  Closes https://github.com/ppy/osu/issues/6842.
  
  This is a rather barebones implementation, just to get this in place
  somehow at least. The logic is simple - 50% health or above shows pass
  layer, anything below shows fail layer.
  
  This does not match stable logic all across the board because I have
  no idea how to package that. Stable defines "passing" in like fifty
  ways:
  
  - in mania it's >80% HP
    (https://github.com/peppy/osu-stable-reference/blob/bb57924c1552adbed11ee3d96cdcde47cf96f2b6/osu!/GameModes/Play/Rulesets/Mania/RulesetMania.cs#L333-L336)
  - in taiko it's >80% *accuracy*
    (https://github.com/peppy/osu-stable-reference/blob/bb57924c1552adbed11ee3d96cdcde47cf96f2b6/osu!/GameModes/Play/Rulesets/Taiko/RulesetTaiko.cs#L486-L492)
  - there's also the part where "geki additions" will unconditionally set
    passing state
    (https://github.com/peppy/osu-stable-reference/blob/bb57924c1552adbed11ee3d96cdcde47cf96f2b6/osu!/GameModes/Play/Player.cs#L3561-L3564)
  - and also the part where at the end of the map, the final passing state
    is determined by checking whether the user passed more sections than
    failed
    (https://github.com/peppy/osu-stable-reference/blob/bb57924c1552adbed11ee3d96cdcde47cf96f2b6/osu!/GameModes/Play/Player.cs#L3320)
  
  The biggest issues of these are probably the first two, and they can
  *probably* be fixed, but would require a new member on `Ruleset` and I'm
  not sure how to make one look, so I'm not doing that at this time
  pending collection of ideas on how to do that.

  Bartłomiej Dach · 2024-06-14 13:59:02 +02:00
  67ca7e4135
• Add failing test
  Shiumano · 2024-06-14 20:07:27 +09:00
  bfca64a98e
• Add failing test case demonstrating crash
  Bartłomiej Dach · 2024-06-14 09:24:53 +02:00
  8b6385f7d0
• Implement event feed view for daily challenge screen
  Bartłomiej Dach · 2024-06-13 09:05:45 +02:00
  8c4aa84037
• Implement time remaining display for daily challenge screen
  Bartłomiej Dach · 2024-06-12 11:43:24 +02:00
  2be6b29f21
• Add test scene for daily challenge screen
  Bartłomiej Dach · 2024-06-10 13:12:20 +02:00
  2321e408cb
• Extract user mod select button for reuse
  Bartłomiej Dach · 2024-06-10 12:45:27 +02:00
  dd6e9308b3
• Merge branch 'master' into footer-v2-become-global
  Salman Ahmed · 2024-06-08 14:13:05 +03:00
  6201220994
• Merge pull request #22237 from mk56-spn/LeaderBoardScore_clean

  New leaderboard score card design implementation

  Dean Herbert · 2024-06-08 20:06:17 +09:00
  daf85c320a
• Merge pull request #28184 from frenzibyte/footer-v2-transitions

  Add basic animation to new footer and buttons

  Dean Herbert · 2024-06-08 19:43:23 +09:00
  7fc6ad5340
• Use OsuGame.SHEAR
  Salman Ahmed · 2024-06-07 22:45:22 +03:00
  5f8f6caedd
• Merge branch 'master' into LeaderBoardScore_clean
  Salman Ahmed · 2024-06-07 22:42:49 +03:00
  6f729be573
• Fix test not compiling

  A little ugly but maybe it'll do...

  Bartłomiej Dach · 2024-06-07 09:54:00 +02:00
  199d31c0f4
• Merge branch 'master' into add-rank-display
  Bartłomiej Dach · 2024-06-07 09:33:03 +02:00
  4cd1ccc4d4
• Fix obsoletion warning
  Bartłomiej Dach · 2024-06-06 13:50:31 +02:00
  dd9c77d248
• Merge branch 'master' into edit-nodesample
  Bartłomiej Dach · 2024-06-06 13:42:25 +02:00
  86b13074a0
• Merge remote-tracking branch 'upstream/master' into grids-2
  OliBomby · 2024-06-05 17:18:48 +02:00
  d8994786f6
• Merge branch 'master' into grids-1
  Bartłomiej Dach · 2024-06-03 12:33:51 +02:00
  4fcb902341
• Add test coverage of menu banner link opening
  Dean Herbert · 2024-05-31 03:15:26 +09:00
  53b7c29488
• Merge branch 'master' into fix/editor-test-exit
  Dean Herbert · 2024-05-29 21:08:36 +09:00
  16e2fa2c6a
• Merge branch 'master' into scale-tool
  Bartłomiej Dach · 2024-05-29 10:15:48 +02:00
  7b7e439d03
• Use better name if we're renaming
  Bartłomiej Dach · 2024-05-29 09:40:29 +02:00
  4c881b5633
• rename CanScaleSelectionOrigin/PlayfieldOrigin to make clear its not the origin being scaled
  OliBomby · 2024-05-28 16:14:16 +02:00
  a89ba33b47