53378 Commits

This Branch

This Branch

All Branches

• Update save score button to check availability after import

  Previously was relying on whether `SaveReplay` returns null, but since
  I've changed it to use the standard "prepare score for import" path, the
  button has to check for local availability after import since that path
  doesn't return null on fail.

  Salman Ahmed · 2022-07-15 23:39:52 +03:00
  e6236ba088
• Fix failed scores not prepared before import
  Salman Ahmed · 2022-07-15 22:57:12 +03:00
  6285442b7d
• Move default state steps to SetUp rather than duplicating per test case
  Salman Ahmed · 2022-07-15 22:10:21 +03:00
  68afb65aff
• Merge branch 'master' into Save-Score-Failed
  Salman Ahmed · 2022-07-15 22:10:19 +03:00
  8f7b3cf11a
• Merge pull request #19129 from peppy/placeholder-fixes

  Fix clicking search link from song select sometimes not switching search mode to "relevance"

  Salman Ahmed · 2022-07-15 20:54:42 +03:00
  4ee9bb3634
• Merge branch 'master' into placeholder-fixes
  Salman Ahmed · 2022-07-15 20:22:25 +03:00
  838e9ec12e
• Merge pull request #19126 from peppy/lazer-leaderboards

  Show leaderboard scores from new data source

  Dean Herbert · 2022-07-16 01:53:16 +09:00
  cbbc8fdfb1
• Merge pull request #19131 from Susko3/android-joystick-settings

  Add joystick settings on Android

  Dean Herbert · 2022-07-15 23:49:25 +09:00
  288fdbd06f
• Allow failed scores to fail in replay playback
  Dean Herbert · 2022-07-15 20:45:48 +09:00
  2beed6d7b7
• Check whether score is already imported and show correct state for save button
  Dean Herbert · 2022-07-15 20:45:37 +09:00
  d325c534ab
• Merge pull request #19132 from peppy/fix-potential-crash

  Fix potential crash in editor from transform time going below zero

  Dan Balasescu · 2022-07-15 20:31:48 +09:00
  4514d5e97b
• Add test coverage of saving a failed score
  Dean Herbert · 2022-07-15 20:14:58 +09:00
  21433d4ecb
• Fix potential crash in editor from transform time going below zero
  Dean Herbert · 2022-07-15 19:29:37 +09:00
  775c6c8374
• Merge pull request #19124 from frenzibyte/song-select-metadata-search

  Change clicking source/tags on song select to filter instead of searching online

  Dean Herbert · 2022-07-15 19:16:31 +09:00
  cf38b15332
• Merge pull request #19130 from peppy/update-framework

  Update framework

  Dean Herbert · 2022-07-15 19:16:16 +09:00
  603f2c3814
• Make delegate firing more safe to being set later than BDL
  Dean Herbert · 2022-07-15 19:06:44 +09:00
  0200ef1d48
• Simplify bindable logic greatly
  Dean Herbert · 2022-07-15 19:02:12 +09:00
  0e788ac714
• Tidy up implementation and remove unnecessary enum
  Dean Herbert · 2022-07-15 19:02:04 +09:00
  8a48cb701d
• Include new file in compile
  Susko3 · 2022-07-15 11:57:05 +02:00
  cb1d60cd36
• Merge branch 'ppy:master' into android-joystick-settings
  Susko3 · 2022-07-15 11:45:16 +02:00
  034938b3e0
• Merge branch 'master' into Save-Score-Failed
  Dean Herbert · 2022-07-15 18:02:58 +09:00
  ab6665d88c
• Only expose bindable string rather than full textbox
  Dean Herbert · 2022-07-15 18:01:35 +09:00
  e12e480393
• Merge pull request #19090 from goodtrailer/stable-slider-followcircle-anims

  Imitate stable's slider followcircle fade + scale animations

  Dean Herbert · 2022-07-15 17:58:59 +09:00
  5aca0e342d
• Update framework
  Dean Herbert · 2022-07-15 17:57:14 +09:00
  105ffdbbdd
• Fix beatmap listing not entering correct search mode when arriving before LoadComplete
  Dean Herbert · 2022-07-15 17:53:44 +09:00
  437e01427c
• Show search online prompt even when no beatmaps are available locally
  Dean Herbert · 2022-07-15 17:50:10 +09:00
  ba0a158740
• Fix intermittent test failures due to randomised score statistics
  Dean Herbert · 2022-07-15 17:39:08 +09:00
  4b253f83c3
• Merge branch 'master' into stable-slider-followcircle-anims
  Dean Herbert · 2022-07-15 17:27:48 +09:00
  23a0e25c8c
• Adjust transform logic to match osu-stable (and add TODOs for remaining oversights)
  Dean Herbert · 2022-07-15 17:17:55 +09:00
  7ed4eb5815
• Tidy up nullability and casting
  Dean Herbert · 2022-07-15 16:40:48 +09:00
  0ade8db550
• Standardise HasReplay implementation (and remove from persisting to realm)
  Dean Herbert · 2022-07-15 16:14:21 +09:00
  c8c79d2185
• Add "F" ScoreRank to handle old scores which have this specified

  Not sure on the future of this, but given it is used in the
  save-failed-reply pull request (#18785) I think it's fine to add back
  for now.
  
  Without this, JSON parsing of older scores in server-side storage will
  fail on missing enum type.

  Dean Herbert · 2022-07-15 15:58:54 +09:00
  6122d2a525
• Update score retrieval endpoint to access new storage
  Dean Herbert · 2022-07-15 15:47:25 +09:00
  688fcb256f
• Remove classic mod attribution to SoloScoreInfo conversion path
  Dean Herbert · 2022-07-15 15:47:05 +09:00
  966882013d
• Merge pull request #19082 from peppy/api-solo-score-model

  Add and consume `SoloScoreInfo`

  Dan Balasescu · 2022-07-15 15:20:18 +09:00
  c1dd1cfead
• Merge pull request #19037 from frenzibyte/drawable-playlist-item-collection

  Allow adding playlist items to beatmap collections via context menu

  Dean Herbert · 2022-07-15 15:04:39 +09:00
  36b06f87a4
• Replace download tracker with local querying
  Salman Ahmed · 2022-07-15 08:16:36 +03:00
  7e80a71020
• Use proper variable name
  Salman Ahmed · 2022-07-15 07:44:56 +03:00
  254d22de1c
• Enable NRT on BeatmapDetails
  Salman Ahmed · 2022-07-15 06:52:06 +03:00
  86d019c2b2
• Fix beatmap details source and tags not filtering on song select
  Salman Ahmed · 2022-07-15 06:51:50 +03:00
  97c3eea3aa
• Allow specifying custom search action to metadata sections
  Salman Ahmed · 2022-07-15 06:41:03 +03:00
  eafa11555a
• Merge pull request #19114 from frenzibyte/fix-potential-dialog-test-failure

  Fix dialog overlay potentially pushing dialog while not loaded

  Dean Herbert · 2022-07-15 12:34:19 +09:00
  cd085cbd97
• Fix minor typo
  Salman Ahmed · 2022-07-15 05:56:49 +03:00
  aea786ea0c
• Remove unnecessary test coverage

  RIP hours.

  Salman Ahmed · 2022-07-15 03:20:52 +03:00
  0bafafd63b
• Convert constructor in abstract class to protected
  Alden Wu · 2022-07-14 17:11:01 -07:00
  1581f1a0ff
• Replace comment pointer with actual comment
  Alden Wu · 2022-07-14 17:11:01 -07:00
  4453b0b3e8
• Move shared followcircle code into abstract base class
  Alden Wu · 2022-07-14 17:11:01 -07:00
  66932f1af6
• Merge pull request #19107 from peppy/first-run-language-selection

  Add language selection to first run overlay

  Dan Balasescu · 2022-07-14 22:58:32 +09:00
  3806416541
• Merge pull request #19121 from peppy/fix-realm-multiple-online-id

  Ensure that multiple `BeatmapSetInfo` with same `OnlineID` don't cause import failures

  Dan Balasescu · 2022-07-14 19:01:23 +09:00
  d8ae1151c6
• Ensure that multiple BeatmapSetInfo already in realm don't cause import failures

  Really this shouldn't happen but I managed to make it happen. Until this
  comes up again in a way that matters, let's just fix the LINQ crash from
  `SingleOrDefault`.
  
  I've tested this to work as expected in the broken scenario.

  Dean Herbert · 2022-07-14 18:21:41 +09:00
  ebe0cfefd8