47411 Commits

This Branch

This Branch

All Branches

• Fix test
  Dan Balasescu · 2021-12-21 18:38:31 +09:00
  e2f8c71081
• Disallow expired items from showing delete button

  This isn't possible in practice since expired items are removed from the
  queue list, but this helps out in tests.

  Dan Balasescu · 2021-12-21 18:37:42 +09:00
  a34d24fb20
• Fix delete button being able to show on current item
  Dan Balasescu · 2021-12-21 16:57:58 +09:00
  51b7e920c0
• Merge pull request #16192 from peppy/add-room-lost-logging

  Add logging of `MultiplayerMatchSubScreen` exiting from room loss

  Dan Balasescu · 2021-12-21 16:37:08 +09:00
  32fbaf47c0
• Merge pull request #16012 from bdach/beatmap-card/extra

  Implement "extra" beatmap card size

  Dean Herbert · 2021-12-21 15:40:33 +09:00
  2707b2fbda
• Merge pull request #16189 from peppy/fix-beatmap-listing-overlay-test-failure

  Fix intermittent failures on `TestSceneBeatmapListingOverlay`

  Dan Balasescu · 2021-12-21 15:11:25 +09:00
  a8cd96278d
• Merge pull request #16188 from peppy/multiplayer-button-enabled

  Centralise all multiplayer button clicking test logic

  Dan Balasescu · 2021-12-21 15:10:26 +09:00
  5cea8da80f
• Also add logging to OnlinePlayScreen
  Dean Herbert · 2021-12-21 15:07:06 +09:00
  d08b66a5ff
• Merge pull request #16187 from peppy/fix-threading-colour-error-meter

  Fix potential wrong thread mutation in `ColourHitErrorMeter`

  Dan Balasescu · 2021-12-21 15:05:57 +09:00
  3b700b6967
• Add logging of MultiplayerMatchSubScreen exiting from room loss
  Dean Herbert · 2021-12-21 14:53:24 +09:00
  ddadf3c4b5
• Fix intermittent failures on TestSceneBeatmapListingOverlay

  In the specific method, there was no wait step after the initial fetch
  (unlike all of the rest), meaning the fetch may not have finished in
  time for the follow-up steps.
  
  As seen at
  https://github.com/ppy/osu/runs/4588058438?check_suite_focus=true.

  Dean Herbert · 2021-12-21 14:12:06 +09:00
  0f8a6a3f64
• Merge pull request #16168 from peppy/windows-key-when-inactive

  Avoid blocking windows key usage when the osu! window is not active

  Dan Balasescu · 2021-12-21 13:51:10 +09:00
  2ea31c26a5
• Add note about local button clicking usage
  Dean Herbert · 2021-12-21 13:49:51 +09:00
  bb3f375958
• Remove unused method in TestSceneMultiplayerQueueList
  Dean Herbert · 2021-12-21 13:49:51 +09:00
  aad55ef89e
• Centralise all multiplayer button clicking test logic

  This adds the "wait for enabled" check in a way that can be easily
  reused, as it keeps getting missed in test implementations.
  
  This particular commit hopefully fixes
  https://github.com/ppy/osu/runs/4583845033?check_suite_focus=true.

  Dean Herbert · 2021-12-21 13:49:51 +09:00
  9aff646ff4
• Fix incorrect event unbind logic
  Dean Herbert · 2021-12-21 13:05:26 +09:00
  edcbd4de6d
• Move Schedule call to base implementation of error meter for extra safety
  Dean Herbert · 2021-12-21 12:55:21 +09:00
  52db7b36fc
• Fix potential wrong thread mutation in ColourHitErrorMeter
  Dean Herbert · 2021-12-21 12:36:04 +09:00
  28d6ff5d9c
• Merge pull request #15728 from MBmasher/fl-decay

  Remove decay factor in Flashlight skill

  Dan Balasescu · 2021-12-21 07:59:32 +09:00
  377cb1d9e3
• Merge branch 'master' into beatmap-card/extra
  Bartłomiej Dach · 2021-12-20 15:49:00 +01:00
  f1a03aced5
• Merge pull request #16167 from peppy/fix-song-select-test-failure

  Fix occasional failures in `TestScenePlaySongSelect`

  Dean Herbert · 2021-12-20 23:11:06 +09:00
  488e1f858b
• Merge branch 'master' into fix-song-select-test-failure
  Bartłomiej Dach · 2021-12-20 11:36:49 +01:00
  0b7daf542f
• Merge pull request #16169 from peppy/fix-ready-button-test

  Add better defined steps to `TestLoseHostWhileReady` ready button test

  Bartłomiej Dach · 2021-12-20 11:36:20 +01:00
  6bbc9ccf97
• Ensure presence of at least 1 difficulty for each ruleset
  Bartłomiej Dach · 2021-12-20 11:34:39 +01:00
  f492cf84d9
• Merge branch 'master' into fix-ready-button-test
  Bartłomiej Dach · 2021-12-20 11:02:43 +01:00
  d8be455a43
• Merge pull request #16172 from peppy/update-framework

  Update framework

  Bartłomiej Dach · 2021-12-20 11:02:15 +01:00
  e4702b8729
• Rename TestMultiplayerScreenStack to TestMultiplayerComponents
  Dean Herbert · 2021-12-20 18:24:59 +09:00
  ec0a6735eb
• Name some screen stacks for better logging context
  Dean Herbert · 2021-12-20 18:24:14 +09:00
  6907a9a3cc
• Update framework
  Dean Herbert · 2021-12-20 18:22:19 +09:00
  1533aefce5
• Add better defined steps to TestLoseHostWhileReady ready button test

  Not 100% sure this will solve the issue but it's worth a try. The button
  state checks are using `Until` everywhere else so this brings the test
  in line with the standards.
  
  As seen
  https://github.com/ppy/osu/runs/4579641456?check_suite_focus=true.

  Dean Herbert · 2021-12-20 17:47:06 +09:00
  87051d5d61
• Avoid blocking windows key usage when the osu! window is not active

  As discussed in https://github.com/ppy/osu/discussions/16147.

  Dean Herbert · 2021-12-20 17:40:11 +09:00
  090c3e84e7
• Merge pull request #16166 from peppy/playlist-tests-wait-step

  Add wait step to `TestScenePlaylistResultScreen` explicitly for screen load

  Bartłomiej Dach · 2021-12-20 09:36:57 +01:00
  51386bb48d
• Chooser earlier items in song select tests to avoid potentially not having enough
  Dean Herbert · 2021-12-20 17:11:15 +09:00
  5c8e317a6e
• Fix weird loop logic
  Dean Herbert · 2021-12-20 17:09:08 +09:00
  af78a3e99d
• Add wait step to TestScenePlaylistResultScreen explicitly for screen load
  Dean Herbert · 2021-12-20 16:58:36 +09:00
  d79602a912
• Merge pull request #16164 from smoogipoo/fix-intermittent-background-test

  Fix intermittent background screen test failures

  Dean Herbert · 2021-12-20 14:00:53 +09:00
  2e47c4e25d
• Merge pull request #16165 from smoogipoo/fix-multiplayer-tests

  Add better fix for intermittent multiplayer tests as a result of async room joins

  Dean Herbert · 2021-12-20 13:44:29 +09:00
  ce6503ff8b
• Better fix for intermittent multiplayer tests
  Dan Balasescu · 2021-12-20 13:10:13 +09:00
  9316abc278
• Wait for previous screen to be hidden in test
  Dan Balasescu · 2021-12-20 12:44:23 +09:00
  11f3ec0cb5
• Merge pull request #16163 from smoogipoo/remove-sdk-greater-than-readme

  Require installing .NET 5 in README

  Dean Herbert · 2021-12-20 12:19:59 +09:00
  c81787a43d
• Require installing .NET 5 in README
  Dan Balasescu · 2021-12-20 11:49:39 +09:00
  1203ae5984
• Merge pull request #16158 from bdach/is-ranked-user-profile

  Fix rank graph showing for unranked users on profile overlay

  Dan Balasescu · 2021-12-20 09:14:17 +09:00
  ecaa0a40c5
• Fix rank graph showing for unranked users
  Bartłomiej Dach · 2021-12-19 13:40:22 +01:00
  a6ccbafc77
• Add test for ranked/unranked user display
  Bartłomiej Dach · 2021-12-19 13:40:22 +01:00
  097402677d
• Bring profile header test in line with modern conventions

  - Removed online code that didn't work anyway after the introduction of
    the development web instance.
  
  - Removed some weird test steps.
  
  - Fixed online/offline test steps not working at all due to identical
    user ID.

  Bartłomiej Dach · 2021-12-19 13:40:21 +01:00
  c112177559
• Merge pull request #16142 from peppy/fix-random-skin-string

  Fix "Random Skin" text not showing up correctly

  Dan Balasescu · 2021-12-18 16:59:41 +09:00
  a3b81094ca
• Fix "Random Skin" text not showing up correctly
  Dean Herbert · 2021-12-18 16:26:15 +09:00
  04cfae9bde
• Move scale-on-expand logic to BeatmapCardContent
  Bartłomiej Dach · 2021-12-17 13:29:20 +01:00
  33e930f477
• Extract base class for beatmap cards
  Bartłomiej Dach · 2021-12-17 13:27:11 +01:00
  d6f6039934
• Extract collapsible button container for card usage
  Bartłomiej Dach · 2021-12-17 12:58:05 +01:00
  f052b47d87