67193 Commits

This Branch

This Branch

All Branches

• Fix classic scoring overflowing in osu! ruleset due to integer multiplication overflow

  Closes https://github.com/ppy/osu/issues/25545.

  Bartłomiej Dach · 2023-11-23 08:16:25 +09:00
  e28e0ef1cc
• Add test coverage for classic scoring overflowing in osu! ruleset
  Bartłomiej Dach · 2023-11-23 08:12:34 +09:00
  3441a9a5b5
• Remove manual changes to Xcode versions in CI
  Rowe Wilson Frederisk Holme · 2023-11-23 01:18:55 +08:00
  9fd0641238
• Merge pull request #25418 from smoogipoo/hp-drain-v1-2

  Add `OsuHealthProcessor` that uses the legacy drain rate algorithm

  Dean Herbert · 2023-11-23 00:08:20 +09:00
  52dc02fd32
• Disabled RecievePositionalInputAtSubTree in PlayerFlag.
  yesseruser · 2023-11-22 15:45:32 +01:00
  82fec4194d
• Revert "Renamed UpdateableFlag to ClickableUpdateableFlag."

  This reverts commit 671177e871.

  yesseruser · 2023-11-22 15:25:43 +01:00
  08e0279d72
• Revert "Created and implemened a BaseUpdateableFlag."

  This reverts commit cd7e0bf620.

  yesseruser · 2023-11-22 15:25:35 +01:00
  be8b59e59d
• Revert "Added a BaseDrawableFlag without a tooltip, and used it."

  This reverts commit b2f74325ef.

  yesseruser · 2023-11-22 15:25:17 +01:00
  7bc304f20e
• Merge branch 'master' into FlagHUD
  yesseruser · 2023-11-22 14:36:20 +01:00
  33de27499a
• Attempt to fix intermittent failures on new tests

  See https://github.com/ppy/osu/pull/25418/checks?check_run_id=18886372597.

  Dean Herbert · 2023-11-22 21:46:35 +09:00
  aa8dc6bd80
• Update to respect distance snap

  This will cause freehand drawing to respect distance snap, instead
  changing the drawn path to start from the sliders start position
  and "snap" in a linear fashion to the cursor position from the
  position indicated by distance snap

  cs · 2023-11-22 10:14:44 +01:00
  95b12082ae
• Fix freehand-drawn sliders with distance snap
  cs · 2023-11-22 09:55:32 +01:00
  f7fce1d714
• Fix first object after break not starting a new combo
  Dan Balasescu · 2023-11-22 17:22:48 +09:00
  cb4568c4a1
• Merge pull request #25523 from peppy/save-skin-on-screen-change

  Save any unsaved changes in the skin editor when game changes screens

  Bartłomiej Dach · 2023-11-22 14:19:57 +09:00
  f1f820bec3
• Merge pull request #25536 from peppy/combo-commenting

  Improve commenting around `IHasCombo` interfaces

  Dean Herbert · 2023-11-22 13:28:03 +09:00
  b30a4ab3a9
• Merge pull request #25510 from Stedoss/login-state-changes-user-profile-overlay

  Handle login API state changes in `UserProfileOverlay`

  Dean Herbert · 2023-11-22 12:41:11 +09:00
  34a2545d9c
• Merge branch 'master' into login-state-changes-user-profile-overlay
  Dean Herbert · 2023-11-22 12:13:49 +09:00
  d86e743745
• Ensure only run once
  Dean Herbert · 2023-11-22 12:03:42 +09:00
  ad6af1d9b7
• Refactor to use API state instead of logged in user state
  Dean Herbert · 2023-11-22 12:02:37 +09:00
  fe15b26bd2
• Improve commenting around IHasCombo interfaces

  Following discusion with smoogi IRL.

  Dean Herbert · 2023-11-22 10:44:29 +09:00
  04640b6fb0
• Merge pull request #25533 from bdach/aaaannndddrroooiiiddd
  Dean Herbert · 2023-11-22 08:44:43 +09:00
  7bdee96c07
• Rewrite backwards assertion
  Poyo · 2023-11-21 15:19:04 -08:00
  3a0586a8f5
• Use better fallback

  Seems better to use the rate from a non-gameplay clock than to arbitrarily apply 1.

  Poyo · 2023-11-21 15:18:04 -08:00
  0cf925dadf
• Fix android compile failures due to invalid java version

  See https://github.com/ppy/osu-framework/pull/6057.

  Bartłomiej Dach · 2023-11-22 07:55:41 +09:00
  aa72407065
• Update framework
  Bartłomiej Dach · 2023-11-22 07:52:28 +09:00
  c98be5823d
• Added a BaseDrawableFlag without a tooltip, and used it.

  The BaseDrawableFlag is used in a BaseUpdateableFlag so the tooltip is not shown, the ClickableUpdateableFlag still shows the tooltip.

  yesseruser · 2023-11-21 19:51:35 +01:00
  b2f74325ef
• Created and implemened a BaseUpdateableFlag.

  The tooltip still shows.

  yesseruser · 2023-11-21 19:27:33 +01:00
  cd7e0bf620
• Renamed UpdateableFlag to ClickableUpdateableFlag.
  yesseruser · 2023-11-21 19:02:23 +01:00
  671177e871
• Scoring conversion: remove mention of v3 + improve comments
  Clément Burgelin (Zyfarok) · 2023-11-21 14:26:07 +01:00
  901e45b6a4
• Fix: update score migration of special case to match the new score

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Clément Burgelin (Zyf) · 2023-11-21 11:27:03 +01:00
  16acec335f
• Remove default DrainRate value
  Dan Balasescu · 2023-11-21 19:18:02 +09:00
  8302ebcf1a
• Merge pull request #25521 from Syriiin/fix/refactor-miss

  Fix implicitly used method being named incorrectly

  Dan Balasescu · 2023-11-21 18:00:19 +09:00
  4b5ef8328b
• Save any unsaved changes in the skin editor when game changes screens

  Closes https://github.com/ppy/osu/issues/25494.

  Dean Herbert · 2023-11-21 17:49:57 +09:00
  aa749aeb73
• Refactor OnlineStatusNotifier to be more local
  Bartłomiej Dach · 2023-11-21 17:36:29 +09:00
  85bddab52b
• Merge pull request #25520 from peppy/context-menu-spacers

  Allow context menus to have visible spacers

  Dean Herbert · 2023-11-21 16:56:36 +09:00
  21bf288277
• Merge pull request #25409 from Tom94/bspline-sliders

  Add free-hand drawing of sliders to the editor

  Bartłomiej Dach · 2023-11-21 16:28:14 +09:00
  bf972a04ee
• Fix spacer appearing on top of menu
  Bartłomiej Dach · 2023-11-21 16:14:41 +09:00
  ed38746823
• Merge pull request #25371 from RatinFX/open-editor-timestamp

  Implement opening editor timestamp links

  Bartłomiej Dach · 2023-11-21 15:48:36 +09:00
  d83b2e24e7
• Add ToString on PathType for better test output
  Dean Herbert · 2023-11-21 15:38:12 +09:00
  4b2d8aa6a6
• Fix dragging after one point already placed incorrectly entering drawing mode
  Dean Herbert · 2023-11-21 15:38:12 +09:00
  cc33e12125
• Add failing test coverage of drag after point placement
  Dean Herbert · 2023-11-21 15:38:12 +09:00
  1660eb3c15
• Reorder methods
  Dean Herbert · 2023-11-21 15:38:12 +09:00
  a210469956
• Simplify drag handling code in SliderPlacementBlueprint
  Dean Herbert · 2023-11-21 15:38:12 +09:00
  016de7be6a
• Remove redundant Clear() call
  Dean Herbert · 2023-11-21 15:38:12 +09:00
  cf6f66b84f
• Simplify toolbox initialisation
  Dean Herbert · 2023-11-21 15:38:12 +09:00
  92728ea564
• Update framework
  Dean Herbert · 2023-11-21 15:38:12 +09:00
  ba6fbbe43c
• Fix incorrect parsing of BSpline curve types
  Dean Herbert · 2023-11-21 15:38:12 +09:00
  3d094f84ad
• Add failing test coverage of BSpline encoding parse failure
  Dean Herbert · 2023-11-21 15:38:12 +09:00
  9c3f9db318
• Apply NRT to SliderPlacementBlueprint tests
  Dean Herbert · 2023-11-21 15:38:12 +09:00
  7bedbe4264
• Update test coverage (and add test coverage of curve drawing)
  Dean Herbert · 2023-11-21 15:38:12 +09:00
  5175464c18