h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2025-03-15 18:27:19 +08:00
Code Issues Releases Wiki Activity

Refactor OnlineStatusNotifier to be more local

Browse Source
This commit is contained in:
Bartłomiej Dach 2023-11-21 16:52:52 +09:00
parent aa3ff151c0
commit 85bddab52b
No known key found for this signature in database
1 changed files with 62 additions and 46 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

108
osu.Game/Online/OnlineStatusNotifier.cs
View File

@ -17,6 +17,9 @@ using osu.Game.Screens.OnlinePlay;
namespace osu.Game.Online
{
/// <summary>
/// Handles various scenarios where connection is lost and we need to let the user know what and why.
/// </summary>
public partial class OnlineStatusNotifier : Component
{
private readonly Func<IScreen> getCurrentScreen;
@ -33,7 +36,11 @@ namespace osu.Game.Online
private IBindable<APIState> apiState = null!;
private IBindable<bool> multiplayerState = null!;
private IBindable<bool> spectatorState = null!;
private bool forcedDisconnection;
/// <summary>
/// This flag will be set to <c>true</c> when the user has been notified so we don't show more than one notification.
/// </summary>
private bool userNotified;
public OnlineStatusNotifier(Func<IScreen> getCurrentScreen)
{
@ -51,12 +58,63 @@ namespace osu.Game.Online
spectatorClient.Disconnecting += notifyAboutForcedDisconnection;
}
protected override void LoadComplete()
{
base.LoadComplete();
apiState.BindValueChanged(state =>
{
if (state.NewValue == APIState.Online)
{
userNotified = false;
return;
}
if (userNotified) return;
if (state.NewValue == APIState.Offline && getCurrentScreen() is OnlinePlayScreen)
{
userNotified = true;
notificationOverlay?.Post(new SimpleErrorNotification
{
Icon = FontAwesome.Solid.ExclamationCircle,
Text = "Connection to API was lost. Can't continue with online play."
});
}
});
multiplayerState.BindValueChanged(connected => Schedule(() =>
{
if (connected.NewValue)
{
userNotified = false;
return;
}
if (userNotified) return;
if (multiplayerClient.Room != null)
{
userNotified = true;
notificationOverlay?.Post(new SimpleErrorNotification
{
Icon = FontAwesome.Solid.ExclamationCircle,
Text = "Connection to the multiplayer server was lost. Exiting multiplayer."
});
}
}));
spectatorState.BindValueChanged(_ =>
{
// TODO: handle spectator server failure somehow?
});
}
private void notifyAboutForcedDisconnection()
{
if (forcedDisconnection)
return;
if (userNotified) return;
forcedDisconnection = true;
userNotified = true;
notificationOverlay?.Post(new SimpleErrorNotification
{
Icon = FontAwesome.Solid.ExclamationCircle,
@ -64,48 +122,6 @@ namespace osu.Game.Online
});
}
protected override void LoadComplete()
{
base.LoadComplete();
apiState.BindValueChanged(_ =>
{
if (apiState.Value == APIState.Online)
forcedDisconnection = false;
Scheduler.AddOnce(updateState);
});
multiplayerState.BindValueChanged(_ => Scheduler.AddOnce(updateState));
spectatorState.BindValueChanged(_ => Scheduler.AddOnce(updateState));
}
private void updateState()
{
if (forcedDisconnection)
return;
if (apiState.Value == APIState.Offline && getCurrentScreen() is OnlinePlayScreen)
{
notificationOverlay?.Post(new SimpleErrorNotification
{
Icon = FontAwesome.Solid.ExclamationCircle,
Text = "API connection was lost. Can't continue with online play."
});
return;
}
if (!multiplayerClient.IsConnected.Value && multiplayerClient.Room != null)
{
notificationOverlay?.Post(new SimpleErrorNotification
{
Icon = FontAwesome.Solid.ExclamationCircle,
Text = "Connection to the multiplayer server was lost. Exiting multiplayer."
});
}
// TODO: handle spectator server failure somehow?
}
protected override void Dispose(bool isDisposing)
{
base.Dispose(isDisposing);