61096 Commits

This Branch

This Branch

All Branches

• Refactor InputCountController to not require being added to foreign body via Attach

  I've made the flow match `ClicksPerSecondCalculator` as close as
  possible. Hopefully this reads better.

  Dean Herbert · 2023-06-27 16:36:00 +09:00
  e21583ff1b
• Add safety to tests to ensure loaded
  Dean Herbert · 2023-06-27 16:04:34 +09:00
  e99de0eb5d
• Attempt to remedy HUD overlay test failure by waiting more
  Bartłomiej Dach · 2023-06-26 22:41:31 +02:00
  9c87d42f2b
• Fix incorrect indent size
  Bartłomiej Dach · 2023-06-26 22:40:25 +02:00
  40ceb4dfac
• Rename Judgement{Tally -> CountController}
  Bartłomiej Dach · 2023-06-26 19:30:04 +02:00
  7200855d46
• Rename {KeyCounter -> InputCount}Controller
  Bartłomiej Dach · 2023-06-26 19:27:42 +02:00
  8d91580dc1
• Group input handling members together
  Bartłomiej Dach · 2023-06-26 19:25:52 +02:00
  4ac48e4cd8
• Remove redundant guard

  In this particular case guarding with `.IsNull()` makes no sense, as the
  `Trigger` is supplied in constructor and cannot feasibly be null. Doing
  that only makes sense in scenarios where BDL / dependency injection is
  involved.

  Bartłomiej Dach · 2023-06-26 19:25:52 +02:00
  ff562e2dd7
• Fix attempting to add key counter controller to hierarchy in multiple places
  Bartłomiej Dach · 2023-06-26 19:02:49 +02:00
  dbd76c1193
• Mark IHasRecordingHandler.Recorder nullable
  Bartłomiej Dach · 2023-06-26 18:52:05 +02:00
  cc45ec4fff
• Add xmldoc for KeyCounterController
  Dean Herbert · 2023-06-26 16:47:33 +09:00
  44c08f3944
• Split out interfaces from RulesetInputManager and improve xmldoc
  Dean Herbert · 2023-06-26 16:34:57 +09:00
  084354a8dc
• Remove unused interface
  Dean Herbert · 2023-06-26 16:32:19 +09:00
  c8e081c2b6
• Actuall add composite component to hierarchy
  Dean Herbert · 2023-06-26 16:24:36 +09:00
  ec20942830
• Move argon key counter to right to match stable expectations
  Dean Herbert · 2023-06-26 16:22:38 +09:00
  3a2dd0e7dd
• Improve positioning and positioning code clarity for argon / triangles implementations
  Dean Herbert · 2023-06-26 16:20:51 +09:00
  52fdeeb491
• Split padding out into constant to fix weird looking math
  Dean Herbert · 2023-06-26 16:05:57 +09:00
  ba7f472247
• Merge branch 'master' into hud/kc-skinnable
  Dean Herbert · 2023-06-26 15:53:16 +09:00
  0c869367e1
• Merge pull request #24039 from bastianpedersen/localise-multiplayer-countdown-buttons

  Localise multiplayer countdown buttons

  Dean Herbert · 2023-06-26 14:55:28 +09:00
  6ec8ccda11
• Merge pull request #24037 from cdwcgt/tournament-beatmapcache

  Use beatmap cache to populate beatmap information in tournament client

  Dean Herbert · 2023-06-26 14:55:05 +09:00
  719ac75ad2
• Merge branch 'master' into localise-multiplayer-countdown-buttons
  Bastian Pedersen · 2023-06-26 07:28:05 +02:00
  506829d9a5
• Merge pull request #23331 from letsgoawaydev/ui-login-spacing-fix

  Update login overlay appearance to match new designs

  Dean Herbert · 2023-06-26 14:11:57 +09:00
  e085a36aac
• Rename class and key to better match expectations
  Dean Herbert · 2023-06-26 13:38:34 +09:00
  b240ce295b
• Apply nullability to login form related classes
  Dean Herbert · 2023-06-26 13:26:07 +09:00
  1abce098b4
• Merge branch 'master' into ui-login-spacing-fix
  Dean Herbert · 2023-06-26 13:24:26 +09:00
  372cef3c0a
• Fix weirdly named test method and add xmldoc
  Dean Herbert · 2023-06-26 13:21:29 +09:00
  ac0c988d49
• Remove pointless zero opacity specification
  Dean Herbert · 2023-06-26 13:19:07 +09:00
  8d2dccbda5
• Merge pull request #24022 from frenzibyte/fix-open-user-profile-argument

  Fix `OpenUserProfile` links having multiple argument types

  Dean Herbert · 2023-06-26 13:13:05 +09:00
  55ab27c5b6
• Remove unused usings
  Joseph Madamba · 2023-06-25 12:58:51 -07:00
  5477ef6bfb
• Remove most custom styling of user dropdown
  Joseph Madamba · 2023-06-25 12:46:00 -07:00
  ccc4d16096
• Normalise login overlay padding/spacing
  Joseph Madamba · 2023-06-25 12:26:01 -07:00
  6ebc2581c2
• Remove unnecessary container
  Joseph Madamba · 2023-06-25 12:15:03 -07:00
  671f84e32b
• Refactor login panel to not inherit FillFlowContainer
  Joseph Madamba · 2023-06-25 12:06:02 -07:00
  4582faee79
• Use newly create localised strings for buttons
  Bastian Pedersen · 2023-06-25 21:03:07 +02:00
  a7153478d6
• Create localisation string class for multiplayer countdown buttons
  Bastian Pedersen · 2023-06-25 21:02:51 +02:00
  59fa46bbdd
• Fix login error text adding unnecessary spacing
  Joseph Madamba · 2023-06-25 11:57:17 -07:00
  4a3b8c405e
• Remove using aliases
  Joseph Madamba · 2023-06-25 11:39:33 -07:00
  442fda3598
• Update login overlay background to conform to other overlays
  Joseph Madamba · 2023-06-25 11:39:32 -07:00
  1058f434d7
• Improve and refactor LoginPanel test scene to use LoginOverlay
  Joseph Madamba · 2023-06-25 11:39:32 -07:00
  25c9bf4061
• Merge remote-tracking branch 'upstream/master' into pr/23331
  Joseph Madamba · 2023-06-25 10:01:32 -07:00
  f87ac3f405
• Merge pull request #24033 from cdwcgt/chatdisplay-fix

  Fix tournament chat potentially crashing due to null current match

  Bartłomiej Dach · 2023-06-25 18:12:15 +02:00
  66f1ed052b
• Use GetResultSafely()
  cdwcgt · 2023-06-26 00:45:59 +09:00
  1b671b8c6e
• Merge branch 'master' into chatdisplay-fix
  Bartłomiej Dach · 2023-06-25 17:39:45 +02:00
  88fbc3094a
• Rename test step
  Bartłomiej Dach · 2023-06-25 17:39:36 +02:00
  44a3f40188
• Remove no-longer-needed BDL permitNulls spec
  Bartłomiej Dach · 2023-06-25 17:39:15 +02:00
  7d9d7066cd
• Use alternative guard

  Early-returning from ctors feels pretty bad. Also saves on some
  nested accesses.

  Bartłomiej Dach · 2023-06-25 17:37:05 +02:00
  9862992af0
• use BeatmapCache for populate beatmap information
  cdwcgt · 2023-06-25 22:57:39 +09:00
  14e26d2a85
• Revert "remove #nullable disable in LadderInfo"

  This reverts commit 0dced46100.

  cdwcgt · 2023-06-25 22:47:36 +09:00
  e02a06e3e5
• Merge branch 'master' into hud/kc-skinnable
  tsrk · 2023-06-25 15:42:08 +02:00
  350d722c8d
• revert: bring back old attachment flow

  As discussed, this would bring more problems that anything.
  
  Refs: 4c39708, f83a4f4

  tsrk · 2023-06-25 15:21:55 +02:00
  a7088ffe22