80 Commits

• Add xmldoc and rename methods in IPositionSnapProvider for legibility
  Dean Herbert · 2022-05-05 15:58:21 +09:00
  f6fc926f1a
• Move distancing methods from IPositionSnapProvider to IDistanceSnapProvider
  Salman Ahmed · 2022-04-28 05:48:45 +03:00
  59cf3ff50f
• Use slider snapping more liberally to match user expectations

  Previously the slider path length would be snapped using the current
  beat snap setting on *every* change of the slider path. As it turns out
  this is unexpected behaviour in some situations (e.g. when reversing a
  path, which is expected to preserve the previous duration, even though
  the slider may be technically "unsnapped" at that point in time due to a
  different beat snap setting being selected afterwards).

  Bartłomiej Dach · 2022-01-07 16:02:04 +01:00
  c09f6ee052
• Move public method up and add xmldoc to second public method
  Dean Herbert · 2021-12-23 14:13:57 +09:00
  b0df787b1a
• Select newly created control point
  Bartłomiej Dach · 2021-12-22 10:33:07 +01:00
  6330fa5dc5
• Fix selections including head not correctly dragging if not started from head
  Bartłomiej Dach · 2021-12-21 12:35:48 +01:00
  e715bff535
• Implement drag operation for multiple path control points
  Bartłomiej Dach · 2021-12-20 21:29:57 +01:00
  d2417beeac
• Move slider path point drag handling to visualiser
  Bartłomiej Dach · 2021-12-20 20:56:06 +01:00
  b0ca82e1e5
• Update with keybinding changes
  smoogipoo · 2021-09-16 18:26:12 +09:00
  f9d5abff8a
• Fix missed cases of incorrect .Value usage

  Changing from `Bindable` to `Nullable` comes with its issues...

  Dean Herbert · 2021-08-26 14:02:57 +09:00
  17f6efc6fe
• Remove bindable usage in PathControlPoint

  This is quite a breaking change, but I think it is beneficial due to the large amount of usage of this class.
  
  I originally intended just to remove the allocations of the two delegates handling the `Changed` flow internally, but as nothing was really using the bindables for anything more than a general "point has changed" case, this felt like a better direction.

  Dean Herbert · 2021-08-26 12:33:53 +09:00
  6dcd9427ac
• Adapt to PlatformAction type change
  ekrctb · 2021-07-21 16:12:53 +09:00
  1bac471b49
• Create base implementations of the two most common TernaryStateMenuItems
  Dean Herbert · 2021-05-20 19:34:53 +09:00
  df5970fab4
• Carry over the previous path type
  Naxess · 2021-04-09 11:04:00 +02:00
  f64b2095bf
• Fix index out of range possibility
  Naxess · 2021-04-08 11:46:00 +02:00
  be4520fe33
• Improve UX of selecting PerfectCurve
  Naxess · 2021-04-08 09:06:28 +02:00
  0341023d13
• Add path type menu change method
  Naxess · 2021-04-08 09:05:35 +02:00
  725edfcbf3
• Fix slider right click context menus not being shown outside the valid playfield area

  Closes #10816.

  Dean Herbert · 2020-11-20 13:46:23 +09:00
  b547abafb2
• Simplify inequality
  kamp · 2020-11-17 23:04:38 +01:00
  2d66423fbd
• Apply suggestions and remove redundant updateConnectingPath call
  kamp · 2020-11-17 22:23:46 +01:00
  c8fb49d540
• Fix slider control point connections not being updated
  kamp · 2020-11-16 21:26:08 +01:00
  c6618f08aa
• Add change handler support for contorl point deletion
  Dean Herbert · 2020-11-05 15:05:43 +09:00
  3f24fabb57
• Don't override PathControlPointVisualiser's positional handling

  It turns out it was relying on this to deselect control points on
  clicking away from them.

  Dean Herbert · 2020-11-05 14:58:30 +09:00
  242ec1ca82
• Add the ability to delete slider control points using shift+right click

  Closes https://github.com/ppy/osu/issues/10672.
  
  In two minds about how this should be implemented but went in this
  direction initially. The other way would be to add local handling of
  Shift-Right Click inside PathControlPointPiece (which is already doing
  mouse handling itself).

  Dean Herbert · 2020-11-03 20:46:33 +09:00
  9f333ac58a
• Fix connections hidden due to overlapping controlpoints
  smoogipoo · 2020-04-13 16:13:14 +09:00
  9a65aa18d7
• Apply OnRelease method signature refactorings
  smoogipoo · 2020-01-22 13:22:34 +09:00
  7b2f58eb30
• Merge remote-tracking branch 'upstream/master' into separate-path-connection
  Dean Herbert · 2019-12-11 20:14:29 +09:00
  42a01a10dd
• Rename class to signify it is a drawable
  Dean Herbert · 2019-12-11 20:11:48 +09:00
  47b6b01739
• Merge branch 'master' into separate-path-connection
  Dean Herbert · 2019-12-11 19:03:14 +09:00
  d027c982e4
• Move control point removal to SliderSelectionBlueprint
  Dean Herbert · 2019-12-11 18:58:35 +09:00
  23959f3a3c
• Curve -> Curve type
  Dean Herbert · 2019-12-11 18:20:28 +09:00
  d82ba3e7f7
• Don't show inherit menu item when first control point is selected
  Dean Herbert · 2019-12-11 18:18:16 +09:00
  03040d1750
• Add missing bezier option to menu
  Dean Herbert · 2019-12-11 17:58:59 +09:00
  97ca2e2753
• Merge branch 'master' into path-type-menuitem
  Dean Herbert · 2019-12-11 16:43:55 +09:00
  cda6757f52
• Merge branch 'master' into separate-path-connection
  Dean Herbert · 2019-12-11 16:43:04 +09:00
  f515bdc599
• Merge branch 'master' into path-visualiser-refactor
  Dan Balasescu · 2019-12-10 16:33:45 +09:00
  42a979b495
• Merge branch 'master' into segmented-slider-paths-3
  Dean Herbert · 2019-12-10 14:28:20 +09:00
  5f3d163772
• Separate path connections from control points
  smoogipoo · 2019-12-10 11:20:08 +09:00
  e9ec6591a9
• Don't show count when deleting only one control point

  Reads better.

  Dean Herbert · 2019-12-10 03:29:25 +09:00
  1db218f908
• Add right-click menu item to change path type
  smoogipoo · 2019-12-10 00:07:07 +09:00
  9b318d2869
• Consider having only 1 control point as being deleted
  smoogipoo · 2019-12-09 22:36:19 +09:00
  bd2b0af269
• Refactor path visualisers to use bindables
  smoogipoo · 2019-12-09 20:49:59 +09:00
  af90b45c40
• Remove automatic slider path offsetting
  smoogipoo · 2019-12-09 17:54:22 +09:00
  883d5bc11d
• General cleanups
  smoogipoo · 2019-12-09 16:44:19 +09:00
  53f7c753fb
• Remove unused usings
  smoogipoo · 2019-12-09 13:19:21 +09:00
  4905709ea4
• Fix deleting the first control point not working
  smoogipoo · 2019-12-06 18:49:14 +09:00
  52dd7bf716
• Handle control point positional updates within SliderPath
  smoogipoo · 2019-12-06 18:49:01 +09:00
  16f8341a02
• Fix multiple control point deletions
  smoogipoo · 2019-12-06 17:03:54 +09:00
  2b5f9515de
• Clean up unused/unnecessary properties
  smoogipoo · 2019-12-06 12:31:22 +09:00
  247609388f
• Initial game-wide update with the new SliderPath
  smoogipoo · 2019-12-05 19:53:36 +09:00
  3ebbf62b2a