Bartłomiej Dach
1b5d1347aa
Merge branch 'master' into bat-mods
2024-11-01 11:27:06 +01:00
Bartłomiej Dach
5f63950598
Add missing disposal
2024-11-01 11:26:59 +01:00
Bartłomiej Dach
1008d32ddb
Fix old looping samples not stopping when replacing a SkinnableSound's Samples
...
Closes https://github.com/ppy/osu/issues/30365 .
2024-10-22 14:35:21 +02:00
Dan Balasescu
def499e7cb
Merge branch 'master' into bat-mods
2024-10-18 18:58:45 +09:00
Dan Balasescu
e27aa0c761
Return empty strings rather than erroring
...
Preventing malicious actors from permanently destroying games via skins.
2024-10-18 17:18:01 +09:00
Dan Balasescu
2de5e3392e
Only add as many values as are replaced
2024-10-18 17:16:42 +09:00
Bartłomiej Dach
8804769da1
Use better exception messaging
2024-10-18 08:51:01 +02:00
Bartłomiej Dach
b455b9ad09
Discard unused argument
2024-10-18 08:39:23 +02:00
Dan Balasescu
b40c31af3a
Store difficulty to reduce flickering
...
The computation usually finishes in a few milliseconds anyway.
2024-10-17 20:37:37 +09:00
Dan Balasescu
f9a9ceb41c
Also bind to mod setting changes
2024-10-17 17:57:49 +09:00
Dan Balasescu
9ea15a3961
Show bpm and length inclusive of mods
2024-10-17 17:57:49 +09:00
Dan Balasescu
400142545d
Show difficulty values inclusive of mods
2024-10-17 17:57:49 +09:00
Dan Balasescu
1e2c1323ff
Show star difficulty attribute inclusive of mods
2024-10-17 17:57:49 +09:00
Dan Balasescu
102f55a213
Refactor BeatmapAttributeText to compute values on the fly
2024-10-17 16:10:06 +09:00
Dean Herbert
5efdc6cdd7
Merge pull request #29936 from u4vh3/skinning-colour-customisation
...
Add colour customisation to layout editor
2024-09-27 14:20:58 +09:00
Dean Herbert
89e8baf1d3
Add inline comments for iOS locals
2024-09-26 16:48:42 +09:00
Dan Balasescu
3ab04d98f6
Fix Realm-related iOS crashes by removing object references
2024-09-25 16:45:37 +09:00
Bartłomiej Dach
9f4e48dde7
Actually use bindables rather than stick things in Update()
2024-09-24 15:15:28 +02:00
Daniel Cios
73b6744a97
Rename FontColour to TextColour
2024-09-20 16:50:17 +02:00
Daniel Cios
ec575e9de4
Rename Colour to AccentColour
2024-09-20 16:38:26 +02:00
Daniel Cios
e81e356d59
Add colour customisation to skin components
2024-09-19 17:27:25 +02:00
Bartłomiej Dach
0e663d1801
Revert default combo counter code to pre-abstractification (and nuke eldritch abstract entity)
2024-09-11 11:44:59 +02:00
Dean Herbert
885d832e98
Fix deserialise failing with some old skins
2024-08-23 20:44:45 +09:00
Dean Herbert
48cfd77ee8
Component -> Lookup
2024-08-23 14:48:50 +09:00
Dean Herbert
46d55d5e61
Remove remaining early base lookup calls which were missed
2024-08-22 20:13:28 +09:00
Dean Herbert
1435fe24ae
Remove requirement of base calls to ensure user skin container layouts are retrieved
2024-08-22 19:14:30 +09:00
Dean Herbert
b57b8168a6
Rename Target lookup to Component
2024-08-22 19:00:28 +09:00
Dean Herbert
9a21174582
Move GlobalSkinnableContainers to global scope
2024-08-22 18:46:07 +09:00
Dean Herbert
36b4013fa6
Rename GameplaySkinComponentLookup -> SkinComponentLookup
2024-08-22 18:46:03 +09:00
Dean Herbert
f37cab0c6e
Rename SkinComponentsContainerLookup to GlobalSkinnableContainerLookup
2024-08-22 18:39:36 +09:00
Dean Herbert
41756520b1
Rename SkinComponentsContainer to SkinnableContainer
2024-08-22 17:42:50 +09:00
Dean Herbert
04a2d67ca4
Fix legacy combo counter bounce animation not always playing
...
As mentioned [in
discord](https://discord.com/channels/188630481301012481/1097318920991559880/1274231995261649006 ).
2024-08-17 15:13:44 +09:00
Dean Herbert
d1d195cf18
Fix incorrect skin lookup shortcutting causing sprites to no longer work
2024-08-17 02:33:52 +09:00
Dean Herbert
5710f0f302
Merge pull request #26254 from frenzibyte/mania-combo-counter
...
Add argon/classic osu!mania combo counter
2024-08-15 17:56:28 +09:00
Dean Herbert
054366b25d
Use zero baseline for legacy sprite text display
2024-08-15 13:07:42 +09:00
Dean Herbert
f6ada68e47
Fix migration failure due to change in class name
2024-08-09 17:27:39 +09:00
Dean Herbert
7666e8b932
Remove SupportsClosestAnchor for the time being
...
This may have had a good reason to be added, but I can't find that
reason, so let's keep things simple for the time being.
2024-08-09 15:30:21 +09:00
Dean Herbert
80c814008f
Update in line with new changes
2024-08-09 14:55:01 +09:00
Dean Herbert
e645651ef4
Merge branch 'master' into mania-combo-counter
2024-08-09 00:19:17 +09:00
Dean Herbert
88c5997cb3
Add back removed xmldoc
2024-08-08 16:36:54 +09:00
Dean Herbert
60d383448f
Avoid making non-ruleset transformers in Ruleset.CreateSkinTransformer
...
This didn't make any sense, so let's do it a better way.
2024-08-08 16:29:54 +09:00
Dean Herbert
3c572abaa7
Merge branch 'master' into ruleset-specific-combo-counter
2024-08-08 03:21:52 +09:00
Dean Herbert
725dc4de9b
Use transformers for per-skin key counter implementation
2024-08-06 18:17:21 +09:00
Dean Herbert
8619bbb943
Fix legacy key counter's background being visible when intended to be hidden
2024-08-06 16:12:00 +09:00
Dean Herbert
90395aea13
Fix incorrect colour fallback handling
...
Adds a note about `GetConfig` being stupid.
2024-08-06 15:43:39 +09:00
Dean Herbert
c4572ec265
Sanitise font sizes / weights
2024-08-06 15:17:43 +09:00
Bartłomiej Dach
c3dae81935
Only add legacy key overlay to osu! and catch HUD layers
2024-07-24 15:41:20 +02:00
Bartłomiej Dach
26395bd443
Adjust animations further to match stable
2024-07-24 15:26:27 +02:00
Bartłomiej Dach
3c28c116ca
Simplify input overlay text colour decode (and fix incorrect default)
2024-07-24 14:53:01 +02:00
Bartłomiej Dach
087dd759be
Adjust layout to ballpark-match stable
...
I dunno what the wiki is claiming with the "24px" figure or why
but I'm not playing conversion games either. Dimensions ballparked
via screenshots captured at x768 resolution.
Also removes a weird homebrew method to keep the text upright.
There is one canonical way to do this, namely
`UprightAspectMaintainingContainer`. And the other key counters
were already using it.
2024-07-24 14:52:56 +02:00
