60973 Commits

This Branch

This Branch

All Branches

• Fix wrong disable
  Bartłomiej Dach · 2023-06-24 17:07:42 +02:00
  df2dcf85b4
• Fix nullability-related warnings in Android project
  Bartłomiej Dach · 2023-06-24 17:05:52 +02:00
  34e2540331
• Fix remaining obvious CI inspections
  Bartłomiej Dach · 2023-06-24 16:07:01 +02:00
  e3a89a6273
• Revert nullability enables in tournament client

  Not trivial to fix right now and I'm not fixing in a 1k-line changeset.

  Bartłomiej Dach · 2023-06-24 16:05:19 +02:00
  caf5673b68
• Revert nullability enable in BeatmapBackground

  Due to varying expectations in handling of `Beatmap`. Some places allow
  or expect null and some don't. Needs to be looked at closer separately.

  Bartłomiej Dach · 2023-06-24 15:40:06 +02:00
  2c1a44da89
• Revert nullability enable in Score (and related changes)

  Causes several knock-on inspections in `OsuGame` et al. Probably best
  addressed in a separate pass, because treatment is mixed at best (some
  places nullcheck, some expect non-null).

  Bartłomiej Dach · 2023-06-24 15:35:07 +02:00
  66ef199fa4
• Match field NRT annotation in ctor argument
  Bartłomiej Dach · 2023-06-24 15:17:14 +02:00
  8fdd599b39
• Mark override as null-accepting

  `ModelBackedDrawable<T>.CreateDrawable()` is R#-annotated to accept
  a potentially null model. Apply nullability there too for better reading
  experience.

  Bartłomiej Dach · 2023-06-24 15:07:04 +02:00
  1f2f522a1e
• Trim redundant BDL nullability spec
  Bartłomiej Dach · 2023-06-24 14:35:23 +02:00
  354e85a2e1
• Merge branch 'master' into mass-nrt
  Dean Herbert · 2023-06-24 09:59:15 +09:00
  2bda63c2c8
• Merge pull request #24009 from peppy/fix-touch-input-controls-floating-fruits

  Change "floating fruits" mod to only apply adjustments to the playfield

  Bartłomiej Dach · 2023-06-23 23:26:20 +02:00
  23aa1752c3
• Merge pull request #23890 from cdwcgt/tournament-chatcolor

  Tint username of team members in tournament chat according to the team colour

  Salman Ahmed · 2023-06-23 23:22:40 +03:00
  318260bbfd
• Merge branch 'master' into tournament-chatcolor
  Salman Ahmed · 2023-06-23 22:23:33 +03:00
  c5771912db
• Reword and fix typo
  Salman Ahmed · 2023-06-23 22:20:25 +03:00
  7a771609f9
• Add test coverage for tournament players with profile colours
  Salman Ahmed · 2023-06-23 22:04:29 +03:00
  4a2f259f7e
• Add automated commit to blame ignore revs
  Dean Herbert · 2023-06-24 01:56:38 +09:00
  ad6650cbfa
• Manual fixes to reduce warnings to zero
  Dean Herbert · 2023-06-24 01:52:53 +09:00
  df5b389629
• Automated pass
  Dean Herbert · 2023-06-24 01:00:03 +09:00
  0ab0c52ad5
• Merge pull request #23971 from tybug/comment-logged-out

  Disable posting comments when logged out

  Dean Herbert · 2023-06-23 15:15:27 +09:00
  d86424467e
• Change "floating fruits" mod to only apply adjustments to the playfield

  Avoids things like touch screen inputs also being flipped.
  
  Note that these adjustments can't be applied directly to the playfield
  due to how playfields are used in various rulesets (basically relying on
  the `PlayfieldAdjustContainer` to get things in the right place).
  
  Closes #24000.

  Dean Herbert · 2023-06-23 14:18:43 +09:00
  08b3c0cce0
• Add Schedule to ensure correct thread for UI code
  Dean Herbert · 2023-06-23 14:07:33 +09:00
  343271751a
• Bind to API.State instead of API.User
  Dean Herbert · 2023-06-23 14:05:02 +09:00
  ce1579f2fe
• Merge branch 'master' into comment-logged-out
  Bartłomiej Dach · 2023-06-22 23:19:00 +02:00
  c06b825d9b
• Rename test helpers
  Bartłomiej Dach · 2023-06-22 23:10:16 +02:00
  2c1c20e0a7
• Document why things were done in DummyAPIAccess
  Bartłomiej Dach · 2023-06-22 23:08:30 +02:00
  1672608a87
• Rename and xmldoc members
  Bartłomiej Dach · 2023-06-22 23:00:52 +02:00
  786deec296
• Merge pull request #23999 from peppy/fix-catch-legacy-combo-floating

  Fix combo counter on legacy skins flipping when "Floating Fruits" mod is active

  Bartłomiej Dach · 2023-06-22 22:49:31 +02:00
  361ae15824
• Merge pull request #23888 from peppy/fix-intro-playing-twice

  Fix music sometimes restarting twice if exiting song select with no beatmap selected

  Bartłomiej Dach · 2023-06-22 22:49:15 +02:00
  0ce4d17e30
• Merge pull request #23974 from peppy/fix-multiplayer-present-beatmap

  Fix presenting beatmaps while in a multiplayer room not working

  Bartłomiej Dach · 2023-06-22 22:48:48 +02:00
  a753c89dea
• Merge pull request #23975 from peppy/skin-editor-beatmap-skin-disable

  Disable beatmap skinning support when entering the skin editor

  Bartłomiej Dach · 2023-06-22 22:45:44 +02:00
  bede12a3e8
• adjust DummyAPIAccess to more closely match APIAccess

  wrt logging in and out

  Liam DeVoe · 2023-06-22 16:01:12 -04:00
  21bed336c6
• Merge branch 'master' into skin-editor-beatmap-skin-disable
  Bartłomiej Dach · 2023-06-22 20:30:51 +02:00
  a11b3a67fb
• Remove unused using directive
  Bartłomiej Dach · 2023-06-22 20:24:44 +02:00
  aea5eb37dc
• Merge pull request #23967 from peppy/save-replay-hotkey

  Add hotkey to save replay

  Bartłomiej Dach · 2023-06-22 19:50:57 +02:00
  2b9cbaa4da
• Merge branch 'master' into save-replay-hotkey
  Bartłomiej Dach · 2023-06-22 18:51:30 +02:00
  65d4506ef2
• Merge pull request #23972 from peppy/notifications-during-pause

  Allow notifications while the game is paused (or in break time)

  Bartłomiej Dach · 2023-06-22 18:31:39 +02:00
  28dc5640a3
• Fix combo counter on legacy skins flipping when "Floating Fruits" mod is active

  Closes #23989.

  Dean Herbert · 2023-06-22 18:46:43 +09:00
  4be8eede88
• Fix typo in comment

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dean Herbert · 2023-06-22 00:02:02 +09:00
  07a00e8afd
• Allow nullable to fix test usages

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dean Herbert · 2023-06-22 00:01:48 +09:00
  7b4cbea362
• Fix potential null ref in ResultsScreen
  Dean Herbert · 2023-06-21 17:50:06 +09:00
  655491ae2d
• Add FireAndForget to stray Task.Run
  Dean Herbert · 2023-06-21 17:48:55 +09:00
  1907beb0c9
• Improve and combine logic that exists in two classes
  Dean Herbert · 2023-06-21 17:48:12 +09:00
  9ca772421d
• Change skin editor flow to always save on toggle

  This also moves the beatmap skin disable toggle to on toggle, in line
  with review feedback.
  
  I've decided to always apply the disable, not just on the `Player`
  screen. It should be assumed that if a user is in the skin editor they
  are never going to need access to this anyway.

  Dean Herbert · 2023-06-21 16:14:47 +09:00
  cb0f642ad7
• Use bindable lease instead of reimplementing the same thing locally
  Dean Herbert · 2023-06-21 16:09:54 +09:00
  366dd96875
• add test for comment when logging in and out
  Liam DeVoe · 2023-06-21 02:17:51 -04:00
  6de7328fef
• fix cancel test for new button layout
  Liam DeVoe · 2023-06-21 02:15:02 -04:00
  dd4f271158
• use two separate buttons for posting / login
  Liam DeVoe · 2023-06-21 00:58:43 -04:00
  cc764afe3e
• move commitButton.Text update to appropriate method
  Liam DeVoe · 2023-06-21 00:37:54 -04:00
  8460873e61
• Disable beatmap skinning when entering the skin editor
  Dean Herbert · 2023-06-20 19:18:17 +09:00
  d7b486e2ac
• Merge pull request #23973 from peppy/update-framework

  Update framework

  Dean Herbert · 2023-06-20 18:53:55 +09:00
  c815f8cd23