73826 Commits

This Branch

This Branch

All Branches

• Fix results screen not showing local scores on results screen for some beatmap statuses

  Closes https://github.com/ppy/osu/issues/33609.
  
  Case of leftover code that should have been removed.
  
  This condition is still active in the online leaderboards path via
  
  	https://github.com/ppy/osu/blob/4dcc928c7e46e020c62f4d60e7b859ba18c9142f/osu.Game/Online/Leaderboards/LeaderboardManager.cs#L91-L95
  
  Not sure trying to add test coverage is a productive use of time? Will
  do on request though.

  Bartłomiej Dach · 2025-06-10 10:51:30 +02:00
  de57daeb3c
• Merge pull request #33312 from chris-ehmann/fix-drag-delete-bug

  Fix undo/redo being locked up when a MouseUp event occurs while an object is being dragged

  Bartłomiej Dach · 2025-06-09 10:26:01 +02:00
  909440ab7a
• Merge branch 'master' into fix-drag-delete-bug
  Bartłomiej Dach · 2025-06-09 09:17:52 +02:00
  44563c03f0
• Fix up test

  - Use constraints for better assert messages
  - Use `Editor.Undo()` rather than manual input manager synthesizing
    ctrl-z (ctrl-z is not a platform agnostic binding, see macOS)

  Bartłomiej Dach · 2025-06-09 09:16:19 +02:00
  35ff330e85
• Merge pull request #33570 from EVAST9919/selectv2-no-buffers

  Song Select V2: Fix GPU overhead on carousel scroll

  Dean Herbert · 2025-06-09 15:37:50 +09:00
  b323edefc8
• Merge pull request #33564 from tsunyoku/add-touch-device-ssv2

  Song Select V2: Use touch input detector

  Dean Herbert · 2025-06-09 15:31:32 +09:00
  69dc596779
• Remove BufferedContainers from songselectv2
  Andrei Zavatski · 2025-06-08 23:08:09 +03:00
  a03448af7f
• Use touch device detector in song select V2
  tsunyoku · 2025-06-08 14:08:26 +01:00
  be0c43b4ab
• Merge pull request #33545 from nobbele/selectv2-33524

  SongSelectV2: Calculate PP for leaderboard tooltip if missing

  Salman Alshamrani · 2025-06-08 10:35:09 +03:00
  0c479b625c
• Merge branch 'master' into selectv2-33524
  Salman Alshamrani · 2025-06-08 10:05:26 +03:00
  20c2b8d153
• Merge pull request #33553 from Joehuu/fix-ssv2-leaderboard-mods-input

  Fix mods blocking drag and right-click input on leaderboards

  Salman Alshamrani · 2025-06-08 09:48:55 +03:00
  cb8276f714
• Fix mods blocking drag and right-click input on leaderboards
  Joseph Madamba · 2025-06-07 19:10:17 -07:00
  4e97731161
• Move PerformanceStatisticRow into tooltip class
  nobbele · 2025-06-08 00:32:10 +02:00
  a89b7d27ad
• SongSelectV2: Calculate PP for leaderboard tooltip if missing
  nobbele · 2025-06-08 00:27:15 +02:00
  45c8891975
• Merge pull request #33514 from peppy/fix-potential-sets-changed-overhead

  Ensure `beatmapSetsChanged` code doesn't run during gameplay

  Dean Herbert · 2025-06-07 03:15:37 +09:00
  2025.607.1 2025.607.0 cb082da063
• Merge pull request #33509 from Joehuu/fix-loading-spinner-clipping

  Fix loading spinner without a box clipping

  Dean Herbert · 2025-06-07 03:06:36 +09:00
  4fef1e10e3
• Merge branch 'master' into fix-potential-sets-changed-overhead
  Dean Herbert · 2025-06-07 02:30:20 +09:00
  f183496d19
• Merge pull request #33515 from peppy/fix-selection-when-selected

  Fix clicking beatmap header causing leaderboard to refresh

  Dean Herbert · 2025-06-07 02:28:54 +09:00
  bc8d158dde
• Adjust loading spinner to not use masking as all when no box
  Dean Herbert · 2025-06-07 02:19:15 +09:00
  c25396c7d6
• Ensure beatmapSetsChanged code doesn't run during gameplay
  Dean Herbert · 2025-06-07 01:28:49 +09:00
  b3bda6a560
• Merge pull request #33504 from bdach/ssv2-leaderboard-friend-highlighting

  SongSelectV2: Add back highlighting friend scores on the leaderboard

  Dean Herbert · 2025-06-07 00:58:08 +09:00
  c4c0457377
• Fix loading spinner without a box clipping
  Joseph Madamba · 2025-06-06 08:47:32 -07:00
  15be762f71
• Fix clicking beatmap header causing leaderboard to refresh
  Dean Herbert · 2025-06-06 23:30:36 +09:00
  ed2889c983
• Use equality when updated current carousel selection
  Dean Herbert · 2025-06-06 23:20:38 +09:00
  6ab9ee76b7
• Merge pull request #33502 from smoogipoo/fix-simplified-rhythm

  Fix simplified rhythm mod not working on some beatmaps

  Dean Herbert · 2025-06-06 21:48:16 +09:00
  3a1bbf9b39
• Merge pull request #33503 from bdach/rank-change-sample-toggling

  Prevent rank display shown in skin editor toolbox from playing samples

  Dean Herbert · 2025-06-06 21:38:49 +09:00
  99f57d29e3
• SongSelectV2: Add back highlighting friend scores on the leaderboard
  Bartłomiej Dach · 2025-06-06 13:53:32 +02:00
  90084e27e5
• Prevent rank display shown in skin editor toolbox from playing samples

  Closes https://github.com/ppy/osu/issues/33456.

  Bartłomiej Dach · 2025-06-06 13:18:20 +02:00
  e02cd28df6
• Add toggle for rank change sound playback to default rank display

  Because some people don't seem to like it. Defaults to on still.

  Bartłomiej Dach · 2025-06-06 12:51:56 +02:00
  6835d7659d
• Merge pull request #33498 from bdach/ssv2-leaderboard-cut-off

  Fix several issues with leaderboard score display

  Dean Herbert · 2025-06-06 19:43:27 +09:00
  3335b99064
• Fix simplified rhythm mod not working on some beatmaps
  Dan Balasescu · 2025-06-06 19:37:01 +09:00
  558aacfed5
• Refactor slightly
  Dan Balasescu · 2025-06-06 19:37:01 +09:00
  03c3cce761
• Add failing tests
  Dan Balasescu · 2025-06-06 19:37:01 +09:00
  bef07c4b73
• Avoid transform churn due to every frame AccentColour updates
  Dean Herbert · 2025-06-06 19:33:57 +09:00
  37315d589e
• Merge pull request #33497 from Stedoss/ssv2-tag-overflow-song-select-search

  SongSelectV2: Fix `TagsOverflowPopover` not applying tag search to song select

  Bartłomiej Dach · 2025-06-06 11:52:42 +02:00
  0de732082b
• Merge pull request #33499 from bdach/leaderboard-score-tooltip

  Fix leaderboard score display not respecting local timezone & user 12/24hr settings

  Dean Herbert · 2025-06-06 18:49:30 +09:00
  7cfd7499f9
• Fix leaderboard score display not respecting local timezone & user 12/24hr settings

  Closes https://github.com/ppy/osu/issues/33473.
  
  Cross-reference previous implementation:
  
  	https://github.com/ppy/osu/blob/828e8da7726109888aa1a6a41921daad254b75c0/osu.Game/Online/Leaderboards/LeaderboardScoreTooltip.cs#L140-L141

  Bartłomiej Dach · 2025-06-06 11:44:56 +02:00
  7ea9db1b72
• Fix several issues with leaderboard score display

  - Enforces minimum width on accuracy / max combo displays which could
    previously look broken in CJK languages, thus fixing
    https://github.com/ppy/osu/issues/33434. Minimum sizes were chosen to
    accomodate what could be considered reasonably possible with some
    leeway on top.
  
  - Fixes hilariously broken logic that was supposed to highlight perfect
    / FC / max combo scores in green but instead did nothing due to two
    disparate bugs in a single line of code.
  
  - Extends the highlighting logic to also apply to 100% accuracy because
    web does this and I think it's nice.

  Bartłomiej Dach · 2025-06-06 11:25:02 +02:00
  b61688596b
• Merge pull request #33495 from bdach/leaderboard-combo-vs-max-combo

  Fix general confusion in which combo should be read on which gameplay leaderboard

  Dan Balasescu · 2025-06-06 17:53:56 +09:00
  828e8da772
• Fix TagsOverflow song select dependency
  Stedoss · 2025-06-06 09:43:39 +01:00
  9c682cc2ed
• Fix general confusion in which combo should be read on which gameplay leaderboard

  Closes https://github.com/ppy/osu/issues/33455.
  
  The fundamental misunderstanding and source of confusion in
  https://github.com/ppy/osu/pull/33062 is that solo wants to show
  *maximum combo*, and multiplayer wants to show *current combo*, for
  their own, valid reasons. Which is spelled out explicitly in this
  change.

  Bartłomiej Dach · 2025-06-06 10:08:01 +02:00
  a92a659662
• Merge pull request #33491 from bdach/fix-replays

  Fix replays being misrecorded if an action is pressed and released in one update frame

  Dean Herbert · 2025-06-06 16:35:55 +09:00
  c180983393
• Fix replays being misrecorded if an action is pressed and released in one update frame

  Closes https://github.com/ppy/osu/issues/33465 probably.
  
  This reverts the replay frame de-duplication logic to what it was before
  https://github.com/ppy/osu/pull/33148#discussion_r2091549388.
  
  I don't have good reproduction steps. I tried to write a test case for
  this that isn't just "press and release a key in the same frame",
  thinking that maybe there was some loophole in the osu! touch input
  mapper that may produce this situation artificially, but I could not in
  many configurations. So I have to assume that this just *can happen*
  organically.

  Bartłomiej Dach · 2025-06-06 09:10:51 +02:00
  12cc8e38da
• Add failing test
  Bartłomiej Dach · 2025-06-06 09:08:26 +02:00
  f577cea715
• Merge pull request #33488 from bdach/participants-list-flags-broke

  Fix user country flags no longer showing on multiplayer participants list

  Dean Herbert · 2025-06-06 15:47:09 +09:00
  4d704d7018
• Merge pull request #33439 from bdach/mobile-does-not-exist

  Hack around hold-for-right-click mobile thing not allowing to hold to access song select v2 in main menu

  Dean Herbert · 2025-06-06 15:06:24 +09:00
  c2319f419c
• Hack around hold-for-right-click mobile thing not allowing to hold to access song select v2 in main menu

  This is terrible but I sincerely believe that anything else trying to do
  this "properly" would be as terrible if not more.
  
  - You can try to handle touch events in `MainMenu` but then you'd have
    to awkwardly still manually hand them off to mouse handlers of the
    logo / menu button in a weird way for them to do what they're supposed
    to be doing. So any fix here would likely be smeared across `OsuLogo`
    and `MainMenuButton` anyway.
  
  - The logic in
    https://github.com/ppy/osu/blob/278a372a907c22f04fe28289c305ef47d5bcef45/osu.Game/Screens/Menu/MainMenu.cs#L517-L520
    fundamentally doesn't work with raw touch events because it doesn't
    check for active touches (easy part) and because drawables do not
    become "hovered" in the input manager from being touched (hard part)
  
  I'm not willing to spend any more time on this.

  Bartłomiej Dach · 2025-06-06 07:56:22 +02:00
  3931ae3499
• Fix user country flags no longer showing on multiplayer participants list
  Bartłomiej Dach · 2025-06-06 07:42:10 +02:00
  51a758d3f6
• better comment, fix typo in test case
  Chris Ehmann · 2025-06-05 18:28:17 -07:00
  5e3eb70829
• Add comment to explain guard clause
  Chris Ehmann · 2025-06-05 17:50:01 -07:00
  36eea335a4