h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2026-05-21 04:19:53 +08:00
Code Issues Releases Wiki Activity

Merge pull request #33570 from EVAST9919/selectv2-no-buffers

Browse Source 
Song Select V2: Fix GPU overhead on carousel scroll
This commit is contained in:
Dean Herbert
2025-06-09 15:37:50 +09:00
committed by GitHub
Unverified
parent 69dc596779 a03448af7f
commit b323edefc8
2 changed files with 17 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files
osu.Game/Screens/SelectV2/Panel.cs
+16 -23
View File
@@ -120,35 +120,28 @@ namespace osu.Game.Screens.SelectV2
},
Children = new[]
{
new BufferedContainer
backgroundBorder = new Box
{
RelativeSizeAxes = Axes.Both,
Children = new Drawable[]
Colour = Color4.Black,
},
backgroundLayerHorizontalPadding = new Container
{
RelativeSizeAxes = Axes.Both,
Child = new Container
{
backgroundBorder = new Box
RelativeSizeAxes = Axes.Both,
Masking = true,
CornerRadius = corner_radius,
Children = new Drawable[]
{
RelativeSizeAxes = Axes.Both,
Colour = Color4.Black,
},
backgroundLayerHorizontalPadding = new Container
{
RelativeSizeAxes = Axes.Both,
Child = new Container
backgroundGradient = new Box
{
RelativeSizeAxes = Axes.Both,
},
backgroundContainer = new Container
{
RelativeSizeAxes = Axes.Both,
Masking = true,
CornerRadius = corner_radius,
Children = new Drawable[]
{
backgroundGradient = new Box
{
RelativeSizeAxes = Axes.Both,
},
backgroundContainer = new Container
{
RelativeSizeAxes = Axes.Both,
},
}
},
}
},
osu.Game/Screens/SelectV2/PanelSetBackground.cs
+1 -5
View File
@@ -18,7 +18,7 @@ using osuTK.Graphics;
namespace osu.Game.Screens.SelectV2
{
public partial class PanelSetBackground : BufferedContainer
public partial class PanelSetBackground : Container
{
[Resolved]
private BeatmapCarousel? beatmapCarousel { get; set; }
@@ -52,10 +52,6 @@ namespace osu.Game.Screens.SelectV2
}
public PanelSetBackground()
// TODO: for performance reasons we may want this to be true.
// Setting to true will require that the buffered portion is moved to a child such that `FadeIn`/`FadeOut` transforms
// still work.
: base(cachedFrameBuffer: false)
{
RelativeSizeAxes = Axes.Both;
}