1769 Commits

• Repair behavioural change
  Dean Herbert · 2019-10-04 13:32:47 +08:00
  ddef7fa3ba
• Fix key counters appearing negative on intense beatmaps

  When `FrameStabilityContainer` decides it needs multiple updates on the same frame, it ends up with an elapsed time of zero. This was interacting badly with the condition used in `RulesetInputManager` to govern playback direction.
  
  I have changed this to use `Rate` as exposed by the frame stable clock.
  
  - Closes #6198.

  Dean Herbert · 2019-10-03 15:01:54 +08:00
  b28689c774
• Fix CI error
  smoogipoo · 2019-10-01 15:41:09 +09:00
  ce609302ed
• Log the exception that caused to loading of rulesets to fail.
  miterosan · 2019-09-29 19:25:44 +02:00
  9f498d2990
• Fix combo bindings not being bound to nested hitobjects
  smoogipoo · 2019-09-26 17:39:19 +09:00
  45f2bcc440
• Update accent colour on combo index change
  smoogipoo · 2019-09-26 17:13:13 +09:00
  706e884cc0
• Add bindables for IHasComboInformation properties
  smoogipoo · 2019-09-26 16:55:08 +09:00
  bbf0544a8d
• Fix mania scrolling speed not including beatmap slider multipli… (#6236)

  Fix mania scrolling speed not including beatmap slider multiplier
  
  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Dean Herbert · 2019-09-25 22:34:46 +09:00
  7d5544460b
• Add comment + test for slider multiplier
  smoogipoo · 2019-09-25 20:12:01 +09:00
  244627ff10
• Decouple bar line hitobjects from generator

  Introduce an IBarLine interface, which together with generic constraints
  helps decouple BarLineGenerator from the actual hitobject types it
  creates. Thanks to this, all rulesets that want bar lines can provide
  an implementation of IBarLine that also derives from the base hitobject
  class.
  
  This allows DrawableBarLines in taiko and mania to be migrated back to
  DrawableTaikoHitObject and DrawableManiaHitObject base classes
  respectively. This in turn resolves #6215 without code duplication,
  since the missing anchoring application is now done in mania's
  DrawableBarLine through deriving from DrawableManiaHitObject.

  Bartłomiej Dach · 2019-09-25 00:36:27 +02:00
  9323df26a1
• Fix relative beat length not considering slider multiplier
  smoogipoo · 2019-09-24 16:49:42 +09:00
  4abe0473b9
• Fix initial hitobject states not being recomputed correctly
  smoogipoo · 2019-09-24 16:48:39 +09:00
  af0c15a93c
• Fix LifetimeChanged being invoked before lifetime is set
  smoogipoo · 2019-09-24 16:47:34 +09:00
  75cceb9e30
• Bring up-to-date and use IApplicableFailOverride
  Dean Herbert · 2019-09-21 23:30:54 +09:00
  c99b48f934
• Merge branch 'master' into master
  Dean Herbert · 2019-09-21 22:45:05 +09:00
  4c4b71eeec
• Fixed typo

  Changed CreateReourceStore() to CreateResourceStore()

  Vperus · 2019-09-20 19:58:39 +03:00
  ac8fe6045f
• Fix judgement sizes not matching legacy skins (#6145)

  Fix judgement sizes not matching legacy skins

  Dean Herbert · 2019-09-19 18:49:35 +09:00
  0640b2eb35
• Add hit lighting (#6144)

  Add hit lighting
  
  Co-authored-by: Dan Balasescu <smoogipoo@smgi.me>

  Dean Herbert · 2019-09-19 18:49:22 +09:00
  3abcd898a6
• Merge branch 'master' into add-hit-lighting
  Dan Balasescu · 2019-09-19 18:07:29 +09:00
  027d6194f2
• Newline required when xmldocs are involved
  smoogipoo · 2019-09-19 18:00:11 +09:00
  bc9941a990
• Remove whitespace
  smoogipoo · 2019-09-19 17:58:10 +09:00
  65276cd235
• Merge remote-tracking branch 'origin/master' into auto-restart-mod-perfect

  # Conflicts:
  #	osu.Game/Screens/Play/Player.cs

  smoogipoo · 2019-09-19 17:57:04 +09:00
  db24cfbead
• Remove virtual member from ModBlockFail
  smoogipoo · 2019-09-19 17:44:24 +09:00
  da15b900f7
• Fix scaling mode being applied to judgements
  Dean Herbert · 2019-09-19 17:36:32 +09:00
  e6c36a8bc7
• Merge remote-tracking branch 'upstream/master' into fix-judgement-size
  Dean Herbert · 2019-09-19 16:32:37 +09:00
  2cd7c769e1
• Fix duplicate invocation of updateState on load complete
  smoogipoo · 2019-09-19 14:15:06 +09:00
  762adb783a
• Add reference to xmldoc

  Co-Authored-By: Salman Ahmed <slmanarendo1950@gmail.com>

  Dean Herbert · 2019-09-19 02:03:30 +09:00
  2296ea75d7
• Bring other mods up-to-date
  Dean Herbert · 2019-09-19 01:45:42 +09:00
  1150e9fdfb
• Merge remote-tracking branch 'upstream/master' into auto-restart-mod-perfect
  Dean Herbert · 2019-09-19 01:36:29 +09:00
  ff3a7c1d13
• Always update drawable hitobject state on skin change
  Dean Herbert · 2019-09-18 20:19:57 +09:00
  5901a915e7
• Fix judgement sizes not matching skins stable
  Dean Herbert · 2019-09-18 02:56:03 +09:00
  26eca5b1f4
• Add initial implementation of hit lighting

  Requires a supporting skin, like osu!classic for now.

  Dean Herbert · 2019-09-18 02:49:54 +09:00
  ba76f09c99
• Merge branch 'master' into key-counter-fixes
  Dean Herbert · 2019-09-17 22:33:15 +09:00
  38d85e44be
• Change osu!catch key trigger to occur on frame before positional change
  Dean Herbert · 2019-09-13 23:06:35 +09:00
  624e5644a4
• Merge branch 'master' into key-counter-fixes
  Dan Balasescu · 2019-09-13 19:43:33 +09:00
  b10ce0b12d
• Merge branch 'master' into improve-catch-replay-frames
  Dan Balasescu · 2019-09-13 19:23:15 +09:00
  125b3fda6c
• Update InitialLifetimeOffset comment
  Dean Herbert · 2019-09-12 19:30:27 +09:00
  b81b162ee1
• Merge branch 'master' into reset-dho-lifetimes
  Dean Herbert · 2019-09-12 19:29:14 +09:00
  9fc60aeefc
• Move expire to DrawableHitObject
  Dean Herbert · 2019-09-12 19:29:08 +09:00
  f21e47d6d2
• Merge branch 'improve-catch-replay-frames' into key-counter-fixes
  Dean Herbert · 2019-09-12 18:34:00 +09:00
  1dfd104690
• Improve how osu!catch stores and replays key actions
  Dean Herbert · 2019-09-12 18:33:46 +09:00
  acdfeef1dc
• Handle key counter rewinding in a better way

  Use ElapsedFrameTime rather than storing state data

  Dean Herbert · 2019-09-12 15:42:14 +09:00
  0cdf125c1e
• Centralise and share bar line generation code between rulesets
  Dean Herbert · 2019-09-10 13:30:54 +09:00
  af3bb5a2cd
• Move reset call to ctor
  Dean Herbert · 2019-09-09 14:24:17 +09:00
  07fce8397b
• Reset score processor before starting the simulation
  iiSaLMaN · 2019-09-07 18:15:49 +03:00
  be803fa921
• Set Health default value to 1
  iiSaLMaN · 2019-09-07 18:03:04 +03:00
  55b2bc1ed5
• Reset DrawableHitObject lifetimes on state change
  Dean Herbert · 2019-09-07 14:44:44 +09:00
  7f2d14416a
• Fix failing test
  Dean Herbert · 2019-09-06 16:51:30 +09:00
  b89fb5cdf7
• Merge branch 'master' into stop-counting-to-score-after-fail
  Dean Herbert · 2019-09-06 16:12:53 +09:00
  6ce36bd39e
• Merge pull request #6019 from peppy/hit-window-refactor

  Refactor HitWindows for legibility

  Dean Herbert · 2019-09-06 16:10:04 +09:00
  a50284a5eb