Dean Herbert
3862681d94
Change skin.ini boolean parsing to match osu!stable
...
Closes https://github.com/ppy/osu/issues/18579 .
2022-06-06 19:43:09 +09:00
Dean Herbert
44400142e2
Merge pull request #18584 from smoogipoo/fix-spectating-combo
...
Fix combo starting at 0 when spectating
2022-06-06 19:16:47 +09:00
Dean Herbert
734636299e
Merge pull request #18567 from jai-x/update-dayseparator
...
Update `DaySeparator` to use new design throughout
2022-06-06 19:15:43 +09:00
Dean Herbert
a8764b67e1
Add padding and avoid using invalidation (triggers too often when toolbar is being toggled)
2022-06-06 18:28:56 +09:00
Dean Herbert
28c9c61f71
Fix potential null reference in skin editor if target screen is null (during exit)
...
```csharp
[runtime] 2022-06-06 09:24:31 [verbose]: Host execution state changed to
Stopping
[runtime] 2022-06-06 09:24:31 [error]: An unhandled error has occurred.
[runtime] 2022-06-06 09:24:31 [error]: System.NullReferenceException:
Object reference not set to an instance of an object.
[runtime] 2022-06-06 09:24:31 [error]: at
osu.Game.Skinning.Editor.SkinEditorOverlay.setTarget(OsuScreen target)
in
/Users/dean/Projects/osu/osu.Game/Skinning/Editor/SkinEditorOverlay.cs:line
173
[runtime] 2022-06-06 09:24:31 [error]: at
osu.Framework.Threading.ScheduledDelegate.RunTaskInternal()
[runtime] 2022-06-06 09:24:31 [error]: at
osu.Framework.Threading.Scheduler.Update()
[runtime] 2022-06-06 09:24:31 [error]: at
osu.Framework.Graphics.Drawable.UpdateSubTree()
[runtime] 2022-06-06 09:24:31 [error]: at
osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
[runtime] 2022-06-06 09:24:31 [error]: at
osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
[runtime] 2022-06-06 09:24:31 [error]: at
osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
[runtime] 2022-06-06 09:24:31 [error]: at
osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
```
2022-06-06 18:27:54 +09:00
Dean Herbert
003a3de270
Adjust transitions to look better
2022-06-06 18:06:46 +09:00
Dean Herbert
cd0e0fe70f
Fix skin editor not accounting for aspect ratios in base-game sizing logic
2022-06-06 18:02:42 +09:00
Dan Balasescu
4e35ac8d4c
Add test
2022-06-06 18:01:52 +09:00
Dan Balasescu
6351f652a2
Fix combo starting at 0 when spectating
2022-06-06 17:56:25 +09:00
Dean Herbert
8189820bf9
Merge pull request #18547 from smoogipoo/multiplayer-test-clone-room
...
Isolate "server-side" multiplayer rooms in testing
2022-06-06 14:24:10 +09:00
Dean Herbert
7facbc9b28
Merge branch 'master' into multiplayer-test-clone-room
2022-06-06 13:47:16 +09:00
Dean Herbert
6516e92128
Merge pull request #18576 from peppy/update-framework
...
Update framework
2022-06-05 13:45:12 +09:00
Dean Herbert
f1af3205ca
Update framework
2022-06-05 13:15:05 +09:00
Dan Balasescu
b897e1464f
Merge pull request #18462 from frenzibyte/fix-timeline-zooming
...
Fix timeline objects disappearing prematurely on wide-screens
2022-06-05 11:49:44 +09:00
Jai Sharma
c0aaeff2b3
Update DaySeparator to use new design throughout
...
Moves `DaySeparator` chat component to it's own file and update it to
match new chat design. Makes use of several virtual attributes that can
be overridden to update spacing and layout in other usage contexts.
Remove redundant usage of `ChatOverlayDaySeparator`, since the new
design is now part of the base class.
Create `StandAloneDaySeparator` to use in `StandAloneChatDisplay` which
overrides attributes to match correct spacing and layout for its design.
Ensure that `DrawableChannel.CreateDaySeparator` returns type of
`DaySeparator` instead of `Drawable`.
2022-06-04 18:02:14 +01:00
Salman Ahmed
47d2bd2a8d
Merge pull request #18566 from peppy/update-framework
...
Update framework
2022-06-04 16:56:59 +03:00
Dean Herbert
8ad588d927
Update framework
2022-06-04 22:12:53 +09:00
Dean Herbert
4d0c3fcee2
Merge pull request #18556 from frenzibyte/default-legacy-spinner-approach-circle
...
Fix spinner approach circle displaying on default legacy skin
2022-06-04 15:30:34 +09:00
Dean Herbert
462e5365d1
Merge pull request #18561 from Joehuu/icon-pill-tooltips
...
Add tooltips to beatmap card icon pills
2022-06-04 15:06:50 +09:00
Joseph Madamba
30cf6bffad
Add tooltips to beatmap card icon pills
2022-06-03 21:41:52 -07:00
Dean Herbert
2a8a4ba4c0
Merge pull request #18560 from Joehuu/fix-some-localisations
...
Fix some incorrect web localisation usages and casing
2022-06-04 13:37:05 +09:00
Joseph Madamba
4b54fedd88
Add back hide common string using new ToSentence() extension method
2022-06-03 20:09:20 -07:00
Joseph Madamba
58c8562cb0
Fix username placeholder text casing and missing localisation on registration form
2022-06-03 20:09:20 -07:00
Joseph Madamba
b342aad24a
Revert/fix some incorrectly used sorting localisation
2022-06-03 19:56:33 -07:00
Salman Ahmed
fe96e15b1b
Update spinner approach circle to handle LegacySkinTransformer
2022-06-04 01:15:39 +03:00
Salman Ahmed
045e044637
Expose LegacySkinTransformer's underlying skin for pattern-matching
2022-06-04 01:14:42 +03:00
Dean Herbert
45451178df
Merge pull request #18548 from nekodex/sfx-consistency
...
SFX consistency pass
2022-06-04 02:00:18 +09:00
Dean Herbert
d0e098fbcd
Allow using arrow keys to navigate volume controls when controls are already visible
2022-06-04 01:04:46 +09:00
Dean Herbert
712253a35b
Make non-localisable strings in VolumeMeter verbatim
2022-06-04 01:04:23 +09:00
Dean Herbert
64616a6d73
Remove completely gimped implementation in VolumeMeter
2022-06-04 00:18:54 +09:00
Jamie Taylor
396a566a0e
Add some randomness to click samples
2022-06-03 22:33:11 +09:00
Jamie Taylor
6115275bc2
Use 'default' sampleset for toolbar and repurpose 'toolbar' select sample temporarily
2022-06-03 22:33:06 +09:00
Jamie Taylor
2878bb592f
Use more appropriate sounds for certain components
2022-06-03 22:32:12 +09:00
Jamie Taylor
365819865e
Remove 'submit' sample usages
2022-06-03 22:31:35 +09:00
Dean Herbert
f68df1518f
Merge branch 'master' into multiplayer-test-clone-room
2022-06-03 22:29:39 +09:00
Dan Balasescu
fcf51a6f51
Merge pull request #18530 from peppy/add-cloen-button
...
Change text on timing group add button when it is going to clone instead
2022-06-03 22:23:04 +09:00
Dan Balasescu
725a4dd9f4
Merge pull request #18545 from peppy/web-request-canceled-fix
...
Fix web requests potentially being performed after cancelled
2022-06-03 21:32:24 +09:00
Dan Balasescu
3df4d1b0e6
Fix incorrect HasPassword value for returned rooms
2022-06-03 21:17:48 +09:00
Dan Balasescu
06ac3c1ad3
Make MultiplayerClient update CurrentPlaylistItem
2022-06-03 21:17:23 +09:00
Dan Balasescu
41ff170b60
Fix playlist IDs not being returned
2022-06-03 21:12:09 +09:00
Dan Balasescu
77289c7224
Fix inability to serialise-then-deserialise playlist items
2022-06-03 20:36:12 +09:00
Dan Balasescu
68337df643
Fix tests by creating a score processor
2022-06-03 20:04:20 +09:00
Dan Balasescu
5245995689
Use IsNotNull() helper
2022-06-03 19:50:21 +09:00
Dan Balasescu
646f5f0f33
Isolate "server-side" multiplayer rooms in testing
2022-06-03 19:17:34 +09:00
Dan Balasescu
2aabcf51ae
Update framework again
2022-06-03 18:47:19 +09:00
Dean Herbert
538ad1bc98
Merge pull request #18532 from smoogipoo/mania-diffcalc-max-combo
...
Populate MaxCombo difficulty attribute for osu!mania
2022-06-03 18:19:25 +09:00
Dean Herbert
514dffd49a
Merge pull request #18544 from frenzibyte/macos-borderless-default-mode
...
Change default window mode to "Borderless" on macOS
2022-06-03 18:18:53 +09:00
Dean Herbert
debd1a59b0
Merge pull request #18539 from frenzibyte/repeating-button-behaviour
...
Share repeat implementation in `TimingAdjustButton` for timeline zoom buttons
2022-06-03 18:18:23 +09:00
Dan Balasescu
1c738e22ae
Merge pull request #18523 from peppy/tap-button
...
Add tap for BPM button
2022-06-03 18:11:10 +09:00
Dan Balasescu
b3d4cf0b29
Merge pull request #18546 from peppy/sentry-only-our-errors
...
Don't report sentry errors from builds targetting a different server
2022-06-03 17:31:16 +09:00
