Salman Alshamrani
c1ac27d658
Fix failing tests
...
- Caches `DrawableRuleset` in editor compose screen for mania playfield adjustment container (because it's used to wrap the blueprint container as well)
- Fixes `ManiaModWithPlayfieldCover` performing a no-longer-correct direct cast with a naive-but-working approach.
2025-01-12 22:56:40 -05:00
Salman Alshamrani
f121b03a78
Merge branch 'master' into mobile-fix-mania
2025-01-12 02:00:49 -05:00
Salman Alshamrani
a241d1f503
Fix DrawableManiaRuleset
not cached as itself in subtypes
...
i.e. editor mania ruleset
2025-01-04 02:36:06 -05:00
Salman Alshamrani
e5713e5239
Fix triangles judgement mispositioned on a miss
...
Similar to mania's `ArgonJudgementPiece`.
2024-12-31 21:31:54 -05:00
Salman Alshamrani
64e557d00f
Simplify portrait check
2024-12-31 20:01:21 -05:00
Salman Alshamrani
bea61d2483
Replace ManiaTouchInputArea
with touchable columns
2024-12-31 12:28:04 -05:00
Salman Alshamrani
1e08b3dbda
Make mania judgements relative to the hit target position
...
This improves display in portrait screen, where the stage is scaled up.
2024-12-31 12:25:58 -05:00
Salman Alshamrani
9d08bc2b50
Improve osu!mania gameplay scaling on portrait orientation
2024-12-31 12:25:58 -05:00
Bartłomiej Dach
0d16ed028b
Add setters to hitobject coordinate interfaces
2024-12-27 11:01:47 +01:00
Bartłomiej Dach
1057aa867f
Merge pull request #30984 from smoogipoo/fix-mania-spinner-conversion
...
Fix "spinner" conversion for mania-specific beatmaps
2024-12-19 15:30:10 +01:00
Dan Balasescu
d597232c2a
Fix incorrect lastPattern
value
...
In particular, mania-specific beatmaps that normally go via the
"passthrough" generator should not adjust the stored pattern value.
The "spinner" generator, which was previously intended to be used for
non-mania-specific beatmaps, is now valid even for mania-specific
beatmaps, and uses this value.
In other words, another way of writing this would be:
```csharp
if (conversion is SpinnerPatternGenerator || conversion is
PassThroughPatternGenerator) ? lastPattern : newPattern;
```
2024-12-13 16:08:12 +09:00
Dan Balasescu
ec8b320e21
Handle non-legacy types
...
Also used in some tests (e.g. beatmaps containing `HitCircle`s).
2024-12-06 17:47:49 +09:00
Dan Balasescu
e703d9e814
NRT refactorings + rename generators to match usage
...
In particular, "EndTimeObject" is no longer correct - it's strictly used
for spinners and not holds.
2024-12-06 17:16:04 +09:00
Dan Balasescu
1bbf32d567
Add some explanatory comments
...
In particular, the spinner one is the most relevant to this batch of
changes.
2024-12-06 16:40:29 +09:00
Dan Balasescu
e8728abc00
Rename LegacyPatternGenerator
to stop naming conflicts
2024-12-06 16:40:29 +09:00
Dan Balasescu
e65f8ba7a0
Simplify implementation
2024-12-06 16:40:29 +09:00
Dan Balasescu
8e1bd98386
Split out + rename PassThroughPatternGenerator
...
Better symbolises the intent of this generator which is to convert
hitobjects in their most simple forms - anything with an end time
converts to a hold or otherwise converts to a normal note.
2024-12-06 16:40:29 +09:00
Dan Balasescu
8b456e1379
Always convert mania spinners
...
A big part of these changes is refactoring, which is somewhat necessary
because it was previously implemented as two separate pathways which
in-fact need to be joined at the hip when handling spinners.
I've chosen to use `IHasLegacyHitObjectType` here because there's no
other flag that allows us to tell `ConvertHold` apart from
`ConvertSpinner`.
2024-12-06 16:40:28 +09:00
Huo Yaoyuan
d92ea910cf
Merge branch 'master' into netcore-analyzer
2024-12-05 17:18:56 +08:00
Dean Herbert
5b2558cec2
Merge pull request #28473 from bdach/beatmap-info-purge
...
Move unnecessary properties from `BeatmapInfo` / realm to `IBeatmap`
2024-12-02 16:19:12 +09:00
Huo Yaoyuan
fa3c95c296
Merge branch 'master'
2024-11-30 01:07:08 +08:00
Huo Yaoyuan
fced254594
Enable selected rules for usage
2024-11-28 22:33:03 +08:00
Bartłomiej Dach
98a156ae2d
Merge pull request #30874 from peppy/chat-order
...
Sort public chat channels alphabetically, private channels based on recent messages
2024-11-28 12:46:14 +01:00
Bartłomiej Dach
cf905d0f5c
Merge branch 'master' into beatmap-info-purge
2024-11-26 10:21:16 +01:00
Dean Herbert
c844d65a81
Use TryGetValue
wherever possible
...
Rider says so.
2024-11-22 19:11:16 +09:00
Dean Herbert
086a34f5c0
Merge branch 'master' into beatmap-info-purge
2024-11-22 18:47:32 +09:00
Dean Herbert
29757ffdf2
Allow setting osu!mania scroll speed to single decimal precision
...
Addresses https://github.com/ppy/osu/discussions/30663 .
2024-11-22 17:36:28 +09:00
Dean Herbert
6a0ac4c29e
Merge pull request #29640 from smoogipoo/mania-imperfect-ss
...
Make mania award SS even if there are GREAT judgements
2024-11-22 14:42:32 +09:00
Bartłomiej Dach
15a8cfe685
Fix mania notes disappearing on seek to their end time
2024-11-18 14:37:09 +01:00
Bartłomiej Dach
4ae13cfd60
Remove unused resolved property
2024-11-15 10:58:06 +01:00
Bartłomiej Dach
e5480f8346
Adjust appearance of placement blueprints to be closer to previous
2024-11-15 10:37:56 +01:00
Bartłomiej Dach
0c4c9bd237
Fix incorrect selection hold note blueprint display when upscroll active
2024-11-15 10:27:07 +01:00
Bartłomiej Dach
4c147327df
Fix code quality
2024-11-15 10:19:34 +01:00
Bartłomiej Dach
33b2197e5e
Merge branch 'master' into improve-mania-selection-blueprints
2024-11-15 10:19:08 +01:00
Dean Herbert
54ca705680
Merge branch 'master' into hs-toggle2
2024-11-13 19:15:00 +09:00
Dan Balasescu
60d45d44bb
Merge pull request #30536 from stanriders/add-diffcalc-helpers
...
Add `DifficultyCalculationUtils`
2024-11-13 17:49:40 +09:00
Bartłomiej Dach
8458756402
Adjust appearance a third time
2024-11-12 14:26:13 +01:00
Salman Alshamrani
3268008d21
Fix stage line alignment in mania not matching stable
2024-11-12 04:07:27 -05:00
StanR
78c97d2cd7
Add DifficultyCalculationUtils
2024-11-07 20:36:00 +05:00
Bartłomiej Dach
dba065302d
Adjust appearance once more
2024-11-07 13:41:41 +01:00
Bartłomiej Dach
e058f98bad
Remove unused field
2024-11-07 09:36:28 +01:00
Bartłomiej Dach
98ae45d763
Adjust appearance further in response to feedback
2024-11-07 09:18:57 +01:00
Bartłomiej Dach
aede94a3f3
Use box variant of selection always
2024-11-07 08:41:38 +01:00
Bartłomiej Dach
dfda5e1b66
Improve visual appearance of mania selection blueprints
2024-11-05 15:25:29 +01:00
Bartłomiej Dach
f2afec23f9
Merge branch 'master' into hs-toggle2
2024-11-01 18:44:33 +01:00
Bartłomiej Dach
59655a1830
Fix flip operations sometimes not preserving selection
...
Closes https://github.com/ppy/osu/issues/30250 .
2024-10-14 14:50:01 +02:00
Bartłomiej Dach
1af464d5ae
Bump difficulty calculator versions
...
In order for the new star difficulty to be shown to users on the next
release.
catch's difficulty calculator version is not bumped because the only
catch change pending deploy is https://github.com/ppy/osu/pull/28353 and
that affects performance points only.
2024-10-07 15:38:41 +02:00
Bartłomiej Dach
7816c41b94
Only transfer difficulty slider values on commit
...
Closes https://github.com/ppy/osu/issues/30112 .
2024-10-04 14:08:46 +02:00
Bartłomiej Dach
99eb26b7d5
Redo the layout of sections based on discord feedback
...
See
https://discord.com/channels/188630481301012481/188630652340404224/1291358770064130140
and everything after.
2024-10-03 13:53:21 +02:00
Bartłomiej Dach
b15608343b
Replace setup screen controls with new "form" controls
2024-10-03 11:49:03 +02:00