1
0
mirror of https://github.com/ppy/osu.git synced 2025-02-20 10:25:30 +08:00

Add some explanatory comments

In particular, the spinner one is the most relevant to this batch of
changes.
This commit is contained in:
Dan Balasescu 2024-12-06 16:27:31 +09:00
parent e8728abc00
commit 1bbf32d567
No known key found for this signature in database

View File

@ -152,6 +152,7 @@ namespace osu.Game.Rulesets.Mania.Beatmaps
}
else
{
// Note: The density is used during the pattern generator constructor, and intentionally computed first.
computeDensity(startTime);
conversion = new HitObjectPatternGenerator(Random, original, beatmap, TotalColumns, lastPattern, lastTime, lastPosition, density, lastStair);
recordNote(startTime, position);
@ -182,6 +183,8 @@ namespace osu.Game.Rulesets.Mania.Beatmaps
break;
case LegacyHitObjectType.Spinner:
// Note: Some older mania-specific beatmaps can have spinners that are converted rather than passed through.
// Newer beatmaps will usually use the "hold" hitobject type below.
conversion = new EndTimeObjectPatternGenerator(Random, original, beatmap, TotalColumns, lastPattern);
recordNote(endTime, new Vector2(256, 192));
computeDensity(endTime);