1
0
mirror of https://github.com/ppy/osu.git synced 2024-12-16 17:02:55 +08:00
Commit Graph

509 Commits

Author SHA1 Message Date
Bartłomiej Dach
7c0550d251
Merge pull request #29500 from frenzibyte/fix-pausing-for-the-millionth-time
Fix oversight in osu! pause input handling
2024-08-27 10:04:47 +02:00
Dan Balasescu
180c4a0248
Fix tests by removing assumption 2024-08-20 14:20:52 +09:00
TheOmyNomy
67de43213c Apply current cursor expansion scale to trail parts 2024-08-19 23:21:06 +10:00
Salman Ahmed
2a49167aa0 Remove flac whatever 2024-08-19 15:44:17 +09:00
Salman Ahmed
86d0079dcd Rewrite the fix to look less hacky and direct to the point 2024-08-19 15:43:59 +09:00
Salman Ahmed
62dec1cd78 Fix oversight in input blocking from osu! gameplay resume 2024-08-19 14:14:40 +09:00
Dan Balasescu
20b890570e
Replace try-finally with return
Try-finally has a small overhead that's unnecessary in this case given
how small the code block is.
2024-08-05 13:28:42 +09:00
Dean Herbert
419d5a76ce
Merge branch 'master' into fix-pause-in-osu-again 2024-08-05 12:00:21 +09:00
Caiyi Shyu
4b5c163d93 remove unnecessary LayoutValue 2024-08-02 17:45:05 +08:00
Caiyi Shyu
06af8cb952 interpolate parts in local space to avoid broken trails 2024-08-02 16:23:37 +08:00
Salman Ahmed
dc9f6a07cb Fix inspections 2024-08-02 11:16:32 +03:00
Salman Ahmed
f5a3eb5612 Add comment 2024-08-02 11:01:40 +03:00
Salman Ahmed
5368a43633 Fix clicking resume overlay hitting underlying hit circle 2024-08-02 10:22:01 +03:00
Salman Ahmed
eafc0f79af Fix clicking resume cursor not triggering a gameplay press in osu! 2024-08-02 10:21:44 +03:00
Dan Balasescu
ff7815c3c5
Submit vertices in local space to avoid cross-thread access 2024-07-30 20:13:00 +09:00
Caiyi Shyu
e564b1dc9e Fix cursor trail alignment issue with UI panels
- Convert cursor trail coordinates to local space before storing.
- Apply necessary transformations to align with other UI elements.
- Ensure cursor trail remains connected during UI panel movements.
2024-07-25 18:23:01 +08:00
Salman Ahmed
e539670df1 Add explanatory note 2024-07-19 19:19:36 +03:00
Salman Ahmed
4f6c7fe7c3 Schedule resume operation by one frame to ensure the triggered key down event does not cause a gameplay press 2024-07-19 18:48:35 +03:00
Dean Herbert
5350945340
Update HasFlag usages 2024-07-03 00:19:04 +09:00
Dean Herbert
55b80f70f6
Change "playfield" skin layer to respect shifting playfield border in osu! ruleset 2024-06-28 18:12:20 +09:00
Bartłomiej Dach
1b00d0181a
Fix playfield border size not updating in editor on circle size change 2024-06-17 09:36:01 +02:00
Bartłomiej Dach
97003b3679
Account for osu! circle radius when drawing playfield border
Addresses https://github.com/ppy/osu/discussions/13167.
2024-06-17 09:08:43 +02:00
Dan Balasescu
f6a59bee9a
Use delayed resume overlay for autopilot 2024-05-30 19:17:18 +09:00
Dean Herbert
d0b1ebff5a
Revert "Temporary rollback of framework / SDL3"
This reverts commit d7d569cf4e.
2024-05-22 16:29:39 +08:00
Dean Herbert
d7d569cf4e
Temporary rollback of framework / SDL3 2024-05-21 14:36:16 +08:00
Dan Balasescu
3b8b56cbcb
Apply required changes after framework masking updates 2024-05-09 20:18:53 +09:00
Bartłomiej Dach
e5e345712e
Fix resume overlay not appearing after pausing inside window but outside of actual playfield area
Related to https://github.com/ppy/osu/discussions/27871 (although does
not actually fix the issue with the pause button, _if_ it is to be
considered an issue - the problem there is that the gameplay cursor
gets hidden, so the other condition in the modified check takes over).

Regressed in
bce3bd55e5.
Reasoning for breakage is silent change in `this` when moving the
`Contains()` check (`DrawableRuleset` will encompass screen bounds,
while `OsuResumeOverlay` is only as big as the actual playfield).
2024-04-16 13:45:09 +02:00
Bartłomiej Dach
f9873968a5
Apply NRT in OsuResumeOverlay 2024-04-16 13:39:06 +02:00
Dan Balasescu
0beaa8e8c5
Merge branch 'master' into tcm-resume 2024-03-14 12:22:46 +09:00
Dan Balasescu
e0f1f70b82
Adjust NRT to prevent future issues
This way, it will yet at us if the setter is ever moved out of the ctor.
2024-03-11 15:52:40 +09:00
Dean Herbert
091425db30
Fix nullability hint 2024-03-11 14:43:58 +08:00
Dean Herbert
f3d154a995
Add inline comment explaining optimisation 2024-03-11 11:28:15 +08:00
Dean Herbert
2be6d1f1c6
Apply NRT to OsuPlayfield 2024-03-11 11:26:03 +08:00
Andrei Zavatski
6ff4b1d7e3 Don't update SubTreeMasking in OsuPlayfield 2024-03-10 15:42:03 +03:00
Dan Balasescu
bce3bd55e5
Fix catch by moving cursor-specific handling local 2024-03-04 16:08:17 +09:00
Salman Ahmed
ce903987e7 Fix cursor ripples being added on release positions in replays 2024-02-17 00:53:53 +03:00
Dean Herbert
c45daa373e
Fix cursor scale animation not matching stable on classic skins 2024-01-16 17:15:25 +09:00
Bartłomiej Dach
71d0543213
Merge pull request #26545 from frenzibyte/fix-resume-cursor-transition-abused
Fix pop-in scale transition in resume overlay affecting input area
2024-01-15 20:06:16 +01:00
Dean Herbert
23815b2045
Merge pull request #26547 from bdach/cursor-ripple-pool-wrong
Fix cursor ripple pool not loading pooled drawables ahead of time
2024-01-15 22:56:50 +09:00
Bartłomiej Dach
399fc8195a
Fix cursor ripple pool not loading pooled drawables ahead of time
Increment the counter over at
https://github.com/ppy/osu-framework/pull/6136.
2024-01-15 13:22:22 +01:00
Dean Herbert
6b844ed8b6
Split out judgement pooling concepts from OsuPlayfield for reuse 2024-01-15 20:50:09 +09:00
Salman Ahmed
13517869f6 Apply scale transitions in resume overlay cursor to local container 2024-01-15 14:03:23 +03:00
rushiiMachine
c087578e01
Force minimum cursor size for OsuResumeOverlay
On cursor sizes below 0.3x it becomes exceedingly difficult to quickly locate and then accurately click the resume cursor on the pause overlay as it could as big as a handful of pixels. This clamps the minimum cursor size to 1x for the resume overlay, which is way more comfortable and more closely resembles stable.
2023-12-26 10:07:21 -08:00
Dean Herbert
fcf47267fd
Revert change to OsuHitWindows and move logic local to pooling initialisation 2023-12-21 00:48:46 +09:00
Dean Herbert
9b383e3276
Add support for showing tick misses 2023-12-20 20:23:19 +09:00
Dan Balasescu
b56a78c6ec
Adjust with framework changes 2023-12-04 08:51:21 +09:00
Dean Herbert
c00a1d948a
Merge branch 'master' into better-touch-settings 2023-11-07 23:21:59 +09:00
Dean Herbert
7bedf7cf16
Move static method to end of file 2023-11-07 21:08:49 +09:00
Dean Herbert
38c9a98e67
Add failing test coverage 2023-11-07 19:54:21 +09:00
Susko3
05d9418718 Rename setting to TouchDisableGameplayTaps for better visibility when searching 2023-11-07 00:13:46 +01:00