Bartłomiej Dach
d218e7d935
Remove manual romanisation handling in PlaylistItem
2021-11-02 21:42:02 +01:00
Bartłomiej Dach
ed00cd9fc5
Remove simple localisable .ToString() calls
2021-11-02 21:42:02 +01:00
Bartłomiej Dach
11de924704
Use LocalisableStrings where possible to leverage localisable text flow
2021-11-02 21:42:02 +01:00
Bartłomiej Dach
ad98ab0a26
Fix drawable room playlist item assuming single sprite text
2021-11-02 21:42:02 +01:00
Bartłomiej Dach
b95c95527e
Accept LocalisableStrings in LinkFlowContainer
2021-11-02 21:42:01 +01:00
Bartłomiej Dach
98367fc482
Update usages of GetLocalised{-> Bindable}String
2021-11-02 21:42:01 +01:00
Dean Herbert
47914c49ba
Fix missed null consideration
2021-11-03 04:54:36 +09:00
Dean Herbert
fe9b8f3274
Merge pull request #15432 from peppy/fix-beatmap-availability-potentially-wrong
...
Fix multiplayer potentially getting incorrect beatmap availability state after changing beatmaps
2021-11-03 04:54:22 +09:00
Dean Herbert
5ea901da2e
Merge pull request #15429 from peppy/fix-beatmap-download-notifications
...
Fix beatmap download notifications not showing beatmap name correctly
2021-11-03 04:36:59 +09:00
Dean Herbert
a97e5fbd89
Merge pull request #15431 from peppy/fix-unauth-api-requests
...
Fix unauthenticated API requests no longer working
2021-11-03 04:35:48 +09:00
Dean Herbert
85037dfb70
Fix multiplayer potentially getting incorrect beatmap availability state after changing beatmaps
2021-11-03 04:32:21 +09:00
Dean Herbert
cb5c6e1924
Merge pull request #15427 from peppy/fix-multiplayer-panel-star-rating-display
...
Fix multiplayer panels not correctly showing star rating
2021-11-03 04:21:01 +09:00
Dean Herbert
f67f42dc5b
Merge pull request #15430 from bdach/fix-multi-submission
...
Fix multiplayer score submission not working
2021-11-03 04:10:23 +09:00
Dean Herbert
d4ff50d4b1
Merge pull request #15425 from peppy/fix-leaderboard-crash
...
Fix crash when attempting to view global leaderboards
2021-11-03 04:10:04 +09:00
Dean Herbert
51e92e1b2d
Check for null/empty instead
2021-11-03 04:09:31 +09:00
Dean Herbert
8d0b32981f
Fix unauthenticated API requests no longer working
2021-11-03 03:30:15 +09:00
Dean Herbert
392559ae3e
Fix beatmap download notifications not showing beatmap name correctly
2021-11-03 03:23:41 +09:00
Bartłomiej Dach
c028275d6c
Fix multiplayer score submission not working
2021-11-02 19:16:44 +01:00
Dean Herbert
6efd3d3115
Don't perform background difficulty calculation for multiplayer panels
...
There are cases these are shown in a long list. They shouldn't be
running calculations.
2021-11-03 03:12:52 +09:00
Dean Herbert
08b0ffad50
Fix incorrect check for local beatmap in BeatmapDifficultyCache
...
This was correct in the WIP branch I have, but pulled out alone (where
usages of `ToBeatmapInfo` still exist) it was not enough.
2021-11-03 03:12:52 +09:00
Dean Herbert
c85a4dca28
Fix crash when attempting to view global leaderboards
2021-11-03 02:47:33 +09:00
Dan Balasescu
fd46a1773f
Merge pull request #14845 from emu1337/aim-refactor-base
...
osu! Difficulty Aim Overhaul: base change
2021-11-03 01:35:55 +09:00
smoogipoo
133218ecbb
Document special MovementDistance for sliders, ensure always has a value
2021-11-03 01:04:07 +09:00
smoogipoo
c3a31a019b
Merge branch 'master' into aim-refactor-base
2021-11-03 00:32:51 +09:00
smoogipoo
b0d9c0eca3
Refactor variables for readability in angle calculations
2021-11-03 00:16:33 +09:00
Dean Herbert
73b09f3b3d
Merge pull request #15409 from smoogipoo/fix-pp-counter-rate-adjust
...
Fix PP counter showing incorrect values with rate adjustment mods
2021-11-03 00:06:13 +09:00
smoogipoo
93c03b9d37
Refactor documentation around velocity calculations
2021-11-03 00:04:19 +09:00
smoogipoo
7e0629774b
Rename variables for readability
...
In particular, "last" vs "prev" can get confusing because they mean the
same thing.
2021-11-02 23:51:10 +09:00
smoogipoo
5454de7ae8
Refactor xmldocs
2021-11-02 23:47:20 +09:00
smoogipoo
be8a1f60c0
Apply styling changes
2021-11-02 23:33:51 +09:00
smoogipoo
5486ca084e
Resolve tests
2021-11-02 23:32:58 +09:00
Dan Balasescu
e61f2970b4
Merge pull request #15410 from peppy/fix-multiplayer-room-participants
...
Fix multiplayer room participants display not updating as new users join/leave
2021-11-02 17:55:16 +09:00
smoogipoo
81aaef719f
Add xmldoc to CalculateTimed()
2021-11-02 17:55:00 +09:00
smoogipoo
168a7a588b
Add xmldoc to ctor also
2021-11-02 17:19:14 +09:00
smoogipoo
efba7a9c4d
Missed hyphen
2021-11-02 17:18:02 +09:00
smoogipoo
0cdd2898fe
Expose non-adjusted time from CalculateTimed()
2021-11-02 17:17:14 +09:00
Dean Herbert
135df0e190
Avoid adding null users to RecentParticipants
2021-11-02 17:13:37 +09:00
Dean Herbert
1bfa1365a0
Rename "null user" tests to better explain purpose
2021-11-02 17:13:37 +09:00
Dean Herbert
b0bd39fc49
Fix multiplayer room participants display not updating as new users join/leave
...
Can add tests on request, but not sure the code around this area is here
to stay permanently. Should be pretty low risk.
- Closes https://github.com/ppy/osu/issues/14788 .
2021-11-02 17:13:37 +09:00
Dean Herbert
e472656b37
Add test coverage of room participants updating on room join
2021-11-02 17:13:37 +09:00
smoogipoo
eaeee80a26
Fix PP counter showing incorrect values with rate adjustment mods
2021-11-02 16:55:20 +09:00
Dan Balasescu
6f941a8916
Merge pull request #15405 from peppy/legacy-decoder-default-section
...
Default legacy decoder to `General` section, rather than none
2021-11-02 15:42:25 +09:00
smoogipoo
1e9211c00b
Use explicit type
2021-11-02 15:41:25 +09:00
Dan Balasescu
a2f6b816ff
Merge pull request #15406 from peppy/fix-skin-hashing-circular-reference
...
Avoid any potential infinite loops when re-writing `skin.ini` files
2021-11-02 15:39:33 +09:00
Dan Balasescu
e56811783b
Merge pull request #15407 from peppy/remove-trailing-exclamations-from-autoplay
...
Remove trailing exclamation marks from autoplay character names
2021-11-02 15:21:46 +09:00
Dean Herbert
9b705460db
Remove trailing exclamation marks from autoplay character names
...
As mentioned in
https://github.com/ppy/osu/discussions/15401#discussioncomment-1573839 .
2021-11-02 14:53:58 +09:00
Dan Balasescu
3f31cb39c0
Merge pull request #15279 from Flux3on/spinner-judgement-fix
...
Fix spinner judgements on old beatmaps get incorrectly stacked
2021-11-02 14:46:15 +09:00
Dean Herbert
5d784b2ef8
Perform a consistency check by decoding the newly written skin.ini during ComputeHash
...
As this has regressed twice now, let's play it safe and bail rather than
stack overflowing. Note that as all the underlying issues that could
trigger this have been fixed, no additional tests have been added. To
test, comment out `SkinManager.cs` line 228-229 to cause a failure. The
new logic will kick in and show a log output message, but all tests will
still (correctly) pass.
2021-11-02 14:11:25 +09:00
Dean Herbert
2e66ab453d
Always write automated changes to skin metadata at the end of the file
...
Apart from being cleaner (and allowing removal at the point of export,
if that is ever requires), this also gives us a better guarantee that
the metadata is going to take effect.
By writing the `[General]` section ourselves, we avoid any issues that
may be present from a user constructing the file (incorrectly)
themselves, such as multiple `Title:` entries or a malformed `[General]`
marker.
The main goal is to ensure that the name is updated to what we expect it
to be.
2021-11-02 14:11:25 +09:00
Dean Herbert
d4be6fc797
Add test coverage of skin with missing section header
2021-11-02 14:05:14 +09:00
