1070 Commits

• Merge branch 'master' into aim-refactor-base
  smoogipoo · 2021-11-03 00:32:51 +09:00
  c3a31a019b
• Merge branch 'master' into spinner-judgement-fix
  Dean Herbert · 2021-10-29 12:13:42 +09:00
  e0cdcdd7a4
• merge in ppy/master
  Xexxar · 2021-10-28 14:47:28 +00:00
  9f5a7526ed
• Merge pull request #15255 from goodtrailer/node-samples-ilist

  Change IHasRepeats.NodeSamples to IList from List

  Dean Herbert · 2021-10-28 14:24:26 +09:00
  5c7623e68e
• Apply batch fixing of built-in types using var
  Dean Herbert · 2021-10-27 13:04:41 +09:00
  6944151486
• updated bdach's suggestion
  Roxie Wattz · 2021-10-25 17:15:43 -07:00
  cf7fbf4b63
• Reverted special case code changes

  As requested by @frenzibyte

  Roxie is Flux3on · 2021-10-24 18:16:14 -07:00
  0c57453f4d
• Added an override for StackedEndPosition

  This ensures the spinner's hit judgement will always be centre instead of in the top left corner.

  Roxie is Flux3on · 2021-10-24 18:15:40 -07:00
  a8e3d0bacc
• Made StackedEndPosition virtual

  Done to allow overriding in the other object classes.

  Roxie is Flux3on · 2021-10-24 18:14:37 -07:00
  861cd4852a
• Cut amount of code down for the spinner judgement fix
  Roxie is Flux3on · 2021-10-24 15:29:47 -07:00
  386910ca2e
• Corrected spinner judgement positions.

  For some reason, spinner judgements would stack from the top left in an awkward fashion. This patch ensures that the judgement location will always be in the centre of the screen.

  Roxie is Flux3on · 2021-10-24 15:28:38 -07:00
  b8308b9715
• Fix a couple of new layout inspections introduces in Rider 2021.3 EAP5
  Dean Herbert · 2021-10-24 23:51:49 +09:00
  99d01f2162
• Change IHasRepeats.NodeSamples to IList from List
  goodtrailer · 2021-10-23 01:59:07 -07:00
  4440b9ca11
• Merge branch 'master' into aim-refactor-base
  smoogipoo · 2021-10-17 12:00:39 +09:00
  30eb08d394
• updated to newly refactored aim
  Xexxar · 2021-10-13 15:41:24 +00:00
  200149c9d7
• Merge branch 'master' into no-more-difficulty-control-points-info
  smoogipoo · 2021-10-08 18:41:17 +09:00
  bc37cb6f43
• Convert usages of BeatmapDifficulty to IBeatmapDifficultyInfo
  Dean Herbert · 2021-10-01 16:55:50 +09:00
  a92d499d7a
• Merge branch 'master' into no-more-difficulty-control-points-info
  Dean Herbert · 2021-09-28 13:53:56 +09:00
  46bafb6252
• Merge branch 'master' into correct-reverse-arrow-depth
  Bartłomiej Dach · 2021-09-20 22:32:28 +02:00
  c911332540
• Fix slider parts not reproxying after first hitobject freed
  Bartłomiej Dach · 2021-09-18 16:27:30 +02:00
  79438c19a4
• Merge branch 'master' into update-framework
  Dean Herbert · 2021-09-16 22:49:02 +09:00
  fde7c88999
• Fix legacy approach circles accepting alpha
  smoogipoo · 2021-09-16 19:35:15 +09:00
  d8f27633a4
• Update with keybinding changes
  smoogipoo · 2021-09-16 18:26:12 +09:00
  f9d5abff8a
• Clone control points when copying to HitObjects
  Dean Herbert · 2021-09-10 14:36:39 +09:00
  714f55b6bc
• Move approach rate to EffectControlPoint
  Dean Herbert · 2021-09-03 16:58:16 +09:00
  a3d9ab1e2e
• Update usages of DifficultyPointAt
  Dean Herbert · 2021-09-03 16:58:16 +09:00
  071c56e90b
• Fix osu! judgements getting scaled twice over different durations
  Dean Herbert · 2021-09-02 16:31:43 +09:00
  b907c2f4f6
• Fix repeat arrows being hidden beneath head circles in legacy skins

  Aims to make minimal changes to `DrawableSlider` itself. I'm not super
  happy about the slider ball being moved above the head circle, but it
  *is* what people are used to so no one except for me is going to
  complain.
  
  Supersedes and closes https://github.com/ppy/osu/pull/14561.

  Dean Herbert · 2021-09-01 19:41:49 +09:00
  738ce0f689
• Merge branch 'master' into avoid-default-skin-judgement-transform-overhead
  Dan Balasescu · 2021-08-27 10:02:40 +09:00
  f0296e5d12
• Merge branch 'master' into path-control-point-bindable-removal
  Dan Balasescu · 2021-08-27 09:37:37 +09:00
  a28bc9f6b2
• Remove redundant default value
  Salman Ahmed · 2021-08-26 08:18:58 +03:00
  b9ea984c36
• Avoid expensive text spacing transforms for now
  Dean Herbert · 2021-08-26 13:15:27 +09:00
  8cfb3d456b
• Avoid unnecessary unbind operations when constructing FollowPointLifetimeEntry
  Dean Herbert · 2021-08-26 12:35:31 +09:00
  69064c1938
• Remove bindable usage in PathControlPoint

  This is quite a breaking change, but I think it is beneficial due to the large amount of usage of this class.
  
  I originally intended just to remove the allocations of the two delegates handling the `Changed` flow internally, but as nothing was really using the bindables for anything more than a general "point has changed" case, this felt like a better direction.

  Dean Herbert · 2021-08-26 12:33:53 +09:00
  6dcd9427ac
• Add ComboIndexWithOffsetsBindable and bind similar to ComboIndexBindable
  Salman Ahmed · 2021-07-22 16:40:33 +03:00
  523c154f15
• Rename property, reword xmldoc and improve readability of update code
  Dean Herbert · 2021-07-21 17:32:56 +09:00
  399c3b0be8
• Revert making ComboOffsets legacy and define BeatmapSkinComboIndex instead
  Salman Ahmed · 2021-07-20 14:15:43 +03:00
  9d92b795fa
• Merge branch 'refactor-combo-colour-retrieval' into legacy-beatmap-combo-offset
  Salman Ahmed · 2021-07-20 10:11:52 +03:00
  554652b033
• Implement IHasApproachCircle in DrawableHitCircle as well
  Salman Ahmed · 2021-06-21 07:35:07 +03:00
  68e28f4903
• Replace spinner approach circle proxying logic with hooking up to OnSkinChange in mod
  Salman Ahmed · 2021-06-19 20:06:28 +03:00
  c04b09520d
• Move spinner approach circle to its own SkinnableDrawable
  Salman Ahmed · 2021-06-18 20:33:50 +03:00
  843c8bd7a4
• Merge branch 'master' into legacy-spinner-approach-circle
  Salman Ahmed · 2021-06-18 19:50:52 +03:00
  f7b5341663
• Hide spinner approach circle in "Hidden" mod
  Salman Ahmed · 2021-06-18 06:23:54 +03:00
  c9458fd9ce
• Fix approach circle fade not running early on an early user hit

  Regressed in https://github.com/ppy/osu/pull/12153.
  Closes https://github.com/ppy/osu/issues/13531.

  Dean Herbert · 2021-06-17 15:09:05 +09:00
  a46f730a69
• Merge branch 'master' into fix-skin-sample-lookup
  Dean Herbert · 2021-06-08 17:37:36 +09:00
  6017ef3825
• Fix slider repeat arrow not updating rotation immediately while paused in editor

  A bit of a local solution, but not sure there's a better way to handle
  this.
  
  Closes #13342.

  Dean Herbert · 2021-06-07 15:58:43 +09:00
  277eb9fa6e
• Merge branch 'legacy-skin-default-fallback' into fix-skin-sample-lookup
  Dean Herbert · 2021-06-07 12:01:19 +09:00
  d26c9a66c2
• Bring back scheduling of follow point update
  ekrctb · 2021-06-04 18:41:02 +09:00
  d7da66d876
• Remove one TODO

  It can be removed because pooled drawables are always ready, and `FollowPointConnection` is also ready when applied.

  ekrctb · 2021-06-04 17:09:59 +09:00
  0098ac2760
• Resolve nullable inspection, enable nullable for FollowPointLifetimeEntry
  ekrctb · 2021-06-04 17:09:59 +09:00
  bc892086fe