1
0
mirror of https://github.com/ppy/osu.git synced 2024-11-18 03:52:55 +08:00
Commit Graph

53860 Commits

Author SHA1 Message Date
Salman Ahmed
ce48984bda
Merge pull request #19419 from andy840119/remove-nullable-disable-in-the-mods-for-taiko-ruleset
Remove nullable disable annotation in mods for taiko ruleset.
2022-07-28 09:32:35 +03:00
Salman Ahmed
1f13d89205
Merge branch 'master' into remove-nullable-disable-in-the-mods-for-taiko-ruleset 2022-07-28 09:01:50 +03:00
Salman Ahmed
61bdcab651
Merge pull request #19418 from andy840119/remove-nullable-disable-in-the-mods-for-mania-ruleset
Remove nullable disable annotation in mods for mania ruleset.
2022-07-28 08:57:12 +03:00
Salman Ahmed
c74ffea236
Merge branch 'master' into remove-nullable-disable-in-the-mods-for-mania-ruleset 2022-07-28 08:21:23 +03:00
Dean Herbert
4332b409be
Merge pull request #19410 from novialriptide/add-notif-externalbutton
Add Toast notification to ExternalLinkButton's context menu
2022-07-28 13:43:14 +09:00
Dean Herbert
aa65b73f19
Merge branch 'master' into add-notif-externalbutton 2022-07-28 12:17:36 +09:00
Dean Herbert
8da499fb0f Add proper test coverage 2022-07-28 12:16:21 +09:00
Dean Herbert
f44a4c8652 Reorder file content to match expectations 2022-07-28 12:13:47 +09:00
Dean Herbert
f01c397220 Apply nullability 2022-07-28 12:12:46 +09:00
Andrew Hong
f097064eea Adjust to reviews 2022-07-27 21:52:38 -04:00
Andrew Hong
ac39d3a142 "Copied URL" -> "URL copied" 2022-07-27 21:52:28 -04:00
Dean Herbert
706b6e01ff
Merge pull request #19426 from LeNitrous/move-legacy-combo-counter
Move `LegacyComboCounter` to `osu.Game.Skinning`
2022-07-28 10:43:42 +09:00
Nitrous
9088caa377
move LegacyComboCounter to osu.Game.Skinning 2022-07-28 08:36:26 +08:00
andy840119
3510c16566 Remove nullable disable annotation in the Taiko test case. 2022-07-27 22:31:48 +08:00
為什麼
860e9d42ff Mark the property as nullable and add some assert check. 2022-07-27 22:31:48 +08:00
為什麼
d766052be4 Remove nullable disable annotation in the Taiko ruleset. 2022-07-27 22:28:13 +08:00
andy840119
9f79e80d8b Remove nullable disable annotation in the Mania test case. 2022-07-27 22:24:14 +08:00
為什麼
4120c20968 Remove the nullable disable annotation in the Mania ruleset. 2022-07-27 22:24:02 +08:00
Dan Balasescu
19852572b7
Merge pull request #19411 from peppy/fix-score-transfer-test-failure
Fix potential test failure if scores are added to the beatmap which is subsequently removed
2022-07-27 17:39:57 +09:00
Dean Herbert
494486ad09 Fix potential test failure if scores are added to the beatmap which is subsequently removed 2022-07-27 16:27:10 +09:00
Andrew Hong
2d4655f61e Add Toast Notification to Copy URL 2022-07-27 02:25:40 -04:00
Dean Herbert
c30e8047ab
Merge pull request #19375 from novialriptide/contextmenu-external-beatmap
Add ContextMenu to beatmap external link
2022-07-26 19:06:10 +09:00
Dan Balasescu
b47f674ddb
Merge pull request #19400 from peppy/button-select-allow-more
Always allow selecting the top-most button using the select binding
2022-07-26 18:49:42 +09:00
Dan Balasescu
bc60552694
Merge pull request #19402 from peppy/debugger-attached-audio-warning-disable
Don't show audio playback issue notification if debugger is attached
2022-07-26 18:49:33 +09:00
Dan Balasescu
8f7dff5c2c
Merge pull request #19378 from peppy/beatmap-update-test
Add separate beatmap update flow to handle edge cases better
2022-07-26 18:49:20 +09:00
Dean Herbert
e782590b3c Don't show audio playback issue notification if debugger is attached
I've hit this countless times recently when debugging during the startup
procedure.
2022-07-26 18:20:46 +09:00
Dean Herbert
9173271900 Fix new update pathway not actually being used 2022-07-26 17:58:09 +09:00
Dean Herbert
1539fa704b Always allow selecting the top-most button using the select binding 2022-07-26 17:46:23 +09:00
Dean Herbert
6ff44ed2c6
Merge pull request #19399 from frenzibyte/carousel-order-stability
Maintain sort stability by using carousel item ID as a fallback
2022-07-26 17:33:30 +09:00
Dean Herbert
7f75184a01
Merge branch 'master' into beatmap-update-test 2022-07-26 17:27:36 +09:00
Dean Herbert
ee694c1257 Add test coverage of no online ID scenario 2022-07-26 17:27:23 +09:00
Andrew Hong
003aec86ae Rearrange sizeaxes 2022-07-26 04:27:22 -04:00
Dean Herbert
1221cb1a42 Add comprehensive test coverage of update scenarios 2022-07-26 17:22:52 +09:00
Andrew Hong
aaf6ec05bb Remove notification upon copy 2022-07-26 04:19:54 -04:00
Salman Ahmed
f90604d873
Merge pull request #19249 from andy840119/remove-nullable-disable-in-the-mods-for-catch-ruleset
Remove nullable disable annotation in mods for catch ruleset.
2022-07-26 11:10:41 +03:00
Dean Herbert
4c22b55ce3 Fix incorrect handling if an update is processed with no changes 2022-07-26 17:00:28 +09:00
andy
88db835e76
Merge branch 'master' into remove-nullable-disable-in-the-mods-for-catch-ruleset 2022-07-26 15:37:30 +08:00
Dan Balasescu
28e81b7c32
Merge pull request #19392 from peppy/fix-test-leftovers
Avoid leaving left-over files after test run completes
2022-07-26 16:33:14 +09:00
Dean Herbert
846291d203 Refactor new tests to not suck as much as the old importer tests 2022-07-26 16:33:00 +09:00
Dan Balasescu
412d42b907
Merge pull request #19393 from peppy/fix-statistics-panel
Avoid potential realm fetch after disposal in `StatisticsPanel`
2022-07-26 16:32:59 +09:00
Salman Ahmed
91ffa7007f Improve existing test coverage to cover order changes from other sort modes 2022-07-26 10:24:51 +03:00
Salman Ahmed
a4f6f2b9eb Make item ID comparer static 2022-07-26 09:55:37 +03:00
Dean Herbert
9939866f7d Revert one more missed change 2022-07-26 15:54:10 +09:00
Dean Herbert
8370ca9765 Add ImportAsUpdate method to IModelImporter to avoid otehr changes 2022-07-26 15:49:04 +09:00
Salman Ahmed
693ac8750c Remove remaining uses of "child" terminology in non-drawable components 2022-07-26 09:43:47 +03:00
Salman Ahmed
d7ef4170be Maintain sort stability by using carousel item ID as fallback 2022-07-26 09:40:41 +03:00
Dean Herbert
4efe09e7c2
Merge pull request #19377 from frenzibyte/fix-timeline-tests
Fix intermittent timeline zoom test failures
2022-07-26 15:18:35 +09:00
Dan Balasescu
5345e431cc
Merge pull request #19389 from peppy/cursor-with-touch
Add ability to make cursor show even during touch input
2022-07-26 15:13:55 +09:00
Dean Herbert
99bdf41717 Avoid potential realm fetch after disposal in StatisticsPanel
As seen at https://github.com/ppy/osu/runs/7513799859?check_suite_focus=true.
2022-07-26 15:12:23 +09:00
Dean Herbert
ac553d22ea Fix left over resource file which isn't actually imported 2022-07-26 15:08:18 +09:00