49887 Commits

This Branch

This Branch

All Branches

• Merge pull request #17403 from peppy/editor-exit-harsh-blocking

  Disallow exiting the editor without saving (unless explicitly confirming)

  Dan Balasescu · 2022-03-23 07:45:31 +09:00
  cda46ec8a3
• Merge branch 'master' into editor-exit-harsh-blocking
  Dan Balasescu · 2022-03-23 07:06:25 +09:00
  8591630e5c
• Merge pull request #17384 from peppy/hold-to-discard-changes

  Add hold-to-confirm flow for discarding editor changes

  Dan Balasescu · 2022-03-23 07:05:56 +09:00
  d84865ff76
• Fix unprotected access to potentially-null DI'd dialog overlay
  Bartłomiej Dach · 2022-03-22 22:10:05 +01:00
  51a1721bc9
• Remove unused local variable
  Bartłomiej Dach · 2022-03-22 22:00:24 +01:00
  f3aad77239
• Remove unused using directive
  Bartłomiej Dach · 2022-03-22 22:00:05 +01:00
  a38bafab91
• Merge branch 'master' into hold-to-discard-changes
  Bartłomiej Dach · 2022-03-22 20:37:43 +01:00
  8647bebdca
• Merge pull request #17386 from peppy/skin-editor-eat-input

  Fix keyboard controls not working to adjust skin settings

  Bartłomiej Dach · 2022-03-22 19:52:01 +01:00
  2f01129322
• Merge branch 'master' into skin-editor-eat-input
  Bartłomiej Dach · 2022-03-22 19:22:48 +01:00
  8192fb47fe
• Merge pull request #17406 from mcpower/vscode-recommended-extensions

  Add C# extension to recommended VS Code extensions

  Dean Herbert · 2022-03-22 19:18:05 +09:00
  6e55d7df02
• Add C# extension to recommended VS Code extensions

  The [official C# extension] is maintained by Microsoft and enables
  IDE-like support for C# in VS Code.
  
  If a user opens this repository in VS Code, they will be prompted to
  install it if they haven't already installed it. After installation, the
  extension will also prompt the user to install the .NET SDK if it's not
  found.
  
  [official C# extension]: https://marketplace.visualstudio.com/items?itemName=ms-dotnettools.csharp

  mcpower · 2022-03-22 20:33:27 +11:00
  5631726164
• Disallow exiting the editor without saving (unless explicitly confirming)
  Dean Herbert · 2022-03-22 15:42:56 +09:00
  61ddf1e6cf
• Revert editor exit behaviour to exit without changes for now
  Dean Herbert · 2022-03-22 14:46:57 +09:00
  f95bd89166
• Merge pull request #17401 from peppy/update-date-added-on-use-existing

  Fix beatmap date added not being updated on reimporting a soft deleted beatmap

  Dan Balasescu · 2022-03-22 14:41:07 +09:00
  056e568ffb
• Remove unnecessary equality check in skin editor construction path
  Dean Herbert · 2022-03-22 14:35:13 +09:00
  fb7f9a81db
• Fix beatmap date added not being updated on reimporting a soft deleted beatmap

  Addresses concerns raised in https://github.com/ppy/osu/discussions/17399.

  Dean Herbert · 2022-03-22 14:10:36 +09:00
  0fcb3bdba9
• Merge pull request #17356 from apollo-dw/strict-tracking

  Implement "Strict Tracking" mod in osu!

  Dan Balasescu · 2022-03-22 07:32:36 +09:00
  36772ec652
• Merge pull request #17359 from frenzibyte/fix-score-panel-max-combo

  Improve method of retrieving beatmap maximum combo for results score panels

  Dan Balasescu · 2022-03-22 06:28:30 +09:00
  aea03ca21d
• Remove unnecessary schedule
  Dean Herbert · 2022-03-21 23:54:47 +09:00
  9a2691c1bc
• Remove no longer valid comments
  Salman Ahmed · 2022-03-21 14:06:53 +03:00
  33acc5d720
• Remove unused using directive
  Salman Ahmed · 2022-03-21 14:06:36 +03:00
  058fbbbe6c
• Merge pull request #17387 from peppy/fix-follow-point-looping
  Salman Ahmed · 2022-03-21 13:55:17 +03:00
  5184a84478
• Fix follow point animations not looping

  Because they do in stable. I don't know why but let's go with it.
  
  Resolves issue reported in https://github.com/ppy/osu/discussions/17072.

  Dean Herbert · 2022-03-21 18:29:13 +09:00
  e4b2242719
• Update editor exit-without-safe tests to account for hold behaviour
  Dean Herbert · 2022-03-21 17:52:54 +09:00
  ed66f86ac6
• Remove unused const in SkinEditorOverlay
  Dean Herbert · 2022-03-21 17:33:56 +09:00
  2a696783af
• Convert SkinEditorOverlay to an OverlayContainer to allow it to block input
  Dean Herbert · 2022-03-21 17:33:56 +09:00
  2f18c512cd
• Add test coverage of skin editor settings slider not working via keyboard adjustments
  Dean Herbert · 2022-03-21 17:33:56 +09:00
  3643f879e4
• Add the ability to override the user setting for hold-to-confirm containers

  Sometimes the user is not right.

  Dean Herbert · 2022-03-21 16:07:27 +09:00
  36868dbdb4
• Change button types on editor exit dialog to match purpose

  Addresses https://github.com/ppy/osu/discussions/17363.

  Dean Herbert · 2022-03-21 16:06:59 +09:00
  d811a70f4b
• Add DangerousButton for use in popup dialogs
  Dean Herbert · 2022-03-21 16:06:45 +09:00
  b42081dd9b
• Merge pull request #17252 from jai-x/new-chat-channel-control

  Implement `ChannelListItem` for new chat design

  Dean Herbert · 2022-03-21 15:41:00 +09:00
  31570d3114
• Fix close button animation not being applied correct on mouse down due to conflicting scales
  Dean Herbert · 2022-03-21 14:41:57 +09:00
  3bb01fd595
• Also add fade to ChannelItem selected box
  Dean Herbert · 2022-03-21 14:41:42 +09:00
  7ca3beb7cc
• Remove space between '#' and channel name

  This was in flyte's design (he was following discord) but doesn't feel
  too correct when it's not aligned with anything else. We can revisit
  this if/when we have better glyphs to represent channel types.

  Dean Herbert · 2022-03-21 14:36:56 +09:00
  428e439f40
• Add slight animation when highlighting an unread channel
  Dean Herbert · 2022-03-21 14:34:54 +09:00
  16caf2d30b
• Add step to TestSceneChannelListItem to actually select an item
  Dean Herbert · 2022-03-21 14:33:50 +09:00
  5104e4db21
• Merge pull request #17379 from peppy/fix-skin-editor-player-overlays
  Salman Ahmed · 2022-03-21 08:32:08 +03:00
  72c8ce7885
• Add animation when mention pill appears (or a new message arrives)
  Dean Herbert · 2022-03-21 14:31:51 +09:00
  692362131e
• Add slight fade when hovering ChannelListItems
  Dean Herbert · 2022-03-21 14:28:14 +09:00
  11b050b66b
• Remove box surrounding close button
  Dean Herbert · 2022-03-21 14:25:29 +09:00
  9eda2f2df1
• Rename renaming button/pill classes
  Dean Herbert · 2022-03-21 14:15:22 +09:00
  f922a6b556
• Merge branch 'master' into new-chat-channel-control
  Dean Herbert · 2022-03-21 14:14:02 +09:00
  812343b410
• Fix loading player via skin editor still allowing changing current audio track

  `PlayerLoader` is required in the sequence to get the game into the
  correct state for gameplay right now. Applying ths simplest fix here.
  
  Closes https://github.com/ppy/osu/issues/17351.

  Dean Herbert · 2022-03-21 13:49:56 +09:00
  355b0fa314
• Merge pull request #17315 from hwabis/queue-list-counter
  Salman Ahmed · 2022-03-21 05:28:33 +03:00
  6fbeea78dd
• Merge branch 'master' into queue-list-counter
  Salman Ahmed · 2022-03-21 05:01:09 +03:00
  5c1e11c153
• Revert OsuTabItem Text to protected, update tab count test
  hwabis · 2022-03-20 21:37:02 -04:00
  06136b2247
• make test name clearer
  hwabis · 2022-03-20 16:28:05 -04:00
  63b6686384
• add queue tab count test
  hwabis · 2022-03-20 16:24:41 -04:00
  8fbdd06895
• Nest specific object classes within the mod
  apollo-dw · 2022-03-20 15:56:41 +00:00
  d3742a91a8
• Remove slider tick judgement flag
  apollo-dw · 2022-03-20 15:41:46 +00:00
  35e2e6a4e7