Dan Balasescu
cd806711f8
Merge pull request #16761 from peppy/more-dialog-overlay-wait
...
Wait for `DialogOverlay` load in more tests
2022-02-03 16:01:32 +09:00
Dean Herbert
6355ac6663
Wait for DialogOverlay load in more tests
...
Apparently the previous fix was not enough as this can still be seen
failing
(https://github.com/ppy/osu/runs/5046718623?check_suite_focus=true ).
This change is copying from what other tests use seemingly reliably,
such as `TestScenePerformFromScreen`)
2022-02-03 15:10:08 +09:00
Dean Herbert
867586f7f5
Merge pull request #16758 from smoogipoo/fix-incomplete-requests-offline
...
Fix API requests not completing when offline
2022-02-03 14:34:24 +09:00
Dean Herbert
a69c7a9de6
Split exceptions back out to give better messaging
2022-02-03 14:09:27 +09:00
Dean Herbert
62fa915193
Standardise exception messages for local-user-logged-out flows
2022-02-03 13:58:55 +09:00
Dan Balasescu
d9a43b4c4c
Fix API requests not completing when offline
2022-02-03 13:16:54 +09:00
Dean Herbert
2731d8e3c2
Merge pull request #16701 from LeNitrous/mod-alternate-osu
...
Add "Alternate" mod for osu! ruleset
2022-02-03 10:41:23 +09:00
Dean Herbert
be9df2ca11
Merge pull request #5774 from MaxOhn/aimassist-mod
...
Add "Aim Assist" mod
2022-02-03 10:40:43 +09:00
Dean Herbert
9bca597a8a
Merge pull request #16751 from bdach/flashlight-decimals-display
2022-02-03 10:34:09 +09:00
Bartłomiej Dach
82f9ad63f5
Fix flashlight size multiplier printing with too many decimal digits
2022-02-02 20:41:25 +01:00
Bartłomiej Dach
fb353d5d45
Merge branch 'master' into aimassist-mod
2022-02-02 19:37:34 +01:00
Bartłomiej Dach
7463744407
Fix osu! autoplay-like mods not declaring incompatibility with AimAssist
2022-02-02 19:17:33 +01:00
Dean Herbert
3a5099cf06
Merge pull request #16748 from frenzibyte/explicit-diffadjust-keyboard-step
...
Use `0.1` keyboard step for "Difficulty Adjust" sliders
2022-02-03 00:22:23 +09:00
Salman Ahmed
074a691635
Set keyboard step to 0.1 for difficulty adjust sliders
2022-02-02 17:43:08 +03:00
Dean Herbert
f777347aaf
Merge pull request #16742 from smoogipoo/fix-multi-swap-mod-crash
...
Fix crash when selecting non-osu! ruleset mods as freemod
2022-02-02 19:14:10 +09:00
Dan Balasescu
b5fb3b7dae
Fix crash when selecting swap mod as freemod
2022-02-02 18:42:22 +09:00
Dan Balasescu
db0f3b7f5e
Merge pull request #16738 from peppy/fix-ruleset-incorrectly-loading
...
Fix rulesets potentially being marked `Available` even when methods are missing
2022-02-02 18:03:04 +09:00
Dean Herbert
6260c5fc13
Merge pull request #16739 from nekodex/cursor-tap
...
Add cursor 'tap' audio feedback
2022-02-02 17:02:33 +09:00
Dean Herbert
cb31ce812c
Merge branch 'master' into cursor-tap
2022-02-02 16:34:34 +09:00
Dean Herbert
4758de226b
Update resources
2022-02-02 16:27:59 +09:00
Dean Herbert
6e41a6e704
Tidy up code into a presentable state
2022-02-02 16:27:16 +09:00
Dean Herbert
2e46404fe5
Remove spinner support for now
2022-02-02 16:26:00 +09:00
Dean Herbert
987aa5a21c
Add testing of different strengths
2022-02-02 16:26:00 +09:00
Dean Herbert
f07502ac5f
Use simple damp easing rather than transforms
2022-02-02 16:15:06 +09:00
Dean Herbert
334ed2c9c4
Fix sliders moving before they are actually hit
2022-02-02 15:36:09 +09:00
Dean Herbert
6b31e7e9db
Merge branch 'master' into aimassist-mod
2022-02-02 15:18:48 +09:00
Dean Herbert
104256a054
Add test coverage
2022-02-02 15:18:44 +09:00
Dean Herbert
e7d72f1823
Revert recent changes
2022-02-02 15:18:44 +09:00
Dean Herbert
0c5da9370a
Fix rulesets potentially being marked Available even when methods are missing
...
Came up when running the game after the recent breaking changes
(https://github.com/ppy/osu/pull/16722 ), where two template rulesets I
had loaded were erroring on startup but still being marked as available,
allowing them to crash the game on attempting to initiate relpay logic.
These cases are already handled for first-time ruleset loading via the
`GetTypes()` enumeration in `RulesetStore.addRuleset`, but when
consistency checking already present rulesets the only runtime
validation being done was `ruleset.CreateInstance()`, which does not
handle missing types or methods.
2022-02-02 14:52:01 +09:00
Jamie Taylor
6e60e68b80
Change from click to mousedown+mouseup and only play when cursor is visible
2022-02-02 14:44:06 +09:00
Dean Herbert
a2affefb0a
Avoid checking gameplay clock time in Update method
2022-02-02 14:33:17 +09:00
Dean Herbert
c7a192cc5f
Only handle LeftButton and RightButton actions
...
There are definitely going to be other actions used in the future, which
would immediately cause this mod to fail. Limiting handling to
left/right buttons only is the correct way forward.
2022-02-02 14:04:12 +09:00
Dean Herbert
fed63abd83
Sanitise interceptor logic to now require two separate check paths
2022-02-02 14:02:48 +09:00
Dean Herbert
0036d0e26d
Move alternate mod to "conversion" category
2022-02-02 13:58:13 +09:00
Dean Herbert
6d962e7925
Merge pull request #16726 from dekrain/leaderboard-score-tooltip
...
Add basic tooltip for leaderboard scores
2022-02-02 13:56:45 +09:00
Dean Herbert
4b646709c1
Merge pull request #16658 from Spooghetti420/no-long-notes-mod
...
Add "Hold Off" mod (no long notes)
2022-02-02 13:35:44 +09:00
Dean Herbert
ddc8094a75
Update description
2022-02-02 13:34:23 +09:00
Dean Herbert
d065e32ca1
Fix crash due to MatchLeaderboardScores not having populated rulesets
2022-02-02 13:23:49 +09:00
Dean Herbert
35b7653290
Revert mod flow changes and add visual test coverage showing an overflow case
2022-02-02 09:13:19 +09:00
Dean Herbert
6033c89e7b
Merge pull request #16734 from bdach/war-on-unused-params
...
Fix several cases of unused constructor and method parameters
2022-02-02 07:40:58 +09:00
Bartłomiej Dach
3674ed15ce
Remove unused game host parameter
...
No longer used since eeccf836ec
2022-02-01 21:53:21 +01:00
Bartłomiej Dach
b978010b48
Remove unused allowMissing parameter in audio file check test
...
No longer used since 7f95400f46
2022-02-01 21:53:21 +01:00
Bartłomiej Dach
7cdf63c654
Remove unused FindProvider() methods
...
No longer needed since 39f99bf785
2022-02-01 21:53:21 +01:00
Bartłomiej Dach
e4028b8fc1
Remove index ctor param from ColumnHitObjectArea
...
No longer used since 5692cecaa4
2022-02-01 21:49:52 +01:00
Bartłomiej Dach
e042f29ee3
Remove skin ctor param from LegacyCatchComboCounter
...
No longer used since 004798d61d
2022-02-01 21:49:52 +01:00
Bartłomiej Dach
75101b1105
Remove unused ruleset ctor params from test beatmap model managers
...
No longer used since 00e3af3366
2022-02-01 21:49:41 +01:00
Bartłomiej Dach
994fb966b6
Remove Host ctor param from SkinModelManager
...
No longer used since 29d074bdb8
2022-02-01 21:37:19 +01:00
Bartłomiej Dach
07d09b3520
Remove unused parameter from createGameplayComponents()
...
No longer used since 136843c8e4
2022-02-01 21:35:41 +01:00
Bartłomiej Dach
a94702b3ae
Remove unused parameters in LegacyComboCounter
...
No longer used since 9bb8a43bce
2022-02-01 21:35:41 +01:00
Bartłomiej Dach
1fa2bf5d69
Remove unused parameter from createColourBars()
...
No longer used since b61aa660c6
2022-02-01 21:35:40 +01:00
