4185 Commits

• Fix pause overlay hiding input from ruleset input manager

  If a key is pressed while the pause overlay is visible, the ruleset input manager will not see it, therefore if the user resumes while the key is held then releases the key, the ruleset input manager will not receive the key up event.

  Salman Ahmed · 2024-07-19 18:48:35 +03:00
  818b60a3d8
• Add extensive test cases for correct input handling while paused in osu! & non-osu!
  Salman Ahmed · 2024-07-19 18:48:35 +03:00
  d7651ef387
• Fix break overlay progress bar becoming a pancake near end of break
  Dean Herbert · 2024-07-10 19:28:37 +09:00
  75344f9c5c
• Update HasFlag usages
  Dean Herbert · 2024-07-03 00:19:04 +09:00
  5350945340
• Adjust calls to GetContainingInputManager()
  Bartłomiej Dach · 2024-06-18 07:41:19 +02:00
  659505f711
• Merge pull request #28480 from bdach/storyboard-pass-fail-show

  Implement toggling visibility of pass and fail storyboard layers

  Dean Herbert · 2024-06-16 11:08:00 +09:00
  15fbad0097
• Inline enabled setting
  Dean Herbert · 2024-06-15 17:34:04 +08:00
  ff2d721029
• Set to enable or disable at load time
  Shiumano · 2024-06-14 21:43:17 +09:00
  6c82f1de9b
• Implement toggling visibility of pass and fail storyboard layers

  Closes https://github.com/ppy/osu/issues/6842.
  
  This is a rather barebones implementation, just to get this in place
  somehow at least. The logic is simple - 50% health or above shows pass
  layer, anything below shows fail layer.
  
  This does not match stable logic all across the board because I have
  no idea how to package that. Stable defines "passing" in like fifty
  ways:
  
  - in mania it's >80% HP
    (https://github.com/peppy/osu-stable-reference/blob/bb57924c1552adbed11ee3d96cdcde47cf96f2b6/osu!/GameModes/Play/Rulesets/Mania/RulesetMania.cs#L333-L336)
  - in taiko it's >80% *accuracy*
    (https://github.com/peppy/osu-stable-reference/blob/bb57924c1552adbed11ee3d96cdcde47cf96f2b6/osu!/GameModes/Play/Rulesets/Taiko/RulesetTaiko.cs#L486-L492)
  - there's also the part where "geki additions" will unconditionally set
    passing state
    (https://github.com/peppy/osu-stable-reference/blob/bb57924c1552adbed11ee3d96cdcde47cf96f2b6/osu!/GameModes/Play/Player.cs#L3561-L3564)
  - and also the part where at the end of the map, the final passing state
    is determined by checking whether the user passed more sections than
    failed
    (https://github.com/peppy/osu-stable-reference/blob/bb57924c1552adbed11ee3d96cdcde47cf96f2b6/osu!/GameModes/Play/Player.cs#L3320)
  
  The biggest issues of these are probably the first two, and they can
  *probably* be fixed, but would require a new member on `Ruleset` and I'm
  not sure how to make one look, so I'm not doing that at this time
  pending collection of ideas on how to do that.

  Bartłomiej Dach · 2024-06-14 13:59:02 +02:00
  67ca7e4135
• fix accuracy counter separating whole and fraction parts with wireframes off
  ColdVolcano · 2024-06-11 02:20:14 -06:00
  4048a4bdfb
• Merge branch 'master' into add-rank-display
  Bartłomiej Dach · 2024-06-07 09:33:03 +02:00
  4cd1ccc4d4
• Fix xmldoc reference
  Bartłomiej Dach · 2024-05-27 08:26:00 +02:00
  bdfce4b9da
• Fix cinema mod not hiding playfield skin layer
  Dean Herbert · 2024-05-27 14:52:28 +09:00
  11c3d11db9
• Revert "Temporary rollback of framework / SDL3"

  This reverts commit d7d569cf4e.

  Dean Herbert · 2024-05-22 16:29:39 +08:00
  d0b1ebff5a
• Temporary rollback of framework / SDL3
  Dean Herbert · 2024-05-21 14:36:16 +08:00
  d7d569cf4e
• Continue loading even when osu! logo is being dragged at loading screen

  Closes https://github.com/ppy/osu/issues/28130.

  Dean Herbert · 2024-05-14 23:54:07 +08:00
  cff865b556
• Few cleanups
  Salman Ahmed · 2024-05-10 06:55:02 +03:00
  6ddf8f8498
• Fix ModDisplay expanding on load with "always contracted/expanded" modes

  This is especially visible when reloading `SongSelectFooterV2` while multiple mods are already selected. The mods will appear expanded then contract.

  Salman Ahmed · 2024-05-10 06:48:18 +03:00
  49692e168e
• Add simple implementation for extended mods display in new footer design
  Salman Ahmed · 2024-05-10 02:20:48 +03:00
  6b91b4abf4
• Use existing AutomaticallyDownloadMissingBeatmaps localisation on solo spectator screen
  Joseph Madamba · 2024-05-05 14:41:48 -07:00
  1665c5e0e1
• Don't hide playfield layer with HUD
  Dean Herbert · 2024-05-02 15:36:40 +08:00
  f9ef689492
• Add delay before delayed resume starts

  It was previously a bit sudden after dismissing the pause screen. Now
  there's a short delay before the actual countdown begins.

  Dean Herbert · 2024-05-01 20:30:48 +08:00
  b8209b92f6
• Fix incorrect xmldoc and adjust colour provider to match Player
  Dean Herbert · 2024-05-01 20:30:36 +08:00
  87e814e201
• Decrease alpha of delayed resume overlay as count approaches zero

  Allows better visibility of playfield underneath it.

  Dean Herbert · 2024-05-01 20:29:28 +08:00
  67c0d7590a
• Merge branch 'master' into generic-math
  Dean Herbert · 2024-04-23 22:21:31 +08:00
  221af74f95
• Fix settings colour scheme wrong when viewing gameplay from skin editor button

  Closes https://github.com/ppy/osu/issues/27949.

  Dean Herbert · 2024-04-23 20:54:48 +08:00
  804b1b0d88
• Fix code quality
  Joseph Madamba · 2024-04-22 11:23:38 -07:00
  49154c0e23
• Apply generic math-related changes
  Bartłomiej Dach · 2024-04-22 10:15:56 +02:00
  09b0f3005e
• Enable NRT to ScoreManager
  Joseph Madamba · 2024-04-14 15:53:29 -07:00
  f282152f99
• fix missing underscore
  Loreos7 · 2024-04-13 14:53:51 +03:00
  5a8b8908dd
• Update hit error metre to use new icons

  - [ ] Depends on https://github.com/ppy/osu-resources/pull/317.

  Dean Herbert · 2024-04-04 14:31:40 +08:00
  9521c1e3e4
• Merge pull request #27783 from 64ArthurAraujo/add-invalid-beatmap-hash-custom-message

  Add custom message in the case of a `invalid beatmap_hash`

  Dean Herbert · 2024-04-04 10:47:22 +08:00
  2e1d63a1c2
• Make message more general

  Co-authored-by: Walavouchey <36758269+Walavouchey@users.noreply.github.com>

  Arthur Araujo · 2024-04-03 19:15:22 -03:00
  9e92ebaa43
• Add custom message in the case of a invalid beatmap_hash
  Arthur Araujo · 2024-04-03 11:30:14 -03:00
  8e00368f7c
• Fix some maps requiring multiple intro skips that weren't there on stable

  Closes https://github.com/ppy/osu/issues/25633.
  
  The reason why that particular beatmap did not have a double skip
  on stable is here:
  
      https://github.com/peppy/osu-stable-reference/blob/e53980dd76857ee899f66ce519ba1597e7874f28/osu!/GameModes/Play/Player.cs#L1761-L1770
  
  The particular place of interest is the `leadInTime < 10000` check.
  If `leadInTime < 10000`, then `leadIn == leadInTime`, and it turns out
  that `AudioEngine.Time` will always be more than or equal to `leadIn`,
  because it's also the gameplay start time:
  
      https://github.com/peppy/osu-stable-reference/blob/e53980dd76857ee899f66ce519ba1597e7874f28/osu!/GameModes/Play/Player.cs#L2765
  
  This essentially means that if the `leadInTime` is less than 10000,
  that particular check is just dead. So a double skip can only occur
  if the gameplay starts at time -10000 or earlier due to the storyboard.

  Bartłomiej Dach · 2024-04-03 16:12:20 +02:00
  9d54f1a092
• Adjust blurred icons position due to size handling differences
  Andrei Zavatski · 2024-03-31 01:55:34 +03:00
  11b1135804
• Simplify glowing icons in break overlay
  Andrei Zavatski · 2024-03-31 01:44:54 +03:00
  58a68e94af
• Merge pull request #26937 from frenzibyte/fix-osu-logo-blocking-load

  Stop blocking player load when hovering over osu! logo

  Dean Herbert · 2024-03-21 21:52:25 +08:00
  970e45ff24
• Add sounds to countdown
  Dean Herbert · 2024-03-21 11:45:48 +08:00
  55d66d4615
• Update incorrect xmldoc
  Dean Herbert · 2024-03-20 01:26:39 +08:00
  0de5ca8d2d
• Merge branch 'master' into tcm-resume
  Dean Herbert · 2024-03-20 01:25:40 +08:00
  35df381717
• Remove redundant cast
  Dean Herbert · 2024-03-16 13:18:42 +08:00
  15c0b1a2ec
• Match settings panels' backgrounds visually and behaviourally
  Dean Herbert · 2024-03-16 10:23:21 +08:00
  a49c4ebea6
• Adjust timings and delay disclaimers the same as settings
  Dean Herbert · 2024-03-16 10:09:49 +08:00
  0f8d526453
• Handle hover so that users can hover disclaimer to block load & read it
  Bartłomiej Dach · 2024-03-15 11:45:27 +01:00
  a78210c88f
• Tweak visuals further
  Bartłomiej Dach · 2024-03-15 11:38:51 +01:00
  e6883b8418
• Add background to disclaimers
  Bartłomiej Dach · 2024-03-15 11:31:45 +01:00
  51568ba06a
• Improve hiding transition when multiple disclaimers are visible
  Bartłomiej Dach · 2024-03-15 11:01:34 +01:00
  5513a72748
• Add localisation support
  Bartłomiej Dach · 2024-03-15 10:59:49 +01:00
  49a087f7fc
• Stay on player loader a bit longer if disclaimers are present

  Just to make reading the text easier.

  Bartłomiej Dach · 2024-03-15 09:53:20 +01:00
  4688a53cf4