9059 Commits

• Merge pull request #29188 from bdach/daily-challenge/better-messaging

  Add notification on daily challenge conclusion & start of new one

  Dean Herbert · 2024-07-31 13:35:25 +09:00
  e9ed9ff58b
• Fix test failure due to TestMetadataClient providing null statistics array
  Dean Herbert · 2024-07-31 02:53:10 +09:00
  5ebb5ad670
• Merge branch 'master' into daily-challenge/better-messaging
  Dean Herbert · 2024-07-30 19:04:48 +09:00
  d75c170ba1
• Elongate usernames in DrawableChannel test
  Dean Herbert · 2024-07-30 17:52:55 +09:00
  71649005bf
• Merge pull request #29137 from normalid-awa/feature/visual/chatline-background-altering

  Alternate background colour of chat lines to better visually distinguish wrapped lines

  Dean Herbert · 2024-07-30 17:51:41 +09:00
  71acb7e9fc
• Show new daily challenge notification globally
  Bartłomiej Dach · 2024-07-30 10:36:26 +02:00
  1b57a2a136
• Attempt to fix tests more
  Bartłomiej Dach · 2024-07-30 10:07:38 +02:00
  a05f810724
• Add failing test coverage
  Bartłomiej Dach · 2024-07-30 08:39:01 +02:00
  ae38e66036
• Fix tests maybe
  Bartłomiej Dach · 2024-07-29 15:28:52 +02:00
  b77a10b6db
• Rename typo in test naming
  Dean Herbert · 2024-07-29 22:19:38 +09:00
  1daeb7ebd0
• Add notification on daily challenge conclusion & start of new one

  Because I wish to stop seeing "DAILY CHALLENGE WHERE" every day
  on #general.
  
  The notifications are constrained to the daily challenge screen only to
  not spam users who may not care.

  Bartłomiej Dach · 2024-07-29 14:30:10 +02:00
  b46f3c97da
• Fix potentially too many scores displaying in breakdown while in gameplay
  Dean Herbert · 2024-07-29 20:58:42 +09:00
  7afcd72872
• Add ability to test daily challenge carousel items when hidden
  Dean Herbert · 2024-07-29 20:43:47 +09:00
  76cd2df699
• Fix typos and visuals
  Dean Herbert · 2024-07-29 20:24:51 +09:00
  997b3eb498
• Improve unit test
  normalid · 2024-07-28 15:08:36 +08:00
  e58bdbb8a9
• Clean up code
  normalid · 2024-07-27 18:55:17 +08:00
  4e44a6e7f8
• FIx code quality
  normalid · 2024-07-27 18:48:45 +08:00
  73a98b45e9
• Implement unit test
  normalid · 2024-07-27 18:24:32 +08:00
  7f4bfb25a9
• Merge pull request #29108 from bdach/daily-challenge/better-breakdown

  Improve score breakdown on daily challenge

  Dean Herbert · 2024-07-26 23:12:04 +09:00
  4fa6a19409
• Merge pull request #29099 from bdach/daily-challenge/totals-display

  Implement component for displaying running totals in daily challenge

  Dean Herbert · 2024-07-26 21:44:58 +09:00
  1607075e0c
• Highlight where local user's best is on the breakdown
  Bartłomiej Dach · 2024-07-26 14:32:01 +02:00
  fc0ade2c61
• Implement component for displaying running totals in daily challenge

  Total pass count and cumulative total score, to be more precise.

  Bartłomiej Dach · 2024-07-26 09:51:39 +02:00
  174dc91f4b
• Merge pull request #29055 from peppy/event-feed-improvements

  Improve daily challenge event feed

  Bartłomiej Dach · 2024-07-26 08:37:47 +02:00
  e489ae8f72
• Merge pull request #29057 from frenzibyte/daily-challenge-replay-download-button

  Fix daily challenge not showing a replay button in results screen

  Bartłomiej Dach · 2024-07-26 08:03:17 +02:00
  09a1fd2cd1
• Add test case against resetting score in download button
  Salman Ahmed · 2024-07-26 05:08:13 +03:00
  3e8917cadb
• Revert "Add failing test case"

  This reverts commit 0182f3d7c3.

  Salman Ahmed · 2024-07-25 08:51:48 +03:00
  e1ccf68801
• Fix too many event rows displaying after spending a long time in gameplay/results
  Dean Herbert · 2024-07-25 14:31:22 +09:00
  f1dda4ab1e
• Make event feed test show more realistic content automatically
  Dean Herbert · 2024-07-25 14:31:21 +09:00
  bba151a776
• Add failing test case
  Salman Ahmed · 2024-07-25 07:39:58 +03:00
  0182f3d7c3
• Add lenience to avoid floating point errors
  Salman Ahmed · 2024-07-24 23:26:23 +03:00
  b3e3bf7cec
• Fix dragging number boxes overwritten by select-all-on-focus feature
  Salman Ahmed · 2024-07-24 23:19:04 +03:00
  6645dac71d
• Add test coverage for expected sample popover behaviour
  Bartłomiej Dach · 2024-07-24 12:08:13 +02:00
  55382a4ba6
• Merge pull request #28849 from frenzibyte/custom-profile-colour

  Add custom hue support to user profile overlay

  Bartłomiej Dach · 2024-07-22 09:41:32 +02:00
  dd8be62d07
• Merge pull request #28881 from smoogipoo/fix-judgement-cut

  Fix judgement animation getting cut early

  Bartłomiej Dach · 2024-07-22 09:24:57 +02:00
  088b8aff11
• Add extensive test cases for correct input handling while paused in osu! & non-osu!
  Salman Ahmed · 2024-07-19 18:48:35 +03:00
  d7651ef387
• Merge pull request #28900 from smoogipoo/fix-more-tests

  Fix more test failures

  Dean Herbert · 2024-07-19 19:38:52 +09:00
  d9297438ba
• Attempt to fix TestSelectableMouseHandling test failure

  https://github.com/ppy/osu/pull/28900/checks?check_run_id=27652166871
  
  This is an attempt. Going frame-by-frame I noticed that there's one
  frame in which the text is loaded but the
  FillFlowContainer/GridContainer haven't properly validated so the text
  is not positioned correctly (it's overflowing the panel to the left). If
  the cursor is moved at this exact time, then it may not be properly
  positioned for the following assertion, even though it is _somewhere_ on
  the panel.
  
  If the above is the case, then this is a known o!f issue, but not a
  simple one to solve.
  
  I haven't reproed this locally.

  Dan Balasescu · 2024-07-19 17:49:16 +09:00
  7a4758d8cc
• Fix TestCancelNavigationToEditor test failure

  https://github.com/ppy/osu/actions/runs/10002179087/job/27648253709
  
  The editor could be pushed before the exit actually
  occurs.

  Dan Balasescu · 2024-07-19 15:04:21 +09:00
  d7ae9505b2
• Enable NRT while we're here
  Bartłomiej Dach · 2024-07-19 07:34:00 +02:00
  79cf644b8d
• Add failing test coverage
  Bartłomiej Dach · 2024-07-19 07:30:57 +02:00
  73edb32440
• Fix TestPostAsOwner test failure

  https://github.com/smoogipoo/osu/actions/runs/9990112749/job/27610257309
  
  Comments are loaded asynchronously, both from the initial request and
  the following message-post request. By sheer timing luck, these could be
  out of order and the assertion on the posted message could fail.

  Dan Balasescu · 2024-07-18 20:54:05 +09:00
  3f4e56be3c
• Use constraint to improve assertion message
  Dan Balasescu · 2024-07-18 18:34:08 +09:00
  33a81d8181
• Fix TestAllSamplesStopDuringSeek test failure

  https://github.com/smoogipoo/osu/actions/runs/9986761756/job/27599851263
  
  This is a bit of a workaround, likely timing related. I don't foresee an
  until step in this case to cause false-passes.

  Dan Balasescu · 2024-07-18 16:26:42 +09:00
  f3cd3d7d3b
• Fix TestTouchScreenDetectionAtSongSelect test failure

  https://github.com/ppy/osu/actions/runs/9985890747/job/27597501295
  
  In this case, the settings overlay is taking a very long time to load
  (on a background thread), and pops in when it finishes loading because
  it's been requested to open.
  
  The opens the settings overlay, closes it (by pressing escape, this does
  not actually close it because it's not loaded yet), and then enters song
  select by pressing 'P' 3 times. The settings overlay finishes loading at
  just the right opportune moment to eat one of the 'P' key presses.

  Dan Balasescu · 2024-07-18 16:26:16 +09:00
  1906c2f725
• Fix intermitent test failure in TestSceneArgonHealthDisplay
  Salman Ahmed · 2024-07-18 01:20:50 +03:00
  7a39435017
• Fix code inspection
  Bartłomiej Dach · 2024-07-16 11:31:16 +02:00
  76d016df34
• Add test
  Dan Balasescu · 2024-07-16 18:19:00 +09:00
  d4ea604ad0
• Add test coverage
  Salman Ahmed · 2024-07-13 11:58:54 +03:00
  be1d3c0ea4
• Merge pull request #28683 from frenzibyte/footer-v2-integration

  Replace local footer in existing sheared overlays (e.g. mod select & first-run setup) with `ScreenFooter`

  Dean Herbert · 2024-07-12 22:45:06 +09:00
  eb3f480a2a
• Merge pull request #28788 from bdach/timeline-redesign

  Redesign editor timelines to address most frequent user complaints

  Bartłomiej Dach · 2024-07-12 10:58:59 +02:00
  518dc17518