Dean Herbert
cb468fa4ec
Fix OverlappingScrollAlgorithm returning incorrect results for TimeAt before first control point
2023-05-26 19:59:19 +09:00
Bartłomiej Dach
eb471091c7
Merge pull request #20829 from peppy/sample-set-controls
...
Add sample bank selection controls (and hotkeys) to editor
2023-05-25 22:49:46 +02:00
Bartłomiej Dach
96fe7cbe54
Merge branch 'master' into sample-set-controls
2023-05-25 21:58:16 +02:00
Bartłomiej Dach
7d8f08c0ea
Fix ComposeBlueprintContainer briefly assigning auto bank
...
Seems to have had no consequence due to the way
`AutomaticBankAssignment` works (that flag is checked in
`PlacementBlueprint.UpdateTimeAndPosition()`, which runs essentially
every frame), but let's avoid putting it there at all ever.
2023-05-25 21:49:29 +02:00
Bartłomiej Dach
adee624a8f
Change PlacementBlueprint.AutomaticBankAssignment to property
...
Mostly for consistency.
2023-05-25 21:32:21 +02:00
Bartłomiej Dach
8a538a0675
Merge pull request #23659 from peppy/beatmap-length-calcualtions
...
Centralise beatmap playable duration and bounds lookups
2023-05-25 20:32:46 +02:00
Bartłomiej Dach
6425a33b45
Merge branch 'master' into beatmap-length-calcualtions
2023-05-25 17:44:15 +02:00
Bartłomiej Dach
78f41f7109
Fix spelling
2023-05-25 17:33:41 +02:00
Bartłomiej Dach
b59f4aee99
Merge pull request #23660 from peppy/simplify-deselect
...
Fix crash when deleting dragged object in skin editor
2023-05-25 17:27:41 +02:00
Bartłomiej Dach
e8db0739fa
Merge pull request #23577 from peppy/accuracy-heatmap-text-hints
...
Show text hints on the accuracy heat map to better explain direction
2023-05-25 17:00:25 +02:00
Dean Herbert
949de35664
Ensure selection is reset after immediately deleting objects
...
Closes https://github.com/ppy/osu/issues/23518 .
2023-05-25 23:20:32 +09:00
Dean Herbert
30c31d7418
Merge pull request #23563 from timiimit/organize-room-pills
...
Add common `OnlinePlayPill` for all online room pills
2023-05-25 23:12:16 +09:00
Dean Herbert
a6a380dd41
Merge branch 'master' into organize-room-pills
2023-05-25 19:57:28 +09:00
Dean Herbert
609c7227ee
Fix changes to font weight in a couple of combined implementations
2023-05-25 19:55:11 +09:00
Dean Herbert
1049257b56
Simplify SelectionHandler's DeselectAll implementation
...
We are already doing other operations in this class directly on `SelectedItems`, so might as well change this one to match
2023-05-25 18:46:31 +09:00
Dean Herbert
1e14b02493
Fix bindable feedback loop
2023-05-25 17:58:38 +09:00
Dean Herbert
058edb5d5f
Centralise beatmap playable duration and bounds lookups
2023-05-25 17:32:48 +09:00
Bartłomiej Dach
59768c5ffd
Merge pull request #23581 from peppy/beat-divisor-visual-improvements
...
Update beat divisor control to show ticks in more visually correct locations
2023-05-24 23:18:25 +02:00
Bartłomiej Dach
578a0e7494
Merge branch 'master' into beat-divisor-visual-improvements
2023-05-24 22:28:26 +02:00
Bartłomiej Dach
6ec4ecfdd7
Mention fallback default in GetDivisorForBeatIndex()
2023-05-24 22:17:51 +02:00
Bartłomiej Dach
6392c2007c
Merge pull request #23637 from peppy/add-shadow-settings-notifications
...
Add shadow to notifications and settings overlays to better distinguish from other overlays
2023-05-24 21:34:14 +02:00
Bartłomiej Dach
3311d6faaa
Merge pull request #23651 from peppy/editor-escape-deselects
...
Allow deselecting any selection in the editor using the `Back` binding (escape key)
2023-05-24 21:18:18 +02:00
Bartłomiej Dach
8b6cd1310a
Merge branch 'master' into editor-escape-deselects
2023-05-24 20:18:44 +02:00
Bartłomiej Dach
07b5874eee
Fix test step name
2023-05-24 20:18:36 +02:00
Bartłomiej Dach
567a648e12
Merge pull request #23646 from peppy/pause-screen-cleanup
...
Remove flavour text from the pause / fail screens
2023-05-24 19:55:23 +02:00
Bartłomiej Dach
cd3602406b
Remove unused using directive
2023-05-24 18:54:48 +02:00
Dean Herbert
6044327181
Add test coverage for escape deselecting any active selection
2023-05-24 23:59:22 +09:00
Dean Herbert
663cec1ff6
Combine editor navigation test scenes
2023-05-24 23:51:28 +09:00
Dean Herbert
b14b1072c2
Allow deselecting any selection in the editor using the Back binding (escape key)
2023-05-24 19:24:14 +09:00
Dean Herbert
456f3005d6
Apply nullability to GameplayMenuOverlay and use TextFlowContainer for text
2023-05-24 18:28:04 +09:00
Dean Herbert
8ada8b1c8c
Remove description line from pause/fail screen
...
These were in the designs but read pretty bad / evil. I can't think of
any text to go in their place that makes sense, so let's just nuke it.
2023-05-24 17:48:35 +09:00
Dean Herbert
8e5ba2208d
Add test coverage of new hotkeys
2023-05-24 17:33:48 +09:00
Dean Herbert
3a05dffa50
Add "auto" bank selection during placement
2023-05-24 17:11:12 +09:00
Dean Herbert
fc22c75464
Don't use switch for single case statement
2023-05-24 16:14:05 +09:00
Dean Herbert
a22ad98cb7
Fix hotkeys not actually working
2023-05-24 14:56:11 +09:00
Dean Herbert
a9ba16a2be
Update to support non-control-point sample changes
2023-05-24 14:20:38 +09:00
Dean Herbert
e68ba6366c
Update new usages of "soft" to use the new constant
2023-05-24 14:04:10 +09:00
Dean Herbert
298989ffd2
Merge branch 'master' into sample-set-controls
2023-05-24 14:03:04 +09:00
Dean Herbert
561b759bf9
Tidy up implementation and ensure non-solid ticks start at zero alpha
2023-05-24 13:49:29 +09:00
Dean Herbert
8f1f1955df
Merge pull request #66 from Gyoshi/beat-divisor-visual-improvements
...
Add ghost ticks to exhibit current divisor on `BeatDivisorControl`
2023-05-24 13:41:48 +09:00
Dean Herbert
6526688ddb
Merge pull request #67 from Gyoshi/beat-divisor-mouse-drag-cherry-picked
...
Beat divisor mouse drag fix and tests
2023-05-24 13:37:34 +09:00
Dean Herbert
9869e815ce
Merge pull request #23642 from Joehuu/remove-logo-arriving-workaround
...
Remove `OsuScreen.ApplyLogoArrivingDefaults()`
2023-05-24 13:20:26 +09:00
Dean Herbert
e5451d1d79
Centralise definition of overlay shadow opacity and reduce slightly
2023-05-24 12:40:35 +09:00
Joseph Madamba
067328233c
Remove OsuScreen.ApplyLogoArrivingDefaults()
2023-05-23 13:17:43 -07:00
Bartłomiej Dach
1671729b78
Merge pull request #23634 from peppy/fix-multiplayer-song-select-scene
...
Fix weird state when attempting to enter gameplay skin editor scene from multiplayer
2023-05-23 20:41:09 +02:00
Gyoshi
7fe19d1992
Last instead of Max divisor to match code elsewhere
2023-05-23 18:45:49 +02:00
Gyoshi
c5ef3ae181
Code styling
2023-05-23 18:44:20 +02:00
Gyoshi
b5f8093941
Use RangePadding to align mouse with slider
2023-05-23 18:16:14 +02:00
Gyoshi
fa00f8b92a
replace manual code with existing method
2023-05-23 18:16:12 +02:00
Gyoshi
921d7e4d89
More fitting tests for new layout
2023-05-23 18:16:10 +02:00
