Salman Ahmed
8488a29e9e
Renew obsoletion date
2022-05-04 17:22:11 +03:00
Salman Ahmed
8f04db5df5
Bring back behaviour of checking incompatibility on gameplay validity
2022-05-04 17:21:19 +03:00
Salman Ahmed
20e277d2e5
Apply proposed naming changes
2022-05-04 17:12:17 +03:00
Salman Ahmed
e9ecf26b6a
Merge branch 'master' into multiplayer-disable-adaptive-speed
2022-05-04 17:12:03 +03:00
Salman Ahmed
e294069e2f
Merge branch 'master' into beatmap-selection-keybinding
2022-05-04 16:48:49 +03:00
Salman Ahmed
9416346c94
Globalise beatmap selection key bindings as "group" selection
2022-05-04 16:46:32 +03:00
Jai Sharma
1a85e1267b
Ensure focus is directed to ChatTextBox from ChatOverlay and add tests
2022-05-04 14:43:40 +01:00
Dean Herbert
ddab3c6d80
Tidy up state variables
2022-05-04 21:00:11 +09:00
apollo-dw
81ce0e6565
Reimplement sliderticks
2022-05-04 12:55:22 +01:00
Bartłomiej Dach
e6fdef2d7a
Fix test failures due to selection/item collection desyncs
2022-05-04 13:51:47 +02:00
Dean Herbert
e920bbd497
Merge pull request #18081 from bdach/mod-overlay/test-coverage-parity
...
Port test coverage from old mod select overlay to new design
2022-05-04 20:24:50 +09:00
Dean Herbert
383245f43a
Fix dialoged pushed to DialogOverlay too early potentially doing cross-thread transforms
...
As seen at https://github.com/ppy/osu/runs/6287700705?check_suite_focus=true .
2022-05-04 20:23:36 +09:00
Dean Herbert
cf220f171b
Add test coverage of cross-thread transforms if a dialog is pushed too early
2022-05-04 20:23:36 +09:00
Bartłomiej Dach
0405c1c34a
Ensure selected playlist item is always scrolled into view
2022-05-04 13:15:26 +02:00
Bartłomiej Dach
ec27fa8e85
Add test coverage for keyboard selection
2022-05-04 13:15:10 +02:00
Dean Herbert
e4ac714c6d
Merge pull request #18088 from peppy/fix-editor-toolbox-click-through
...
Fix clicks and drags around editor toolboxes resulting in unexpected interactions
2022-05-04 19:42:32 +09:00
Dean Herbert
5f11ff564b
Merge branch 'master' into mod-overlay/test-coverage-parity
2022-05-04 19:40:56 +09:00
Dean Herbert
3eead5a6a3
Rename FlushAnimation to FlushPendingSelections to better match purpose
2022-05-04 19:40:08 +09:00
Bartłomiej Dach
3b04daddaa
Fix self-reference in region name
2022-05-04 12:36:43 +02:00
Dean Herbert
df1f4aecdc
Add support for traversing playlist items using next/previous bindings
...
Addresses https://github.com/ppy/osu/discussions/18061 .
2022-05-04 19:09:44 +09:00
Dean Herbert
2f12c7d9e1
Change ChatTextBox to not handle up/down arrows
2022-05-04 19:09:22 +09:00
Bartłomiej Dach
bf80dd864c
Merge branch 'master' into fix-editor-toolbox-click-through
2022-05-04 11:57:32 +02:00
Bartłomiej Dach
6380216263
Nudge click location to avoid placement failures
2022-05-04 11:56:44 +02:00
Bartłomiej Dach
a759e641eb
Enforce composer aspect ratio to avoid depending on ambient window size
2022-05-04 11:56:29 +02:00
Dean Herbert
0018408bdb
Merge pull request #18071 from frenzibyte/distance-spacing-osd
...
Display toast notification on editor distance spacing changes
2022-05-04 18:42:00 +09:00
Dean Herbert
4e0f899159
Rename value changed variable
2022-05-04 18:13:30 +09:00
Salman Ahmed
f5d4f02200
Use ToUpper for key binding text
2022-05-04 11:59:29 +03:00
Dean Herbert
f899c3e68f
Add test coverage of circle placement around editor toolboxes
2022-05-04 17:56:53 +09:00
Salman Ahmed
0b8fd2e39f
Improve distance spacing toast inline with key binding changes
2022-05-04 11:43:19 +03:00
Dean Herbert
b325f0ee0b
Combine editor toolbox container implementation and fix input blocking
...
Until now, toolbox scroll areas would block input from arriving behind
them, even when no visible element was clicked.
In addition, clicking on a button inside a toolbox would still send a
`MouseDown` event to things behind it. Specifically, the editor's
`HitObjectComposer` would receive these events and also place objects
when the user does not expect them to be placed.
This fixes another regression that occurred due to `ScrollContainer`s no
longer blocking input theirselves.
2022-05-04 17:41:30 +09:00
Salman Ahmed
3d2072498e
Merge branch 'master' into distance-spacing-osd
2022-05-04 11:41:12 +03:00
Dean Herbert
a66743266f
Remove unused ScrollingToolboxGroup class
2022-05-04 17:20:58 +09:00
Salman Ahmed
6f52a0b5eb
Merge branch 'master' into distance-spacing-osd
2022-05-04 11:10:18 +03:00
Dean Herbert
f64a6305af
Merge pull request #18070 from frenzibyte/distance-spacing-keybinding
...
Add keybind for handling distance spacing scrolls in editor
2022-05-04 17:03:06 +09:00
Dean Herbert
40f1ceca0a
Merge branch 'master' into distance-spacing-keybinding
2022-05-04 16:34:01 +09:00
Dean Herbert
732739715a
Remove "grid" from strings
2022-05-04 16:31:20 +09:00
Salman Ahmed
504ca5be31
Fix scrolling no longer adjusting distance spacing by amount
2022-05-04 09:52:33 +03:00
Bartłomiej Dach
1122ee967c
Merge pull request #18085 from peppy/fix-editor-grid-rendering
...
Improve editor grid rendering
2022-05-04 08:23:39 +02:00
Huo Yaoyuan
a17bbd62b7
Disable EnforceCodeStyleInBuild in Xamarin CI run
2022-05-04 14:06:01 +08:00
Salman Ahmed
813d6fed48
Split activation keybind to separate increase/decrease keybinds
2022-05-04 09:00:54 +03:00
Huo Yaoyuan
35eeeba4c6
Disable code style analysis on Xamarin projects
2022-05-04 13:57:53 +08:00
Huo Yaoyuan
8e96af8ff0
Update indentation to be clearer
2022-05-04 13:43:59 +08:00
Dean Herbert
df530cb5ab
Add highlighting to the position snap grid edges in addition to centre lines
2022-05-04 13:49:04 +09:00
Dean Herbert
0bb90c7b07
Fix gridline centering and ensure lines are always rendered using a fixed screen-space width
2022-05-04 13:41:55 +09:00
Dean Herbert
bb086800b1
Remove ugly playfield border
2022-05-04 13:41:30 +09:00
Salman Ahmed
d52a1a5d23
Add key binding for beatmap selection in song select
2022-05-04 03:52:10 +03:00
Jai Sharma
60999e83e0
Ensure ChatTextBox takes/leaves focus on chat overlay pop in/out
2022-05-03 22:33:36 +01:00
Jai Sharma
c17edb2848
Add padding to text in ChatTextBar to separate it from the textbox
2022-05-03 22:32:51 +01:00
Jai Sharma
50aee8b665
Ensure ChannelListSelector text also turns white when selected
2022-05-03 22:32:01 +01:00
Bartłomiej Dach
f5fa41356e
Rewrite mod instance management again to pass tests
2022-05-03 22:31:34 +02:00
