Bartłomiej Dach
c12cb2582e
Document & reduce visibility of GetInstanceType()
2024-12-02 10:03:19 +01:00
Salman Alshamrani
15a4726d68
Refactor skin deserialisation tests to better support skin migration
2024-11-28 23:27:04 -05:00
Salman Alshamrani
01f3a2dd14
Move non-legacy conditional reasoning to migration code
2024-11-27 06:12:52 -05:00
Salman Alshamrani
0e920a61da
Use type equality
2024-11-25 23:49:55 -05:00
Salman Alshamrani
5ab9074f5d
Move test and mark headless
2024-11-25 23:43:46 -05:00
Salman Alshamrani
fcbfbd02fd
Add migration logic for legacy health displays
2024-11-25 23:39:37 -05:00
Salman Alshamrani
c2215b10cf
Add extensive test scene for skin migrations
...
This is different from `SkinDeserialisationTest` in that layouts can be written programmatically with as much ease, allowing to test migration logic with different scenarios without running the game and exporting skins and attaching them to tests.
2024-11-25 23:23:39 -05:00
Salman Alshamrani
83ecfbd155
Revert "Refactor skin migration to allow mutating multiple layouts at once"
...
This reverts commit f1b5686904
2024-11-25 23:23:39 -05:00
Salman Alshamrani
7df7727591
Revert "Migrate legacy health bar display to per-ruleset target"
...
This reverts commit 76f79ce083
2024-11-25 23:23:38 -05:00
Salman Alshamrani
76f79ce083
Migrate legacy health bar display to per-ruleset target
2024-11-25 00:02:27 -05:00
Salman Alshamrani
f1b5686904
Refactor skin migration to allow mutating multiple layouts at once
2024-11-25 00:02:10 -05:00
Salman Alshamrani
8dca69e3f9
Add osu!mania specifications for health bar display
2024-11-25 00:02:10 -05:00
Dean Herbert
c34827a4ed
Merge pull request #30862 from frenzibyte/dont-scare-the-player
...
Don't play fail animation if restarting on fail
2024-11-24 23:11:19 +09:00
Dean Herbert
888f02e3a6
Merge pull request #30855 from SupDos/tips-remove-fps
...
Remove FPS shortcut tip
2024-11-24 19:57:08 +09:00
Salman Alshamrani
6d0d7f3e75
Don't play fail animation if restarting on failure
2024-11-24 04:45:48 -05:00
Salman Alshamrani
354bc424a3
Merge pull request #30830 from smoogipoo/multiplayer-remove-expired-item-removal
...
No longer remove expired playlist items from `Room` model
2024-11-23 23:58:17 -05:00
Salman Alshamrani
956da0383f
Merge branch 'master' into multiplayer-remove-expired-item-removal
2024-11-23 22:19:21 -05:00
Salman Alshamrani
6b78553559
Merge branch 'master' into tips-remove-fps
2024-11-23 20:57:14 -05:00
Salman Alshamrani
7a973b0243
Merge pull request #30834 from peppy/fix-song-ticker-contrast
...
Fix song ticker having very bad contrast against bright backgrounds
2024-11-23 20:55:26 -05:00
SupDos
2f096f71d3
Remove FPS shortcut tip
2024-11-24 02:34:30 +01:00
Salman Alshamrani
608bda135a
Merge branch 'master' into fix-song-ticker-contrast
2024-11-23 20:14:33 -05:00
Salman Alshamrani
2f45ebeec8
Remove using directive
2024-11-23 20:13:57 -05:00
Salman Alshamrani
63c2ddb99e
Merge pull request #30636 from peppy/remove-macos-recommendation
...
Remove macOS "borderless" recommendation
2024-11-22 23:54:57 -05:00
Salman Alshamrani
c9dc6628fc
Merge branch 'master' into remove-macos-recommendation
2024-11-22 23:14:09 -05:00
Dean Herbert
ce41c000a1
Merge pull request #30812 from smoogipoo/playlist-populate-on-enter
...
Fix joining playlists room sometimes not selecting the first item
2024-11-22 23:57:45 +09:00
Dean Herbert
04ed954387
Fix song ticker having very bad contrast against bright backgrounds
...
Closes #30814 .
2024-11-22 18:17:55 +09:00
Dan Balasescu
39504c348d
Cleanup CopyFrom() method
...
Though the code appears slightly different, it should be semantically
equivalent. APIUser equality is implemented on `Id` and `Host` should
never transition from non-null to null.
2024-11-22 17:22:30 +09:00
Dan Balasescu
e59ac9e7c8
No longer remove expired playlist items from Room model
2024-11-22 17:19:26 +09:00
Bartłomiej Dach
479ff7eb41
Merge pull request #30799 from peppy/fix-player-loader-focus-fux
...
Fix beatmap load not continuing when when settings slider is focused
2024-11-22 08:57:10 +01:00
Bartłomiej Dach
ce3d4e8648
Merge pull request #30807 from smoogipoo/multiplayer-nrt
...
Enable NRT for multiplayer and playlists
2024-11-22 08:50:11 +01:00
Bartłomiej Dach
512d2c6e3b
Merge branch 'master' into multiplayer-nrt
2024-11-22 08:09:42 +01:00
Bartłomiej Dach
4a129ac0bf
Merge pull request #30766 from Darius-Wattimena/catch-improve-info-on-selected
...
Add snapping info to the catch selected objects inspector
2024-11-22 08:08:33 +01:00
Dean Herbert
6a0ac4c29e
Merge pull request #29640 from smoogipoo/mania-imperfect-ss
...
Make mania award SS even if there are GREAT judgements
2024-11-22 14:42:32 +09:00
Dean Herbert
66be38b227
Merge pull request #30819 from frenzibyte/recreate-beatmap-per-mod-test
...
Recreate beatmap every test run in `ModTestScene`
2024-11-22 14:11:08 +09:00
Dean Herbert
41addaae9a
Rename variable to imply it is now a function
2024-11-22 13:11:32 +09:00
Salman Alshamrani
5dffc322af
Recreate beatmap every test run in ModTestScene
2024-11-21 17:48:33 -05:00
Dan Balasescu
2a7266cb23
Fix tests
2024-11-22 01:26:35 +09:00
Dan Balasescu
f738fb2a89
Populate rooms as soon as they're joined
2024-11-21 23:48:04 +09:00
Dan Balasescu
84ac3097c2
Populate parameter description
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2024-11-21 22:47:46 +09:00
Bartłomiej Dach
23ef8fd909
Merge pull request #30802 from cloudrac3r/patch-1
...
Use consistent decimal places in BeatmapAttributeText
2024-11-21 14:32:25 +01:00
Bartłomiej Dach
74170ea28e
Merge branch 'master' into patch-1
2024-11-21 13:06:19 +01:00
Bartłomiej Dach
42f2ad2423
Fix tests
2024-11-21 13:06:01 +01:00
Dan Balasescu
209380cbac
Enable NRT in TestMultiplayerRoomManager
2024-11-21 21:03:12 +09:00
Dan Balasescu
cc59434ea4
Fix crash due to being too forgiving of nulls
...
This one is super duper annoying to test, because we already have e.g.
`TestScenePlaylistsScreen`. The only way to test it would be to use an
`OsuGameTestScene`.
Maybe this is okay?
2024-11-21 20:52:34 +09:00
Bartłomiej Dach
2eef920e70
Merge pull request #30805 from smoogipoo/fix-playlists-enter-status
...
Fix playlist room status resetting on enter
2024-11-21 12:50:39 +01:00
Dan Balasescu
dc45816566
Fix inspection
2024-11-21 20:41:14 +09:00
Dan Balasescu
6870c99eb2
Enable NRT for multiplayer and playlists
2024-11-21 20:32:09 +09:00
Bartłomiej Dach
0e4d078beb
Merge branch 'master' into catch-improve-info-on-selected
2024-11-21 12:17:54 +01:00
Bartłomiej Dach
2138729c02
Do not show distance to next/previous object if said object is a banana shower
...
The results of such a display were a little bit nonsensical.
2024-11-21 12:17:43 +01:00
Dan Balasescu
8dbf750446
Fix inspection
2024-11-21 18:38:56 +09:00
