50 Commits

• Adjust nightcore sample playback to not stop randomly and be closer to stable (#36702)

  - Closes https://github.com/ppy/osu/issues/30293
  - Fixes https://osu.ppy.sh/community/forums/topics/2179339?n=1
  
  Aside from fixing the off-by-one error that I mentioned in
  https://github.com/ppy/osu/issues/30293#issuecomment-2413801663, this
  also:
  
  - Brings back the behaviour wherein if timing points are arranged very
  weird and nightcore would play e.g. two first beats in a timing point
  back-to-back, the second timing point is silent.
  - Brings back the behaviour wherein the finish sample only plays if
  `OmitFirstBarLine` on the timing point is disabled.
  
  However:
  
  - This does not bring back the behaviour wherein hat samples only play
  if the slider tick rate is even because that only kind of makes sense in
  common time, and if common time is mixed with waltz time or other time
  signatures, it just gets weird.
  - Also stable has zero attempt for compensating for waltz time anyway,
  lazer's behaviour is bespoke, so that is not going to match any way you
  cut it.
  
  My testing procedure essentially consisted of getting stable to log when
  it was playing nightcore samples and cross-checking the first 30sec or
  so of https://osu.ppy.sh/beatmapsets/534385#osu/1131956 (check out the
  timing of that beatmap, for something ranked it is DEEPLY messed up).
  
  I guess I can add test cases if deemed required but I already wasted
  much more time than I would have liked here...

  Bartłomiej Dach · 2026-02-20 12:53:12 +09:00
  1e8b9a7639
• Annotate mods that give pp
  Bartłomiej Dach · 2024-01-31 14:59:35 +01:00
  f89923aeae
• Fix keyboard precision of nightcore/daycore adjustments being incorrect

  Closes https://github.com/ppy/osu/issues/25854.

  Dean Herbert · 2023-12-19 01:07:33 +09:00
  374425ea75
• Add inline commentary in Mod{Day,Night}core about different speed adjustments
  Bartłomiej Dach · 2023-10-18 12:27:16 +02:00
  cff69d63a6
• Also share ScoreMultiplier implementation
  Dean Herbert · 2023-10-18 17:23:50 +09:00
  e56ff33271
• Split common functionality from rate adjust mods into helper class
  Dean Herbert · 2023-10-18 17:23:50 +09:00
  43238b0cee
• Added a "Adjust pitch" switch

  Adjust pitch switch in DoubleTime and HalfTime mods
  Also Nightcore and Daycore is now inherit from RateAdjust

  Givikap120 · 2023-08-24 15:00:32 +03:00
  49598774e0
• Partial everything
  Dan Balasescu · 2022-11-27 00:00:27 +09:00
  7bc8908ca9
• Change mod description type to LocalisableString
  naoei · 2022-08-10 15:54:48 -04:00
  60dae70a18
• Remove the nullable disable annotation.

  Also, mark as nullable for some properties.

  andy840119 · 2022-07-19 20:39:41 +08:00
  1f9f2b413e
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Change IApplicableToTrack to receive adjustable component instead
  Salman Ahmed · 2022-05-10 18:06:03 +03:00
  4f5001704e
• Replace TimeSignatures enum with struct for storage of arbitrary meter
  Bartłomiej Dach · 2022-01-22 20:50:31 +01:00
  735414bc49
• Add abstract non-generic ModNightcore to pattern-match over
  Bartłomiej Dach · 2020-11-15 15:32:02 +01:00
  5ace7abaa8
• Fix incorrect specification on some sample lookups
  Dean Herbert · 2020-10-30 11:59:41 +09:00
  2ea4aa0a37
• Reverse inheritance order of SkinnableSound's pause logic
  Dean Herbert · 2020-09-30 15:45:14 +09:00
  414c40d298
• Use adjustable ITrack
  smoogipoo · 2020-08-12 01:41:21 +09:00
  e47a1eb313
• Remove generics from IApplicableToTrack
  smoogipoo · 2020-08-06 18:25:34 +09:00
  7c3ae4ed42
• Expose track from MusicController
  smoogipoo · 2020-08-06 16:24:14 +09:00
  5c05fe3988
• Move track to MusicController, compiles
  smoogipoo · 2020-08-06 16:24:14 +09:00
  6e42b8219c
• Update naming
  Dean Herbert · 2020-06-23 21:27:01 +09:00
  14ad3835ff
• nullable-ize Mod.Icon
  mcendu · 2020-01-14 21:22:00 +08:00
  5d160376c0
• Simplify complex method
  Dean Herbert · 2019-12-17 12:12:15 +09:00
  87035f8251
• Rename variable for clarity
  Dean Herbert · 2019-12-16 19:42:28 +09:00
  438d97f4f5
• Better initial beat handling
  Dean Herbert · 2019-12-16 19:41:02 +09:00
  cfd8111120
• Add support for simple triple time
  Dean Herbert · 2019-12-16 19:16:54 +09:00
  72404bff9a
• Fix incorrect hat logic; add support for first barline omission
  Dean Herbert · 2019-12-16 18:57:11 +09:00
  210fecc951
• Fix beat playing while paused
  Dean Herbert · 2019-12-16 18:51:22 +09:00
  0f9ff32cdc
• Fix off-by-one starting bar
  Dean Herbert · 2019-12-16 18:50:58 +09:00
  c883c97bab
• Play finish in addition to kick, not isolated
  Dean Herbert · 2019-12-16 18:47:06 +09:00
  3e0fda58ea
• Fix nightcore beat not playing if song doesn't hit beat index 0
  Dean Herbert · 2019-12-16 18:24:29 +09:00
  9de6b62fb1
• ensure beatIndex is 0 before starting beats
  unknown · 2019-12-16 06:35:18 +08:00
  88d3a1707d
• remove unused dependency
  unknown · 2019-12-15 17:46:44 +08:00
  154bc57c6e
• remove unused usings
  unknown · 2019-12-15 17:02:29 +08:00
  6da168118e
• implement backing beats for nightcore mods
  unknown · 2019-12-15 16:56:02 +08:00
  01c036b0b0
• Use protected constructors
  Dean Herbert · 2019-12-12 15:25:37 +09:00
  4c4199269c
• Refactor ModNightcore/ModDaycore
  smoogipoo · 2019-12-11 19:43:32 +09:00
  404d3207ff
• Pin DC/NC pitch
  Dean Herbert · 2019-12-09 20:40:38 +09:00
  12bdb1dafd
• Update mods and user adjust to use adjustments
  Dean Herbert · 2019-12-09 19:41:31 +09:00
  7fd52c21f5
• Allow mods to apply to track, not clock
  Dean Herbert · 2019-12-09 17:44:45 +09:00
  eb074b7058
• Update icon usage to match framework changes
  Dean Herbert · 2019-03-27 19:29:27 +09:00
  de80fc0eac
• Simplify DT/HT/NC/DC
  Dean Herbert · 2019-03-12 18:14:41 +09:00
  6832e384a9
• Use pattern matching wherever possible
  Dean Herbert · 2019-02-28 14:35:00 +09:00
  e2c6a8bc07
• Update licence header (and remove year)
  Dean Herbert · 2019-01-24 17:43:03 +09:00
  8617aaa2a7
• Add IMod and change ShortenedName to Acronym
  Dean Herbert · 2018-11-30 17:16:00 +09:00
  d97a15a504
• Normalize all the line endings
  Dean Herbert · 2018-04-13 18:26:38 +09:00
  32a74f95a5
• Change descriptions and special section
  Joseph Madamba · 2018-03-14 01:05:19 -07:00
  1eeacb7bf7
• Update licence headers
  Dean Herbert · 2018-01-05 20:21:19 +09:00
  37d393bca0
• Parse the mods of a leaderboard's score
  MrTheMake · 2017-08-13 17:41:13 +02:00
  4c2d7bf343
• Add DoubleTime, HalfTime and Nightcore support.
  Dean Herbert · 2017-04-21 17:33:37 +09:00
  3f832731c9