180 Commits

• Bump difficulty calculator versions

  To trigger client-side recalculations of star ratings.
  
  Should have been done in https://github.com/ppy/osu/pull/35029.
  
  Probably closes https://github.com/ppy/osu/issues/35357.

  Bartłomiej Dach · 2025-10-20 08:46:30 +02:00
  03a5aedf99
• Reduce combo scaling for osu!catch (#33417)

  * Reduce combo scaling for osu!catch
  
  This is a conservative reduction, a middle point between the current
  scaling and the CSR proposals.
  
  * Reduce osu!catch combo scaling further
  
  0.45 makes little difference so let's reduce it a bit more.
  
  ---------
  
  Co-authored-by: James Wilson <tsunyoku@gmail.com>

  Wulpey · 2025-06-07 14:17:46 +00:00
  642b938358
• Remove track usage in difficulty and performance calculations (#33132)
  James Wilson · 2025-05-14 12:37:08 +00:00
  d22b3fb200
• Move osu!catch movement diffcalc to an evaluator (#32655)

  * Move osu!catch movement state into `CatchDifficultyHitObject`
  
  In order to port `Movement` to an evaluator, the state has to be either
  moved elsewhere or calculated inside the evaluator. The latter requires
  backtracking for every hit object, which in the worst case is continued
  until the beginning of the map is reached. Limiting backtracking can
  lead to difficulty value changes.
  
  Thus, the first option was chosen for its simplicity.
  
  * Move osu!catch movement difficulty calculation to an evaluator
  
  Makes the code more in line with the other game modes.
  
  * Add documentation for `CatchDifficultyHitObject` fields
  
  ---------
  
  Co-authored-by: James Wilson <tsunyoku@gmail.com>

  wulpine · 2025-04-10 15:47:11 +00:00
  7a9d31adb6
• Fix osu!catch SR buzz slider detection (#32412)

  * Use `normalized_hitobject_radius` during osu!catch buzz slider detection
  
  Currently the algorithm considers some buzz sliders as standstills when
  in reality they require movement. This happens because `HalfCatcherWidth`
  isn't normalized while `exactDistanceMoved` is, leading to an inaccurate
  comparison.
  
  `normalized_hitobject_radius` is the normalized value of `HalfCatcherWidth`
  and replacing one with the other fixes the problem.
  
  * Rename `normalized_hitobject_radius` to `normalized_half_catcher_width`
  
  The current name is confusing because hit objects have no radius in the
  context of osu!catch difficulty calculation. The new name conveys the
  actual purpose of the value.
  
  * Only set `normalized_half_catcher_width` in `CatchDifficultyHitObject`
  
  Prevents potential bugs if the value were to be changed in one of the
  classes but not in both.
  
  * Use `CatchDifficultyHitObject.NORMALIZED_HALF_CATCHER_WIDTH` directly
  
  Requested during code review.
  
  ---------
  
  Co-authored-by: James Wilson <tsunyoku@gmail.com>

  wulpine · 2025-03-24 20:04:40 +03:00
  0c3ee1938e
• Bump difficulty calculator versions in preparation for release
  Dean Herbert · 2025-03-06 16:05:51 +09:00
  bdd2808fb5
• Rename buzz variable per review
  Dean Herbert · 2025-02-10 18:05:08 +09:00
  340e081965
• Calculate hit windows in performance calculator instead of databased difficulty attributes (#31735)

  * Calculate hit windows in performance calculator instead of databased difficulty attributes
  
  * Apply mods to beatmap difficulty in osu! performance calculator
  
  * Remove `GreatHitWindow` difficulty attribute for osu!mania
  
  * Remove use of approach rate and overall difficulty attributes for osu!
  
  * Remove use of hit window difficulty attributes in osu!taiko
  
  * Remove use of approach rate attribute in osu!catch
  
  * Remove unused attribute IDs
  
  * Code quality
  
  * Fix `computeDeviationUpperBound` being called before `greatHitWindow` is set

  James Wilson · 2025-02-07 19:21:12 +09:00
  9f90ebb2f7
• Replace indexed skill access with skills.OfType<...>().Single() (#30034)

  * Replace indexed skill access with `skills.First(s is ...)`
  
  * Fix comment
  
  * Further refactoring to remove casts
  
  ---------
  
  Co-authored-by: Dan Balasescu <smoogipoo@smgi.me>
  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  StanR · 2025-01-20 09:39:35 +00:00
  22e839d62b
• Fix osu!catch "buzz slider" SR abuse (#31126)

  * Implement fix for catch buzz sliders SR abuse
  
  * Run formatting
  
  ---------
  
  Co-authored-by: StanR <hi@stanr.info>

  Bastien D. · 2025-01-18 22:26:23 +03:00
  67723b3e52
• removed unnecessary includes
  Givikap120 · 2024-09-22 15:04:21 +03:00
  2995df7903
• initial commit
  Givikap120 · 2024-09-22 15:01:58 +03:00
  1b77b3912b
• merged multipliers
  Givikap120 · 2024-08-05 16:33:42 +03:00
  e6fc4f6766
• Update CatchPerformanceCalculator.cs
  Givikap120 · 2024-05-29 19:25:58 +03:00
  f5d2c549cb
• Fix catch pp calculator not matching live with respect to miss handling
  Bartłomiej Dach · 2024-03-04 11:53:59 +01:00
  b896d97a4f
• Fix incorrect score conversion on selected beatmaps due to incorrect difficultyPeppyStars rounding

  Fixes issue that occurs on *about* 246 beatmaps and was first described
  by me on discord:
  
      https://discord.com/channels/188630481301012481/188630652340404224/1154367700378865715
  
  and then rediscovered again during work on
  https://github.com/ppy/osu/pull/26405:
  
      https://gist.github.com/bdach/414d5289f65b0399fa8f9732245a4f7c#venenog-on-ultmate-end-by-blacky-overdose-631
  
  It so happens that in stable, due to .NET Framework internals, float
  math would be performed using x87 registers and opcodes.
  .NET (Core) however uses SSE instructions on 32- and 64-bit words.
  x87 registers are _80 bits_ wide. Which is notably wider than _both_
  float and double. Therefore, on a significant number of beatmaps,
  the rounding would not produce correct values due to insufficient
  precision.
  
  See following gist for corroboration of the above:
  
      https://gist.github.com/bdach/dcde58d5a3607b0408faa3aa2b67bf10
  
  Thus, to crudely - but, seemingly accurately, after checking across
  all ranked maps - emulate this, use `decimal`, which is slow, but has
  bigger precision than `double`. The single known exception beatmap
  in whose case this results in an incorrect result is
  
      https://osu.ppy.sh/beatmapsets/1156087#osu/2625853
  
  which is considered an "acceptable casualty" of sorts.
  
  Doing this requires some fooling of the compiler / runtime (see second
  inline comment in new method). To corroborate that this is required,
  you can try the following code snippet:
  
      Console.WriteLine(string.Join(' ', BitConverter.GetBytes(1.3f).Select(x => x.ToString("X2"))));
      Console.WriteLine(string.Join(' ', BitConverter.GetBytes(1.3).Select(x => x.ToString("X2"))));
      Console.WriteLine();
  
      decimal d1 = (decimal)1.3f;
      decimal d2 = (decimal)1.3;
      decimal d3 = (decimal)(double)1.3f;
  
      Console.WriteLine(string.Join(' ', decimal.GetBits(d1).SelectMany(BitConverter.GetBytes).Select(x => x.ToString("X2"))));
      Console.WriteLine(string.Join(' ', decimal.GetBits(d2).SelectMany(BitConverter.GetBytes).Select(x => x.ToString("X2"))));
      Console.WriteLine(string.Join(' ', decimal.GetBits(d3).SelectMany(BitConverter.GetBytes).Select(x => x.ToString("X2"))));
  
  which will print
  
      66 66 A6 3F
      CD CC CC CC CC CC F4 3F
  
      0D 00 00 00 00 00 00 00 00 00 00 00 00 00 01 00
      0D 00 00 00 00 00 00 00 00 00 00 00 00 00 01 00
      8C 5D 89 FB 3B 76 00 00 00 00 00 00 00 00 0E 00
  
  Note that despite `d1` being converted from a less-precise floating-
  -point value than `d2`, it still is represented 100% accurately as
  a decimal number.
  
  After applying this change, recomputation of legacy scoring attributes
  for *all* rulesets will be required.

  Bartłomiej Dach · 2024-01-10 19:30:18 +01:00
  7c9adc7ad3
• Expose only as one method
  Dan Balasescu · 2023-12-21 14:58:23 +09:00
  6b4b2a57fc
• Relocate HitResult numeric score to ScoreProcessor
  Dan Balasescu · 2023-12-21 14:52:31 +09:00
  4e3b994142
• Populate MaxCombo scoring attrib for non-osu rulesets
  Dan Balasescu · 2023-12-18 12:01:51 +09:00
  30116512ca
• Merge branch 'master' into catch-hyperdash-stable-sort
  Dan Balasescu · 2023-12-13 12:40:39 +09:00
  c255339999
• Merge branch 'master' into catch-hyperdash-stable-sort
  Bartłomiej Dach · 2023-12-04 09:05:42 +01:00
  0652ea316d
• Account for legacyAccScore in score conversion
  Zyf · 2023-11-24 23:07:27 +01:00
  71e5654b64
• Merge branch 'master' into catch-hyperdash-stable-sort
  Dan Balasescu · 2023-10-04 20:38:08 +09:00
  bbe9d95b3d
• Add method to retrieve legacy score multiplier
  Dan Balasescu · 2023-10-02 16:52:01 +09:00
  da2a4681d9
• Merge branch 'master' into catch-hyperdash-stable-sort
  Dan Balasescu · 2023-09-19 10:10:57 +09:00
  4e1800860e
• Split legacy scoring attributes into a separate object
  Dan Balasescu · 2023-09-07 21:10:38 +09:00
  2334be1987
• ILegacyScoreProcessor -> ILegacyScoreSimulator
  Dean Herbert · 2023-07-04 17:32:54 +09:00
  1629024111
• Refactoring
  Dan Balasescu · 2023-06-28 16:14:32 +09:00
  09bc8e45de
• Fix float division

  Firstly, this is intended to be a float division.
  
  Secondly, dividing integers by 0 results in an exception, but dividing
  non-zero floats by 0 results in +/- infinity which will be clamped to
  the upper range.
  In particular, this occurs when the beatmap has 1 hitobject (0 drain
  length).

  Dan Balasescu · 2023-06-27 17:14:35 +09:00
  5f350aa66f
• Initial conversion of scores
  Dan Balasescu · 2023-06-26 22:19:01 +09:00
  a9c65d200a
• Add flag to disable computing legacy scoring values
  Dan Balasescu · 2023-06-24 01:03:18 +09:00
  06565871d6
• Fix incorrect calculation of difficulty
  Dan Balasescu · 2023-06-24 00:58:45 +09:00
  87447f41d0
• Adjust attribute data
  Dan Balasescu · 2023-06-19 21:38:13 +09:00
  bfa449e47a
• Add ScoreV1 calculation for CatchRuleset
  Dan Balasescu · 2023-06-13 19:41:39 +09:00
  3ec97121e1
• Write max combo attribute from base class
  Dan Balasescu · 2023-06-02 21:53:25 +09:00
  e402c6d2b4
• Factor out palpable obejct enumeration logic
  ekrctb · 2023-02-03 14:07:21 +09:00
  491ba13b6f
• Remove #nullable disable from Catch.Difficulty
  ekrctb · 2023-01-15 17:29:32 +09:00
  3ab3f556ae
• Add versioning to difficulty calculators
  Dean Herbert · 2022-07-21 18:15:25 +09:00
  aca19a005e
• Remove NRT disables from attributes classes
  Dan Balasescu · 2022-06-27 16:07:15 +09:00
  0fd2c010e5
• Add IBeatmapOnlineInfo parameter and use to extract more data
  Dan Balasescu · 2022-06-27 16:07:15 +09:00
  0579780bb8
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Rename Position -> Index
  Dan Balasescu · 2022-06-09 18:49:11 +09:00
  6d2a2ba7d6
• Pass object position to the object
  apollo-dw · 2022-05-26 19:26:14 +01:00
  66a6467403
• Use object list size for object position
  apollo-dw · 2022-05-24 16:30:25 +01:00
  30b9e0e7ab
• Store hitobject history in the hitobject
  apollo-dw · 2022-05-22 16:26:22 +01:00
  26985ca8af
• Remove unnecessary ctor argument
  Dan Balasescu · 2022-03-15 12:37:39 +09:00
  523f668c8c
• Restructure PerformanceCalculator to not require ScoreInfo argument
  Dan Balasescu · 2022-03-14 14:25:28 +09:00
  4a3e3aba65
• Add XMLDocs to difficulty attribute properties
  Dan Balasescu · 2022-02-16 14:09:19 +09:00
  84e82ef5e4
• Clean up comments
  StanR · 2021-12-21 14:03:24 +03:00
  40b3ce0ade
• Create PerformanceAttributes
  StanR · 2021-12-21 13:08:31 +03:00
  cca02a8016