Dean Herbert
1ab02b93b3
Merge branch 'master' into grids-4
2024-10-07 15:42:23 +09:00
OliBomby
ae8abc7f35
fix readybutton and favouritebutton
2024-10-05 21:46:00 +02:00
OliBomby
ad734b1a13
Revert "Use new keyword instead of overriding TooltipText to remove setter"
...
This reverts commit 80dffa905a
2024-10-05 15:10:36 +02:00
OliBomby
80dffa905a
Use new keyword instead of overriding TooltipText to remove setter
2024-10-03 11:13:49 +02:00
Dean Herbert
1039d4e45d
Increase chat font size again
2024-10-03 16:23:17 +09:00
OliBomby
4bbefa360c
fix using directive
2024-10-01 15:57:34 +02:00
OliBomby
f8397cccc7
Merge remote-tracking branch 'upstream/master' into grids-4
2024-10-01 15:43:54 +02:00
OliBomby
9fa2849b14
Fixed tooltip inheritors of RoundedButton
2024-10-01 15:34:12 +02:00
Dean Herbert
598bc74614
Merge pull request #30058 from bdach/disabled-beatmap-comment-box
...
Properly disable comment box on things that cannot be commented on
2024-10-01 18:52:40 +09:00
Dean Herbert
ad3007eaad
Adjust ILocalUserPlayInfo to expose whether gameplay is in a paused/break state
2024-10-01 17:53:46 +09:00
Bartłomiej Dach
2a214f7c9f
Fix incorrect implementation of next track choice
...
`SkipWhile()` in this context does not correctly ensure that
`ElementAtOrDefault(1)` is not a protected track. An explicit `Where()`
does.
Spotted accidentally when I noticed that skipping to next track can
select a protected track, but skipping to previous cannot.
2024-10-01 10:19:59 +02:00
Bartłomiej Dach
a2d9302f4a
Move shuffle button to left side
2024-10-01 10:12:38 +02:00
Bartłomiej Dach
8eb5e6b1d5
Merge branch 'master' into shuffle
2024-10-01 10:07:54 +02:00
Bartłomiej Dach
8d2f2517a3
Specify type explicitly
2024-10-01 10:01:31 +02:00
Bartłomiej Dach
74a9899fc0
Fix doubled-up enabled state management of commit button
2024-09-30 14:05:26 +02:00
Bartłomiej Dach
e91c8fb4bd
Properly disable comment box on beatmaps that cannot be commented on
...
Closes https://github.com/ppy/osu/issues/30052 .
Compare:
- 83816dbe24/resources/js/components/comment-editor.tsx (L54-L60)83816dbe24/resources/js/components/comment-editor.tsx (L47-L52)
2024-09-30 11:02:00 +02:00
Bartłomiej Dach
c1e51e05df
Merge pull request #29704 from Fabep/ModCustomisationHeaderColor
...
Mod customisation header color
2024-09-27 12:40:35 +02:00
Dean Herbert
a358731af5
Merge pull request #29913 from Joehuu/fix-romanised-searching
...
Fix searching by clicking title/artist in beatmap overlay not following original language setting
2024-09-27 18:39:33 +09:00
Dean Herbert
e7c4451206
Reduce brightness of hover effect
2024-09-27 18:20:16 +09:00
Dean Herbert
64c1ced80d
Merge branch 'master' into ModCustomisationHeaderColor
2024-09-27 18:15:30 +09:00
Dean Herbert
048e3c2505
Merge branch 'master' into fix-romanised-searching
2024-09-27 17:40:03 +09:00
Bartłomiej Dach
fa90b43233
Merge branch 'master' into selection-center
2024-09-27 09:30:36 +02:00
Dean Herbert
5efdc6cdd7
Merge pull request #29936 from u4vh3/skinning-colour-customisation
...
Add colour customisation to layout editor
2024-09-27 14:20:58 +09:00
Bartłomiej Dach
7f8b64bb6d
Redesign directory & file selector (and update usages accordingly)
2024-09-24 14:54:48 +02:00
OliBomby
8e11cda41a
use minimum enclosing circle selection centre in scale
2024-09-20 01:07:54 +02:00
OliBomby
ee00624751
use minimum enclosing circle selection centre in rotation
2024-09-20 01:07:47 +02:00
Daniel Cios
b86f246095
Fix code inspection failure
2024-09-19 19:24:05 +02:00
Daniel Cios
67f04f75a6
Fix default color
2024-09-19 17:27:26 +02:00
PowerDaniex
6ec3f715d2
Fix formatting
2024-09-19 17:26:09 +02:00
PowerDaniex
8c72feda09
Add colour customization to the layout editor
2024-09-19 17:26:09 +02:00
Dean Herbert
188a430418
Merge branch 'master' into grids-3
2024-09-19 18:21:05 +09:00
Joseph Madamba
c185acdbae
Use GetLocalisedBindableString() instead
2024-09-18 11:16:25 -07:00
Bartłomiej Dach
7f52ae8837
Fix code quality inspection
2024-09-18 15:30:56 +02:00
Bartłomiej Dach
12bd516a57
Shuffle playback order in global playlist by default
...
RFC. Closes https://github.com/ppy/osu/issues/18169 .
Implements the given proposal of keeping the current stable order but
adding a shuffle facility to the now playing overlay, and enabling it by
default.
There are more changes I want to make here but I'd like this to get
discussion first, because I am likely to continue putting this sort of
selection logic into `MusicController` and I just want to confirm nobody
is going to have a problem with that.
In particular this is not sharing the randomisation implementation with
beatmap carousel because it doesn't generalise nicely (song select cares
about the particular *beatmap difficulties* selected to rewind properly,
while the music controller only cares about picking a *beatmap set*).
2024-09-18 14:19:55 +02:00
Joseph Madamba
fd6b3b6b36
Fix searching by clicking title/artist in beatmap overlay not following original language setting
2024-09-17 22:34:06 -07:00
Dean Herbert
4a6266efcf
Merge pull request #29714 from Crystallized21/total-participation-tooltip
...
Add Total Participation stat to users profile Daily Challenge Tooltip
2024-09-08 22:42:02 +09:00
Bartłomiej Dach
7f814d3106
Fix incorrect tiers being used for tooltip total participation display
...
Compare: 95e4561a54
2024-09-08 14:26:50 +02:00
Dan Balasescu
ac6cce5911
Refactor to string interpolation
2024-09-07 17:40:33 +09:00
Ianlucht
581f190856
fixed issues with search by adding the double quotation marks in the BeatmapSetHeaderContents links.
2024-09-06 16:31:48 -06:00
Michael Bui
a31ea24c6d
show stats on all rulesets
2024-09-06 23:05:04 +12:00
Michael Bui
362b4bbc56
Hide daily challenge stats if there are no plays
2024-09-06 23:01:05 +12:00
Michael Bui
ab8771900a
change colour
2024-09-06 22:04:10 +12:00
Michael Bui
34a9d60c19
revert back to axes.both
2024-09-06 22:02:35 +12:00
Michael Bui
f59895aa34
take out drawable
2024-09-06 21:54:41 +12:00
Michael Bui
15f73a3dfb
show participation count in tooltip
2024-09-06 21:52:42 +12:00
Fabep
17760afa60
Changed ModCustomisationHeader to inherit from OsuClickableContainer.
...
ModCustomisationHeader changes color depending on state.
2024-09-04 15:29:48 +02:00
Dean Herbert
9abaa87d8f
Merge pull request #29626 from Fabep/master
...
Mod customization header/panel changes
2024-09-04 17:28:11 +09:00
Dean Herbert
86309f4b46
Revert "Woopsie! I accidentally added one too many semi-colons, so I moved it here into the commit instead ;"
...
This reverts commit 582ffcfc97e3457d8501
2024-09-04 17:25:41 +09:00
Dean Herbert
97a51af5a0
Fix one more unnecessary enumerator allocation
2024-09-04 15:22:31 +09:00
Fabep
582ffcfc97
Woopsie! I accidentally added one too many semi-colons, so I moved it here into the commit instead ;
2024-09-02 19:17:07 +02:00
Fabep
e3457d8501
Mod customisation header's color is now based on the state of the panel rather than the hover of the container.
2024-09-02 19:14:08 +02:00
Bartłomiej Dach
5211e606b5
Fix mod customisation header being non-functional on mobile
...
As expected the previous touch handling would prevent the header from
working entirely when click handling was removed from the header.
2024-09-02 11:33:43 +02:00
Fabian Bech Persson
363fc0d5da
Merge branch 'master' into master
2024-08-30 11:06:54 +02:00
OliBomby
ba0c4df2a9
Merge remote-tracking branch 'upstream/master' into doubleclick
2024-08-29 19:34:18 +02:00
Joseph Madamba
ef443b0b5d
Hide pinned comment replies initially to match web
2024-08-28 23:05:15 -07:00
Bartłomiej Dach
d49cd717d6
Merge pull request #29576 from peppy/allow-seek-in-more-places
...
Allow seeking via music controller overlay on more screens
2024-08-28 12:23:09 +02:00
Fabep
6adaf6a41f
Changed ModCustomisationPanelState names
2024-08-28 10:09:47 +02:00
Fabep
be0e2efda2
Removed on click event for expanding the Mod Customisation Header.
2024-08-28 09:51:17 +02:00
Jonas Brandstötter
89a4025c01
Fix Daily Challenge play count using a different colour than osu-web
2024-08-24 11:21:28 +02:00
Dean Herbert
1e39af8ac5
Add a bit of logging around medal awarding
...
Might help with https://github.com/ppy/osu/issues/29119 .
2024-08-23 19:49:24 +09:00
Dean Herbert
2a479a84dc
Remove conditional inhibiting seek when beatmap change is not allowed
...
In testing I can't find a reason for this to exist. Blaming back shows
that it existed before we had `AllowTrackControl` and was likely being
used as a stop-gap measure to achieve the same thing. It's existed since
over 6 years ago.
Let's give removing it a try to fix some usability concerns?
Closes https://github.com/ppy/osu/issues/29563 .
2024-08-23 18:21:31 +09:00
Dean Herbert
60271fb0f7
Merge pull request #29564 from peppy/skinnable-components-what-2
...
Remove requirement of `base` calls to ensure user skin container layouts are retrieved
2024-08-23 17:52:46 +09:00
Bartłomiej Dach
bd6943ebc2
Merge pull request #29537 from normalid-awa/feature/song-select/allow-copy-url-from-context-menu
...
Allow copying beatmap link in song select carousel context menu
2024-08-22 14:03:39 +02:00
Bartłomiej Dach
b3e961f6c5
Merge pull request #29562 from peppy/remove-migration-leftover-message
...
Remove "leftover files" notification when migration partly fails
2024-08-22 12:32:44 +02:00
Bartłomiej Dach
a32a817305
Merge pull request #29512 from peppy/toolbar-pp-change-weird
...
Fix toolbar PP change showing `+0` instead of `0`
2024-08-22 12:08:12 +02:00
Dean Herbert
f37cab0c6e
Rename SkinComponentsContainerLookup to GlobalSkinnableContainerLookup
2024-08-22 18:39:36 +09:00
Bartłomiej Dach
1859e173f2
Fix EVEN MORE code quality inspections!
2024-08-22 11:16:24 +02:00
Bartłomiej Dach
9997271a6a
Fix more code quality inspections
2024-08-22 10:49:24 +02:00
Dean Herbert
41756520b1
Rename SkinComponentsContainer to SkinnableContainer
2024-08-22 17:42:50 +09:00
Bartłomiej Dach
9020739f36
Remove unused using directives
2024-08-22 10:05:45 +02:00
Dean Herbert
67f0ea5d7d
Fix flooring causing delta to not work as expected
2024-08-22 16:22:00 +09:00
Dean Herbert
b3be04aff1
Remove "leftover files" notification when migration partly fails
...
People were deleting files they shouldn't, causing osu! to lose track of
where the real user files are.
For now let's just keep things simple and not let the users know that
some files got left behind. Usually the files which are left behind are
minimal and it should be fine to leave this up to the user.
Closes https://github.com/ppy/osu/issues/29505 .
2024-08-22 16:09:11 +09:00
Salman Ahmed
1efa6b7221
Merge if branches
2024-08-22 05:40:43 +09:00
Salman Ahmed
fc02b4b942
Alter NRT usage
2024-08-22 05:39:57 +09:00
Dean Herbert
87123d99bf
Move URL implementation to extension methods and share with other usages
2024-08-22 02:08:01 +09:00
OliBomby
ae6d855f8d
Merge remote-tracking branch 'upstream/master' into doubleclick
2024-08-20 23:19:27 +02:00
Salman Ahmed
b7599dd1f8
Keep mod customisation panel open when dragging a drawable
2024-08-21 03:23:23 +09:00
Dean Herbert
610ebc5481
Fix toolbar PP change showing +0 instead of 0
2024-08-19 20:50:11 +09:00
Dean Herbert
005b1038a3
Change "hold for menu" button to only show for touch by default
2024-08-19 20:23:25 +09:00
Dan Balasescu
03188e40ee
Merge pull request #29504 from peppy/skin-editor-fix-sidebar-reload
...
Fix skin editor components sidebar not reloading when changing skins
2024-08-19 18:13:52 +09:00
Dean Herbert
1bd2f4c6a2
Fix skin editor components sidebar not reloading when changing skins
...
Closes https://github.com/ppy/osu/issues/29098 .
2024-08-19 15:45:18 +09:00
Dean Herbert
4a3f4c3a55
Don't duck music when effect volume is set to zero
...
Addresses https://github.com/ppy/osu/discussions/28984 .
2024-08-19 14:46:50 +09:00
Dan Balasescu
f882ad4a53
Add localisation for daily challenge day/week units
2024-08-14 15:10:55 +09:00
Salman Ahmed
c9b2a5bb9c
Fix user profile overlay colour resetting when changing rulesets
2024-08-13 13:03:31 +03:00
Dan Balasescu
3f02869bcc
Enable NRT while we're here
2024-08-13 16:08:06 +09:00
CloneWith
ca91726190
Reload wiki page on language change
2024-08-13 13:34:11 +08:00
CloneWith
64468bce6d
Merge github.com:ppy/osu into patch/wiki-locale
2024-08-13 11:51:14 +08:00
CloneWith
7cbb4ab6f1
Get in-game locale for wiki pages
2024-08-13 11:50:33 +08:00
Bartłomiej Dach
06c2952fe8
Merge branch 'master' into grids-3
2024-08-12 13:55:35 +02:00
Dan Balasescu
179a3ad8dd
Hack around the border looking ugly
...
This is an o!f issue because borders are applied into the individual
sprites of the container via masking, rather than being isolated to the
container itself. In this case, it'll be applied to the "flash" sprite,
which is using additive blending, causing further issues.
2024-08-09 19:55:57 +09:00
Dean Herbert
fa9a835eb5
Make icon smaller
2024-08-09 19:29:23 +09:00
Dean Herbert
d84d0310e0
Move mute button to master volume circle
2024-08-08 22:06:13 +09:00
Bartłomiej Dach
f83d43c38b
Get rid of weird method
2024-08-07 14:07:20 +02:00
Bartłomiej Dach
e6d5389608
Merge branch 'master' into hover-open-mod-customise
2024-08-07 14:05:19 +02:00
Bartłomiej Dach
518c1aa5a0
Remove weird Expanded / ExpandedState duality
2024-08-07 14:01:30 +02:00
Dean Herbert
a61bf670d8
Highlight mentions in chat
2024-08-07 01:33:56 +09:00
Dean Herbert
9ccd8c906d
Merge branch 'master' into hover-open-mod-customise
2024-08-06 18:35:35 +09:00
Joseph Madamba
2daf1b58f2
Allow searching enum descriptions from SettingsEnumDropdowns
2024-08-03 14:48:08 -07:00
Dean Herbert
7765d0ff70
Merge pull request #29157 from frenzibyte/user-profile-daily-challenge-streak-display
...
Add daily challenge stats display to user profile overlay
2024-08-03 23:57:19 +09:00
Dean Herbert
d95d63d7ee
Undo localisation of Daily Challenge string for now
2024-08-03 22:44:51 +09:00
