53832 Commits

This Branch

This Branch

All Branches

• Merge pull request #19400 from peppy/button-select-allow-more

  Always allow selecting the top-most button using the select binding

  Dan Balasescu · 2022-07-26 18:49:42 +09:00
  b47f674ddb
• Merge pull request #19402 from peppy/debugger-attached-audio-warning-disable

  Don't show audio playback issue notification if debugger is attached

  Dan Balasescu · 2022-07-26 18:49:33 +09:00
  bc60552694
• Merge pull request #19378 from peppy/beatmap-update-test

  Add separate beatmap update flow to handle edge cases better

  Dan Balasescu · 2022-07-26 18:49:20 +09:00
  8f7dff5c2c
• Don't show audio playback issue notification if debugger is attached

  I've hit this countless times recently when debugging during the startup
  procedure.

  Dean Herbert · 2022-07-26 18:20:46 +09:00
  e782590b3c
• Fix new update pathway not actually being used
  Dean Herbert · 2022-07-26 17:58:09 +09:00
  9173271900
• Always allow selecting the top-most button using the select binding
  Dean Herbert · 2022-07-26 17:46:23 +09:00
  1539fa704b
• Merge pull request #19399 from frenzibyte/carousel-order-stability

  Maintain sort stability by using carousel item ID as a fallback

  Dean Herbert · 2022-07-26 17:33:30 +09:00
  6ff44ed2c6
• Merge branch 'master' into beatmap-update-test
  Dean Herbert · 2022-07-26 17:27:36 +09:00
  7f75184a01
• Add test coverage of no online ID scenario
  Dean Herbert · 2022-07-26 17:27:23 +09:00
  ee694c1257
• Add comprehensive test coverage of update scenarios
  Dean Herbert · 2022-07-26 17:22:52 +09:00
  1221cb1a42
• Merge pull request #19249 from andy840119/remove-nullable-disable-in-the-mods-for-catch-ruleset

  Remove nullable disable annotation in mods for catch ruleset.

  Salman Ahmed · 2022-07-26 11:10:41 +03:00
  f90604d873
• Fix incorrect handling if an update is processed with no changes
  Dean Herbert · 2022-07-26 17:00:28 +09:00
  4c22b55ce3
• Merge branch 'master' into remove-nullable-disable-in-the-mods-for-catch-ruleset
  andy · 2022-07-26 15:37:30 +08:00
  88db835e76
• Merge pull request #19392 from peppy/fix-test-leftovers

  Avoid leaving left-over files after test run completes

  Dan Balasescu · 2022-07-26 16:33:14 +09:00
  28e81b7c32
• Refactor new tests to not suck as much as the old importer tests
  Dean Herbert · 2022-07-26 16:33:00 +09:00
  846291d203
• Merge pull request #19393 from peppy/fix-statistics-panel

  Avoid potential realm fetch after disposal in `StatisticsPanel`

  Dan Balasescu · 2022-07-26 16:32:59 +09:00
  412d42b907
• Improve existing test coverage to cover order changes from other sort modes
  Salman Ahmed · 2022-07-26 10:24:51 +03:00
  91ffa7007f
• Make item ID comparer static
  Salman Ahmed · 2022-07-26 09:55:37 +03:00
  a4f6f2b9eb
• Revert one more missed change
  Dean Herbert · 2022-07-26 15:54:10 +09:00
  9939866f7d
• Add ImportAsUpdate method to IModelImporter to avoid otehr changes
  Dean Herbert · 2022-07-26 15:49:04 +09:00
  8370ca9765
• Remove remaining uses of "child" terminology in non-drawable components
  Salman Ahmed · 2022-07-26 09:43:47 +03:00
  693ac8750c
• Maintain sort stability by using carousel item ID as fallback
  Salman Ahmed · 2022-07-26 09:40:41 +03:00
  d7ef4170be
• Merge pull request #19377 from frenzibyte/fix-timeline-tests

  Fix intermittent timeline zoom test failures

  Dean Herbert · 2022-07-26 15:18:35 +09:00
  4efe09e7c2
• Merge pull request #19389 from peppy/cursor-with-touch

  Add ability to make cursor show even during touch input

  Dan Balasescu · 2022-07-26 15:13:55 +09:00
  5345e431cc
• Avoid potential realm fetch after disposal in StatisticsPanel

  As seen at https://github.com/ppy/osu/runs/7513799859?check_suite_focus=true.

  Dean Herbert · 2022-07-26 15:12:23 +09:00
  99bdf41717
• Fix left over resource file which isn't actually imported
  Dean Herbert · 2022-07-26 15:08:18 +09:00
  ac553d22ea
• Avoid leaving left-over files after test run completes
  Dean Herbert · 2022-07-26 15:08:18 +09:00
  59d3cc52c4
• Move tests to own class
  Dean Herbert · 2022-07-26 14:53:20 +09:00
  7d8a78ef01
• Remove unused method
  Dan Balasescu · 2022-07-26 14:15:59 +09:00
  1b2158ff04
• Rename MenuCursorContainer and clean up code
  Dean Herbert · 2022-07-26 14:11:52 +09:00
  ef10145d6f
• Add ability to make cursor show even during touch input

  I completely disagree with this from a UX perspective, but it's come up
  so often that I figure we should just let users bone themselves.

  Dean Herbert · 2022-07-26 14:08:00 +09:00
  ee0c67e114
• Merge pull request #19379 from frenzibyte/remove-submittable-score

  Remove no longer necessary API score models

  Dan Balasescu · 2022-07-26 14:07:40 +09:00
  a7598c62ac
• Fix scenario where import is expected to be empty
  Dean Herbert · 2022-07-25 23:59:27 +09:00
  d41ac36a69
• Use longer hash string
  Salman Ahmed · 2022-07-25 15:19:32 +03:00
  e5355f314d
• Fix test nullability assertions
  Dean Herbert · 2022-07-25 20:06:37 +09:00
  9c411c2250
• Fix some realm pieces not being cleaned up
  Dean Herbert · 2022-07-25 19:51:19 +09:00
  8a0c8f5fd8
• Add test coverage of actual update flow
  Dean Herbert · 2022-07-25 19:51:19 +09:00
  92dd1bcddb
• Move implementation of updating a beatmap to BeatmapImporter
  Dean Herbert · 2022-07-25 19:51:19 +09:00
  2e14d8730c
• Persist DateAdded over beatmap updates
  Dean Herbert · 2022-07-25 19:51:19 +09:00
  2363a3fb7b
• Ensure previous version prior to update loses online info after marked pending delete
  Dean Herbert · 2022-07-25 19:51:19 +09:00
  e5ad07454c
• Ensure scores are transferred after beatmap update if difficulty hash didn't change
  Dean Herbert · 2022-07-25 19:51:19 +09:00
  912218e123
• Fix old version of beatmap potentially not being deleted during update flow

  This can happen if the online IDs are not present in the `.osu` files.
  Previously this was only working due to the early logic in the import
  process (that relies on matching all online IDs perfectly).

  Dean Herbert · 2022-07-25 19:51:19 +09:00
  b7f6413bce
• Centralise calls to reset online info of a BeatmapInfo
  Dean Herbert · 2022-07-25 19:51:19 +09:00
  6a3e8e31de
• Add basic coverage of current behaviour of beatmap reimport
  Dean Herbert · 2022-07-25 19:51:19 +09:00
  ec477a3ebf
• Remove SubmittableScore and replace with SoloScoreInfo extension method
  Salman Ahmed · 2022-07-25 13:43:43 +03:00
  1b6ebcfd87
• Remove APIScore and replace its final usage
  Salman Ahmed · 2022-07-25 13:13:46 +03:00
  d04df19c7e
• Merge pull request #19371 from peppy/fix-working-cache-invalidation

  Fix calls to `GetWorkingBeatmap` invalidating cache too often

  Dan Balasescu · 2022-07-25 18:29:46 +09:00
  068063a43a
• Merge pull request #19373 from peppy/fix-negative-star-rating-display

  Fix star ratings which are still being calculated showing as "-1" at song select

  Dan Balasescu · 2022-07-25 18:20:30 +09:00
  1d48cee230
• Merge pull request #19374 from peppy/fps-counter-no-scheduler

  Refactor `FPSCounter` to not use scheduled tasks

  Dan Balasescu · 2022-07-25 18:19:59 +09:00
  6937296192
• Mark SetupZoom and parameterless ZoomableScrollContainer ctor as protected
  Salman Ahmed · 2022-07-25 12:07:50 +03:00
  48bcf57066