AbstractQbit
01d2f4f17a
Make allowTrackAdjustmentsStack readonly
2021-09-14 18:04:43 +03:00
AbstractQbit
b9193aae6d
Make IOsuScreen.AllowTrackAdjustments nullable
...
Allows for inheriting value from the previous screen if undefined
2021-09-14 17:37:57 +03:00
Dean Herbert
7c60c6a733
Merge pull request #14571 from rednir/get-user-from-username
...
Add ability to open user profile links with username instead of user ID
2021-09-06 00:15:09 +09:00
Davran Dilshat
e5f886a315
revert unnecessary change
2021-09-05 10:45:38 +01:00
Joseph Madamba
a773a22726
Fix toolbar hiding when clicking home button
2021-08-31 14:29:16 -07:00
rednir
c789163d01
use user ID overload when its supposed to be used
...
Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>
2021-08-30 13:22:12 +01:00
Davran Dilshat
90c313e2ad
add methods to get a user from their username
2021-08-29 19:19:55 +01:00
Joseph Madamba
38912bfc16
Fix floating overlays not closing when clicking some empty area of the toolbar
2021-08-28 20:38:35 -07:00
Salman Ahmed
9a6ff29951
Reword comment
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2021-08-21 15:39:57 +03:00
Salman Ahmed
1729d43cec
Add explanatory comment
2021-08-21 15:18:03 +03:00
Salman Ahmed
20f193c1c2
Fix screen offsetting not handling scaled game instances
...
By using `Content` instead, now the logic will get the X of the settings
overlay at the `Content` space, which can be scaled in the
`ScalingMode.Everything` mode.
And in the case of `ScalingMode.ExcludeOverlays`, a subcontainer
somewhere inside `Content` that's holding the screen stack would be scaled,
but `Content` won't be affected which is what we want in that case.
2021-08-21 04:16:12 +03:00
Dean Herbert
82eddeffef
Add LocalUserPlayInfo interface to convey common information about player status
2021-08-17 16:15:47 +09:00
Dean Herbert
93b97e5110
Adjust ratio to match previous behaviour
2021-08-13 16:35:22 +09:00
Dean Herbert
c1d67976e6
Rename const, add xmldoc and make protected
2021-08-13 16:29:36 +09:00
Salman Ahmed
bb1d74255e
Remove unrequired parenthesis
2021-08-12 14:16:20 +03:00
Salman Ahmed
3d7866e82d
Calculate horizontal offset on present overlays only
2021-08-12 14:15:01 +03:00
Salman Ahmed
b58b5ec2b4
Apply horizontal offset changing once per frame
...
The previous way was causing every-frame invalidation when an overlay is
visible.
2021-08-12 12:44:38 +03:00
Salman Ahmed
d099bb8ab6
Calculate offsets from overlay ScreenSpaceDrawQuads instead
2021-08-07 21:08:26 +03:00
Salman Ahmed
e924ea8d93
Make ScreenOffsetContainer privatly settable only
2021-08-07 18:52:27 +03:00
Salman Ahmed
8dc0650ca7
Add test coverage
2021-08-06 22:56:43 +03:00
Salman Ahmed
f77037ef57
Replace state-based screen offsetting logic with HorizontalScreenOffsets
2021-08-06 18:38:57 +03:00
Henry Lin
89e8296eb1
Reset all types of adjustments in MusicController; Rename AllowRateAdjustments to AllowTrackAdjustments
2021-07-29 15:39:26 +08:00
Bartłomiej Dach
b1087d14f3
Merge branch 'master' into skin-editor-button-access
2021-07-22 22:49:44 +02:00
Dean Herbert
db6f323266
Output startup component load start/end times to non-debug logs
...
Useful for diagnosing issues in cases like #13981 .
2021-07-22 14:45:57 +09:00
Dean Herbert
9c4fbf45e9
Add the ability to enter and exit the skin editor via on-screen buttons
2021-07-20 19:36:12 +09:00
Dean Herbert
ed29646291
Remove IApplicableToDifficulty.ReadFromDifficulty
...
This was added specifically for `ModDifficultyAdjust`, but turned out to
be more of a headache than we expected. We have since removed usage and
would hope that this is not required by any other mods.
Opting for complete removal rather than obsoletion, as we discovered
this was already broken in multiple cases, with fixes being quite
logically complex.
If you happen to be a ruleset developer relying on this, open an issue
and we'll talk you through a better approach (or check what
`ModDifficultyAdjust` is doing now for an example).
2021-07-14 12:32:16 +09:00
Bartłomiej Dach
fbe3b447e5
Merge branch 'master' into linkify-metadata
2021-07-03 15:51:08 +02:00
Bartłomiej Dach
16d08df5e2
Remove mention of direct from xmldoc
2021-07-03 15:22:03 +02:00
Dean Herbert
f2d9d78455
Fix some incorrectly invoked async calls
2021-07-02 14:43:48 +09:00
Dean Herbert
31dbc7798b
Merge branch 'master' into linkify-metadata
2021-07-01 19:41:33 +09:00
Dean Herbert
3816c486d5
Guard against a potential startup crash if user's preferred ruleset has a compatibility issue
...
Resolves this issue seen at https://github.com/ppy/osu/issues/13722#issuecomment-872088071 .
2021-07-01 19:03:58 +09:00
Dean Herbert
b6e07ff59c
Merge pull request #13572 from bdach/fix-unsupported-locales
...
Fix game crashes due to attempting localisation load for unsupported locales
2021-06-19 17:09:39 +09:00
Dean Herbert
afcc3e14f4
m
2021-06-19 16:16:29 +09:00
Bartłomiej Dach
76db87f9cb
Try-catch around localisation store registration
...
Some platforms (android, older windows versions) will throw exceptions
at runtime when an unsupported `CultureInfo` is attempted to be
instantiated, leading to nasty crashes. Add a preventative try-catch
registration to prevent the crash, and log the errors for visibility.
2021-06-19 08:02:30 +02:00
Dean Herbert
d06e52505a
Fix thread safety of KeyBindingStore.GetReadableKeyCombinationsFor
2021-06-18 17:11:39 +09:00
smoogipoo
19f0e3d695
Add HighPerformanceSession
2021-06-16 20:53:48 +09:00
Bartłomiej Dach
cc5145a131
Fix languages with a sub-language part not working properly
2021-06-16 11:10:03 +02:00
Dean Herbert
68fa7d68cc
Merge pull request #13511 from smoogipoo/fix-possible-nullref-2
...
Fix possible nullref in difficulty recommender
2021-06-16 15:20:45 +09:00
smoogipoo
a5261f0cb3
Add difficulty recommender instantly
2021-06-16 11:48:49 +09:00
smoogipoo
579a4aa9c8
Remove comment
2021-06-15 14:10:09 +09:00
smoogipoo
eb4c093371
Use hash as fallback
2021-06-15 14:06:17 +09:00
smoogipoo
f6c6eea6dc
Make PresentScore() only consider replay hash
2021-06-15 11:16:35 +09:00
Dean Herbert
26312bf60a
Merge branch 'master' into chat-mention
2021-06-11 20:03:44 +09:00
Dean Herbert
3d645608eb
Remove nullability of DI dependencies and fix incorrect load order
2021-06-11 16:28:53 +09:00
smoogipoo
0b9916b266
Add parens to declare operator precedence
2021-06-08 18:39:52 +09:00
smoogipoo
860f1aebb3
Only call OnBackButton() if the screen has finished loading
2021-06-08 17:38:12 +09:00
Craftplacer
39c3b08fc7
Merge remote-tracking branch 'upstream/master' into chat-mention
2021-06-05 11:18:06 +02:00
Dean Herbert
145e42928b
Fix remaining null checks
2021-06-01 16:49:05 +09:00
Dean Herbert
52ca2f4797
Merge branch 'master' into chat-mention
2021-05-26 16:00:26 +09:00
Dean Herbert
b13a68592f
Merge branch 'master' into localisation-proof-of-concept
2021-05-22 17:07:23 +09:00
Dean Herbert
b0a113a36b
Merge branch 'master' into localisation-proof-of-concept
2021-05-21 17:57:54 +09:00
Lucas A
dabe8bd4c7
Fix code inspections and remove now unused code.
2021-05-17 12:55:58 +02:00
Lucas A
851e33fd15
Hook up StableImportManager.
2021-05-17 12:55:57 +02:00
Gagah Pangeran Rosfatiputra
f2de28814a
add and handle OpenWiki link action
2021-05-17 00:43:59 +07:00
smoogipoo
cd25d76dbe
Merge branch 'master' into localisation-proof-of-concept
2021-05-08 18:11:07 +09:00
Dean Herbert
aff32b0d19
Merge branch 'master' into skin-components-list
2021-05-06 14:17:33 +09:00
Dean Herbert
df8609b3dc
Move private field for skin editor overlay to where others exist
2021-05-03 15:17:04 +09:00
Dean Herbert
f3b305bbe6
Rename and improve xmldoc of SkinEditorOverlay
2021-05-03 14:58:25 +09:00
Dean Herbert
20ff05c9ff
Fix crosstalk between notification/setting overlay nudge padding and skin overlay position adjust
2021-04-30 13:10:42 +09:00
Dean Herbert
63435ba548
Ensure toolbar doesn't overlap editor content
2021-04-29 17:41:07 +09:00
Dean Herbert
b936043956
Add the skin editor to the game
2021-04-29 17:20:22 +09:00
Gagah Pangeran Rosfatiputra
004cd7c834
add wiki button in main toolbar
2021-04-22 16:16:12 +07:00
Dean Herbert
623eae1576
Add basic language switching ability
2021-04-20 17:06:01 +09:00
jvyden
ffc1e841e0
Fix sessionIdleTracker not being properly added to OsuGame
2021-04-19 01:06:26 -04:00
Dean Herbert
dbb8f7f4a9
Tidy up initialisation code and avoid using DI on inherited class
2021-04-19 11:30:55 +09:00
jvyden
9c6914d29d
Fix redundant lambda parentheses
2021-04-16 06:26:45 -04:00
jvyden
ec0211809f
Apply peppy's suggestions
2021-04-16 05:53:27 -04:00
jvyden
43e6e5e049
increase GameIdleTracker time to 5 minutes
2021-04-16 05:15:58 -04:00
jvyden
7d23973ef8
Reset SessionStatics on activity
...
Closes #12424
2021-04-16 05:01:58 -04:00
Dean Herbert
beebdb0734
Clean up implementation
2021-04-05 22:30:51 +09:00
Dean Herbert
a2f50af424
Fix fall-through scroll redirection
2021-03-30 19:42:40 +09:00
Dean Herbert
f95175983a
Make code more concise and move method to a more appropriate place
2021-03-24 13:37:37 +09:00
Owen Young
c8542d2434
Merge branch 'master' into default-fullscreen
2021-03-23 19:44:22 -05:00
Owen Young
437dadc85f
Changed comment on GetFrameworkConfigDefaults() to be more accurate
2021-03-23 19:37:55 -05:00
Owen Young
67a03ebc23
Fixed formatting issues to be in line with osu coding standards
2021-03-23 19:31:16 -05:00
Owen Young
fbb992fc7e
Added a comment to new method
2021-03-23 19:18:32 -05:00
Owen Young
254b0f5dc3
removed line (?) - tried doing testing to see if it launched in fullscreen (i.e., overriding the method ppy mentioned), but to no avail :(
2021-03-23 00:24:33 -05:00
Owen Young
d9e2c44a34
implemented GetFrameworkConfigDefaults for overriding framework default, removed previous code that added a new OsuSetting and modified settings layout.
2021-03-22 23:36:55 -05:00
Owen Young
9f788f5854
removed code from OsuGameBase for fullscreen.....OsuSetting still exists but cannot figure out a way to set it to a default and have it actually work
2021-03-22 22:52:16 -05:00
Owen Young
8ea7271d5c
moved windowmode code to LoadComplete (?)
2021-03-22 19:48:52 -05:00
Owen Young
fc632fd48a
Added WindowSetting setting to OsuSetting enum so that it can be set by default at startup. Modified LayoutSettings.cs so that when it is changed in the settings, it is written to the local settings as well.
2021-03-22 01:30:20 -05:00
owen-young
f7bf23dbe9
first attempt at changing windowMode to be fullscreen on default
2021-03-21 21:50:19 -05:00
Dean Herbert
095b7f8668
Rewrite code to account for non-loaded edge case
2021-03-19 20:09:12 +09:00
Dean Herbert
bd1e2da1c2
Always hide other overlays, even if the new one is not loaded
2021-03-19 19:09:39 +09:00
Dean Herbert
a9c4fa442a
Avoid potential crash if an overlay is toggled before it has been loaded
2021-03-19 16:49:09 +09:00
Dean Herbert
249ab8ab3d
Merge branch 'master' into input-handler-configuration
2021-03-17 18:05:14 +09:00
smoogipoo
da3dc61aae
Remove newline
2021-03-16 10:58:42 +09:00
Joehu
3dd72d6f7d
Fix disable mouse buttons setting not showing default indicator when using keybind
2021-03-14 22:47:05 -07:00
Joehu
0ba5312a40
Move blocking show logic to UpdateState
2021-03-13 00:05:26 -08:00
Joehu
62f2a823f6
Hide toolbar forever when the user hides it
2021-03-12 15:48:50 -08:00
Joehu
6c0734a09f
Handle global action in toolbar instead of osugame
2021-03-12 15:48:49 -08:00
Dean Herbert
86164c027a
Update the method we use to reset input settings
2021-03-12 18:44:10 +09:00
Dean Herbert
b1cd01ceb8
Apply ConfigureAwait changes to game side
2021-03-08 14:36:35 +09:00
Salman Ahmed
fe64c3dbd4
Refrain from disabling cursor sensitivity at config-level
2021-03-04 17:00:44 +03:00
Dean Herbert
7c59040082
Re-present even when already the current beatmap
...
This feels better and closer to what a user would expect.
2021-03-03 14:17:07 +09:00
Dean Herbert
fcea900a53
Move main menu (song select) presentation logic to a local implementation
...
Reduces cross-dependencies between OsuGame and MainMenu.
2021-03-03 14:13:51 +09:00
Dean Herbert
36e1fb6da8
Add flow to allow MatchSubScreen to handle beatmap presentation locally
2021-03-03 14:13:51 +09:00
Dean Herbert
d85a4a22e5
Allow beatmap imports from any derived version of SongSelect, rather than only PlaySongSelect
2021-02-18 19:19:28 +09:00
Dean Herbert
a080a9bdbc
Merge pull request #11603 from Game4all/handle-stable-imports-custom-songs-folder
...
Handle beatmap import from a stable installation with a custom Songs directory
2021-02-12 21:42:36 +09:00
Jamie Taylor
2ee634d173
Create subclass for "Error" notifications to allow them to have a unique pop-in sound
2021-02-11 13:55:43 +09:00
