61161 Commits

This Branch

This Branch

All Branches

• Use correct perMonitorV2 <dpiAwareness>

  Yes, `xmlns="http://schemas.microsoft.com/SMI/2016/WindowsSettings"` is required
  else the game will exit with code 500 on startup.

  Susko3 · 2023-06-30 21:59:46 +02:00
  b0e716feab
• Update <supportedOS> to match what osu! actually supports
  Susko3 · 2023-06-30 21:43:01 +02:00
  bfa5bcb2a7
• Remove unnecessary <dependentAssembly>

  osu! was working fine without this.

  Susko3 · 2023-06-30 21:41:18 +02:00
  909edefa20
• Merge the two app.manifest files
  Susko3 · 2023-06-30 21:40:00 +02:00
  e505e71d07
• Merge pull request #24080 from peppy/star-rating-no-rounding

  Never remove significant digits from star rating displays

  Bartłomiej Dach · 2023-06-29 21:27:30 +02:00
  1f3d833b05
• Never remove significant digits from stsar rating displays

  Closes https://github.com/ppy/osu/issues/24079.

  Dean Herbert · 2023-06-29 13:55:04 +09:00
  34f53965c4
• Merge pull request #24076 from bastianpedersen/localise-chat-notifications

  Localise chat related notifications

  Bartłomiej Dach · 2023-06-28 22:36:53 +02:00
  90cb3dac86
• Merge pull request #24070 from peppy/fix-flip-undo-states

  Trigger state change when flipping via hotkey in the editor

  Bartłomiej Dach · 2023-06-28 22:24:31 +02:00
  81e759cb6b
• Localise chat related notifications
  Bastian Pedersen · 2023-06-28 21:11:56 +02:00
  ea87000539
• Merge branch 'master' into fix-flip-undo-states
  Bartłomiej Dach · 2023-06-28 20:49:42 +02:00
  27eef6996b
• Merge pull request #24060 from peppy/fix-editor-save-failure

  Fix incorrect realm copy logic when a beatmap becomes detached from its set

  Bartłomiej Dach · 2023-06-28 20:49:21 +02:00
  05f1526c48
• Fix selection handlers eating hotkey presses they didn't handle
  Bartłomiej Dach · 2023-06-28 20:48:22 +02:00
  e4e08c0f5f
• Add failing tests covering correct flip handling
  Bartłomiej Dach · 2023-06-28 20:48:02 +02:00
  0940ab1e11
• Merge branch 'master' into fix-editor-save-failure
  Bartłomiej Dach · 2023-06-28 19:56:58 +02:00
  e1600b3d72
• Delete test case covering beatmap detach scenario

  Due to being fundamentally incompatible with the `Debug.Fail()` call
  added in 99e55bb9c0.
  
  This reverts commit 4ecc724841.

  Bartłomiej Dach · 2023-06-28 19:52:11 +02:00
  6ce0ca832e
• Trigger state change when flipping via hotkey in the editor

  This will trigger a change even if nothing happens. But I think that's
  okay (not easy to avoid) because the change handler should be aware that
  nothing changed, if anything.
  
  Closes https://github.com/ppy/osu/issues/24065.

  Dean Herbert · 2023-06-28 13:52:51 +09:00
  29376ffcc0
• Add logging and Debug.Fail on detached beatmap detection
  Dean Herbert · 2023-06-28 12:21:05 +09:00
  99e55bb9c0
• Merge pull request #24058 from peppy/full-term-exact-match

  Add support for matching full terms at song select using suffixed `!`

  Dean Herbert · 2023-06-28 12:14:15 +09:00
  1d4380cfd0
• Merge pull request #24067 from bdach/fix-difficulties-not-deleting-from-db

  Fix delete difficulty flow not actually deleting the difficulty from realm

  Dean Herbert · 2023-06-28 12:06:01 +09:00
  bc26d52dbd
• Merge pull request #24059 from peppy/add-editor-rotate-hotkeys

  Add support for `Ctrl` + `<` / `>` to rotate selection in editor

  Dean Herbert · 2023-06-28 12:03:34 +09:00
  076f41be12
• Fix difficulty deletion not deleting records from realm
  Bartłomiej Dach · 2023-06-27 23:43:00 +02:00
  6876566530
• Add test coverage for deleted difficulties staying in realm
  Bartłomiej Dach · 2023-06-27 23:40:12 +02:00
  d72a8da295
• Merge pull request #24064 from bastianpedersen/localise-common-game-notifications

  Localise common game notifications

  Bartłomiej Dach · 2023-06-27 22:40:22 +02:00
  eb82bd3871
• Fix hotkey presses generating unnecessary undo history

  The buttons don't check whether the operation they correspond to is
  possible to perform in the current state of the selection box, so not
  checking `Can{Reverse,Rotate}` causes superfluous undo states to be
  added without any real changes if an attempt is made to reverse or
  rotate a selection that cannot be reversed or rotated.

  Bartłomiej Dach · 2023-06-27 22:25:04 +02:00
  9be2d9d62e
• Add test coverage for rotate hotkeys
  Bartłomiej Dach · 2023-06-27 22:10:53 +02:00
  444f71541a
• Mention hotkeys in button tooltips
  Bartłomiej Dach · 2023-06-27 22:04:15 +02:00
  17ed45d07c
• Switch to == true
  Bartłomiej Dach · 2023-06-27 22:02:15 +02:00
  54280f06be
• Enable NRT in SelectionBox
  Bartłomiej Dach · 2023-06-27 22:01:44 +02:00
  ad3a470eaf
• Merge pull request #23926 from ItsShamed/hud/kc-skinnable

  Make key counter skinnable

  Bartłomiej Dach · 2023-06-27 21:57:41 +02:00
  eb6bdb5a38
• Add test cases covering full phrase case insensitivity
  Bartłomiej Dach · 2023-06-27 21:50:39 +02:00
  bca1a91087
• Trim full phrase filters in a more precise manner
  Bartłomiej Dach · 2023-06-27 21:50:36 +02:00
  bf99fc61b8
• Add test case for full phrase match mode trimming chars from inside phrase
  Bartłomiej Dach · 2023-06-27 21:45:52 +02:00
  aba380b001
• Rename MatchMode.{None -> Substring}
  Bartłomiej Dach · 2023-06-27 21:28:37 +02:00
  e3d97b37f1
• Merge branch 'master' into full-term-exact-match
  Bartłomiej Dach · 2023-06-27 21:27:39 +02:00
  06654dc618
• Merge pull request #24057 from peppy/add-title-search-support

  Add missing "title=" search support at song select

  Bartłomiej Dach · 2023-06-27 21:25:09 +02:00
  d731b84c73
• Add even more safety against unloaded components
  Bartłomiej Dach · 2023-06-27 21:21:14 +02:00
  7052f87eb8
• Fix XML doc not mirroring string
  Bastian Pedersen · 2023-06-27 21:02:44 +02:00
  62dcd513ca
• Add back missing punctunation
  Bastian Pedersen · 2023-06-27 21:01:39 +02:00
  8a2cd57f4e
• Localise common game notifications
  Bastian Pedersen · 2023-06-27 20:56:35 +02:00
  37ee3a7bbd
• Add test coverage for title query parsing
  Bartłomiej Dach · 2023-06-27 20:41:03 +02:00
  11577d1df0
• Merge branch 'master' into hud/kc-skinnable
  Bartłomiej Dach · 2023-06-27 20:35:47 +02:00
  af66ccbfdf
• Fix broken test step
  Bartłomiej Dach · 2023-06-27 20:29:27 +02:00
  9681ee7eeb
• Attempt to fix more test failures
  Bartłomiej Dach · 2023-06-27 20:17:58 +02:00
  ada9c48bde
• Fix incorrect realm copy logic when a beatmap becomes detached from its set

  The code here was assuming that if the beatmap which is having changes
  copied across does not exist within the `BeatmapSet.Beatmaps` list, it
  was not yet persisted to realm.
  
  In some edge case, it can happen that the beatmap *is* persisted to
  realm but not correctly attached to the beatmap set. I don't yet know
  how this occurs, but it has caused loss of data for at least two users.
  
  The fix here is to check realm-wide for the beatmap (using its primary
  key) rather than only in the list. We then handle the scenario where the
  beatmap needs to be reattached to the set as a seprate step.
  
  ---
  
  This does raise others questions like "are we even structuring this
  correctly? couldn't a single beatmap exist in two different sets?"
  
  Maybe, but let's deal with that if/when it comes up.

  Dean Herbert · 2023-06-27 18:20:01 +09:00
  8e80e2fa32
• Add test coverage of save failure when beatmap is detached from set
  Dean Herbert · 2023-06-27 18:18:58 +09:00
  4ecc724841
• Add support for Ctrl + < / > to rotate selection in editor

  As discussed in https://github.com/ppy/osu/discussions/24048.

  Dean Herbert · 2023-06-27 17:01:41 +09:00
  c6d952abe3
• Add a visual effect when keyboard shortcuts are used to trigger selection box buttons
  Dean Herbert · 2023-06-27 17:01:13 +09:00
  7ddbf4eaa7
• Change JudgementCountController to a Component and remove handling overrides
  Dean Herbert · 2023-06-27 16:39:21 +09:00
  41890cfc65
• Rename ClicksPerSecondCalculator to ClicksPerSecondController
  Dean Herbert · 2023-06-27 16:38:46 +09:00
  8bd6f7a46a
• Change JudgementCountController to a Component
  Dean Herbert · 2023-06-27 16:38:15 +09:00
  de23a4691e