277 Commits

• Merge branch 'master' into fruit-bindables
  Dan Balasescu · 2020-11-30 16:48:22 +09:00
  11d1450c76
• Remove unnecessary schedule logic from Apply's local updateState call

  There were cases in the editor where rewinding of transforms would
  leave the `DrawableHitObject` in a non-`IsPresent` state, resulting in
  this scheduled logic never running.
  
  This would in turn cause ghost hitobjects, which disappear under certain
  circumstances.
  
  Reproduction:
  
  - Open editor to empty beatmap
  - Place single hitcircle at current point in time
  - Drag editor timeline backwards to seek before zero, and wait for
    return to zero
  - Select hitcircle in playfield
  - Drag hitcircle to right in timeline, triggering a start time change

  Dean Herbert · 2020-11-27 16:32:05 +09:00
  18bb0cb45b
• Fix colour not updated when index changes
  ekrctb · 2020-11-27 11:41:39 +09:00
  e36bb7631d
• Remove hitObject argument from OnApply and OnFree
  ekrctb · 2020-11-27 10:13:05 +09:00
  57454bbb1c
• Merge pull request #10961 from smoogipoo/better-dho-rewind

  Rewind pooled DHOs into better states

  Dean Herbert · 2020-11-27 00:42:58 +09:00
  b1864670a2
• Add xmldoc on State
  smoogipoo · 2020-11-26 23:42:05 +09:00
  aa4da2a5f8
• Completely separate combo colours from DHOs
  smoogipoo · 2020-11-26 18:14:25 +09:00
  e53f849aa0
• Rewind pooled DHOs into better states
  smoogipoo · 2020-11-26 00:42:25 +09:00
  c744db1b57
• Merge branch 'master' into on-drawable-hitobject-added
  Dan Balasescu · 2020-11-24 16:09:57 +09:00
  87ce8a53ff
• Add comment covering intentional call to ClearTransformsAfter
  Dean Herbert · 2020-11-23 15:20:59 +09:00
  19faa2b9bb
• Address @bdach's minor suggestions
  ekrctb · 2020-11-22 18:51:16 +09:00
  666112cb5a
• Add HasInitialized to DHO

  As it turned out, `IsLoaded` is not a reliable way.

  ekrctb · 2020-11-21 11:19:52 +09:00
  281ed49332
• Rework and rename to OnNewDrawableHitObject.

  The semantics is changed and hopefully more clear.

  ekrctb · 2020-11-21 00:27:19 +09:00
  82aefa3868
• Add back removed InitialLifetimeOffset removal
  smoogipoo · 2020-11-16 21:49:29 +09:00
  cead67d512
• Merge pull request #10844 from bdach/spinner-rotation-tracker-state

  Fix rotation tracker state not being reset on drawable spinner re-use

  Dan Balasescu · 2020-11-16 17:10:40 +09:00
  09298139e1
• Clear existing transforms on DHO return to pool
  Bartłomiej Dach · 2020-11-15 19:50:22 +01:00
  9c0a0031d6
• Clear result when freeing pooled hitobject
  Bartłomiej Dach · 2020-11-14 21:09:22 +01:00
  f8cabbdd21
• Merge all pooling support into Playfield
  smoogipoo · 2020-11-14 00:59:08 +09:00
  c71b237c4f
• Move hitobject pooling to Playfield
  smoogipoo · 2020-11-14 00:41:18 +09:00
  36f1833f6e
• Merge branch 'master' into nested-hitobject-pooling
  Dean Herbert · 2020-11-13 16:53:20 +09:00
  06fd0d08d1
• Reduce the number of state updates
  smoogipoo · 2020-11-13 14:33:23 +09:00
  35329aa976
• Merge branch 'master' into hitobject-pooling-base
  Dan Balasescu · 2020-11-12 23:17:36 +09:00
  2840fd0f8f
• Fix samples not being disposed
  smoogipoo · 2020-11-12 18:48:25 +09:00
  261ddd2b4a
• Add support for nested hitobject pooling
  smoogipoo · 2020-11-12 17:43:51 +09:00
  a8c2b798ad
• Fix state update exception in a better way
  smoogipoo · 2020-11-11 19:01:12 +09:00
  606cfacedf
• Fix hitobjects sometimes not fading in completely with HD mod
  smoogipoo · 2020-11-11 16:35:48 +09:00
  5d55af5818
• Fix possible nullrefs
  smoogipoo · 2020-11-11 00:24:28 +09:00
  b725c9cce9
• Clear lifetimeEntry after use
  smoogipoo · 2020-11-11 00:24:14 +09:00
  e525784cb2
• Rewrite HitObjectContainer with pooling support
  smoogipoo · 2020-11-10 22:49:02 +09:00
  31e4d71852
• Add hitobject lifetime support
  smoogipoo · 2020-11-10 20:16:52 +09:00
  6f3f6dc28b
• Remove result storage from hitobject
  smoogipoo · 2020-11-10 18:56:16 +09:00
  88112801eb
• Revert unnecessary change
  smoogipoo · 2020-11-10 18:15:11 +09:00
  f5076fe3b8
• Disable automatic lifetime management
  smoogipoo · 2020-11-10 01:30:25 +09:00
  d4d3a6621e
• Update state after OnApply()
  smoogipoo · 2020-11-10 00:30:23 +09:00
  ac47399e6e
• Re-privatise start time bindable
  smoogipoo · 2020-11-09 21:51:58 +09:00
  ec8b726ea8
• Fix events not being bound correctly

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dan Balasescu · 2020-11-09 19:06:48 +09:00
  33c3b07101
• Prevent overrides from messing with application/freeing
  smoogipoo · 2020-11-07 00:40:26 +09:00
  b1e039bcec
• Fix DHOs being freed when not expected
  smoogipoo · 2020-11-07 00:25:26 +09:00
  3a4bd73823
• Change derived class to use property
  smoogipoo · 2020-11-06 23:04:28 +09:00
  7eceda242b
• Allow Apply() to be called multiple times sequentially
  smoogipoo · 2020-11-06 23:03:29 +09:00
  2d892c7407
• Initial Apply()/FreeAfterUse() DHO implementation
  smoogipoo · 2020-11-06 23:02:37 +09:00
  248d342a2f
• Fix judgement offsets being zero when windows are empty
  Dean Herbert · 2020-11-05 18:58:37 +09:00
  a0b3379909
• Merge branch 'master' into drawable-hit-object-hit-state-fix
  Dean Herbert · 2020-11-05 17:07:52 +09:00
  0cadb31947
• Use BDL for top-level osu! DHOs
  smoogipoo · 2020-11-05 13:51:46 +09:00
  9a7fcadabc
• Change order of execution to be chronological
  Dean Herbert · 2020-11-04 17:14:23 +09:00
  68b7efe4d5
• Always execute UpdateHitStateTransforms (even for idle)
  Dean Herbert · 2020-11-04 17:14:23 +09:00
  831325978a
• Remove parameter from StartTime method and add obsoleted previous version
  Dean Herbert · 2020-11-04 16:39:52 +09:00
  3b6cf95f49
• Add new method handling hit state specifically

  Until now UpdateStateTransforms was applying results offsets to
  StartTime. This didn't cover the case of a HitObject with duration,
  where the call would be made with `StartTime + hitOffset` rather than
  `EndTime + hitOffset`.
  
  To resolve this, a new method has been added which should be used to
  handle hit-specific state transforms.

  Dean Herbert · 2020-11-04 16:13:14 +09:00
  7f30140b7e
• Don't force playback of (non-looping) DrawableHitObject samples after skin change
  Dean Herbert · 2020-10-07 18:18:01 +09:00
  3c3c1ce885
• Rename method back and add xmldoc
  Dean Herbert · 2020-10-05 16:24:02 +09:00
  c622adde7a