Bartłomiej Dach
86c3e3e987
Replace FormSliderBar.Instantaneous with TransferValueOnCommit
...
Rather than control the propagation of the value between the slider and
the textbox, add a property that controls the propagation of the value
between the bindables inside the form control to external bindables.
This will help alleviate issues where the external bindable update
incurs overheads due to having heavy change callbacks attached.
2024-10-04 14:07:16 +02:00
Bartłomiej Dach
114e53f8b2
Add failing test
2024-10-04 10:00:37 +02:00
Bartłomiej Dach
1280d7ea15
Fix tests again
2024-10-03 15:05:15 +02:00
Bartłomiej Dach
8a650deab6
Fix tests
2024-10-03 13:11:02 +02:00
Bartłomiej Dach
b15608343b
Replace setup screen controls with new "form" controls
2024-10-03 11:49:03 +02:00
Bartłomiej Dach
df730e6b6f
Implement "form" colour palette control
2024-10-03 11:20:47 +02:00
Dean Herbert
54e68005ef
Merge pull request #29691 from bdach/hotkeys-in-context-menus
...
Add hotkey hints to editor menus
2024-10-01 19:29:05 +09:00
Dean Herbert
8ea1ff5de6
Merge pull request #30069 from peppy/grid-to-current-object
...
Add button to centre editor grid to current hit object
2024-10-01 19:24:46 +09:00
Dean Herbert
598bc74614
Merge pull request #30058 from bdach/disabled-beatmap-comment-box
...
Properly disable comment box on things that cannot be commented on
2024-10-01 18:52:40 +09:00
Bartłomiej Dach
44b982864c
Fix test failures
2024-10-01 11:12:56 +02:00
Bartłomiej Dach
8eb5e6b1d5
Merge branch 'master' into shuffle
2024-10-01 10:07:54 +02:00
Bartłomiej Dach
a9818854f4
Merge pull request #30024 from peppy/edit-url-decode
...
Fix editor timestamp URLs not working when they contain a space
2024-10-01 09:44:18 +02:00
Dean Herbert
87ab953935
Merge pull request #30062 from bdach/distance-snap-weirdness
...
Fix various distance snap grid weirdness around unsnapped objects
2024-10-01 16:16:22 +09:00
Dean Herbert
0bff7e8697
Merge pull request #30063 from bdach/snap-sliders-on-path-type-change
...
Ensure sliders are snapped when changing path types
2024-10-01 16:03:12 +09:00
Dean Herbert
590f27e0a0
Merge branch 'master' into hotkeys-in-context-menus
2024-10-01 15:50:19 +09:00
Bartłomiej Dach
493dcc7a1c
Fix test being dodgy
...
Hitobjects are in an indeterminate state until defaults are applied.
Adding the object to the beatmap will do this.
2024-09-30 14:38:21 +02:00
Bartłomiej Dach
155d6e57be
Isolate tests properly
2024-09-30 14:05:20 +02:00
Bartłomiej Dach
75fc57c34b
Fix distance spacing grid displaying incorrectly for unsnapped objects with duration
2024-09-30 13:36:16 +02:00
Bartłomiej Dach
4723efaf41
Add failing test coverage for incorrect distance snapping
2024-09-30 13:36:05 +02:00
Bartłomiej Dach
e91c8fb4bd
Properly disable comment box on beatmaps that cannot be commented on
...
Closes https://github.com/ppy/osu/issues/30052 .
Compare:
- 83816dbe24/resources/js/components/comment-editor.tsx (L54-L60)83816dbe24/resources/js/components/comment-editor.tsx (L47-L52)
2024-09-30 11:02:00 +02:00
Bartłomiej Dach
23b8354af4
Add more test steps demonstrating another failure case
2024-09-30 08:46:45 +02:00
Bartłomiej Dach
3fac9baa9f
Add test steps demonstrating failure case
2024-09-30 08:46:33 +02:00
Dean Herbert
a258059d43
Merge pull request #29918 from bdach/control-drag
...
Add to existing selection when dragging with control pressed
2024-09-30 14:00:36 +09:00
Dean Herbert
c46d787f1e
Merge pull request #29949 from minetoblend/feature/scale-around-center
...
Support scaling around center when scaling with select box
2024-09-28 21:37:39 +09:00
Dean Herbert
f6c5f975ee
Add failing test showing url decoding is not being performed
2024-09-27 20:08:26 +09:00
Bartłomiej Dach
eb725ec1fb
Nudge test coverage to also cover discovered fail case
2024-09-27 12:13:11 +02:00
Bartłomiej Dach
b45fedc356
Merge branch 'master' into control-drag
2024-09-27 11:39:50 +02:00
Bartłomiej Dach
a00ed8dd77
Merge pull request #29914 from peppy/fix-judgement-counter-sync
...
Fix judgement counter not showing correct counts when spectating user mid-play
2024-09-27 10:57:26 +02:00
Bartłomiej Dach
fa90b43233
Merge branch 'master' into selection-center
2024-09-27 09:30:36 +02:00
Dean Herbert
5efdc6cdd7
Merge pull request #29936 from u4vh3/skinning-colour-customisation
...
Add colour customisation to layout editor
2024-09-27 14:20:58 +09:00
Bartłomiej Dach
f4a4807449
Implement "form" file picker
2024-09-26 14:36:24 +02:00
Bartłomiej Dach
f16f419928
Merge pull request #29983 from bdach/directory-selector-redesign
...
Redesign directory & file selector
2024-09-26 14:14:22 +02:00
Dan Balasescu
fd4891cf31
Fix similar Bindable-related crashes
2024-09-25 20:59:35 +09:00
Bartłomiej Dach
555d4ffe89
Add failing test case
2024-09-24 17:51:54 +02:00
Bartłomiej Dach
7f8b64bb6d
Redesign directory & file selector (and update usages accordingly)
2024-09-24 14:54:48 +02:00
Marvin Schürz
15c4b1dc8f
Move mouse horizontally in test to make sure it doesn't accidentally maintain aspect ratio
2024-09-24 13:45:03 +02:00
Marvin Schürz
3ad7342964
Add tests for shift and alt modifiers in select box
2024-09-24 13:35:56 +02:00
Bartłomiej Dach
4f57a67ea4
Merge branch 'master' into skinning-colour-customisation
2024-09-24 13:02:22 +02:00
OliBomby
3031b68552
add TestMinimumEnclosingCircle
2024-09-24 11:56:04 +02:00
Bartłomiej Dach
d6c17f6ac0
Implement "form" dropdown control
2024-09-23 14:41:39 +02:00
OliBomby
a9ebfbe431
Assert default origin not null in rotation handle
2024-09-23 11:37:42 +02:00
Daniel Cios
59df9cbf0f
Remove nullable disable
2024-09-20 18:07:26 +02:00
Daniel Cios
1a48b46536
Fix test failures
2024-09-19 21:50:59 +02:00
Daniel Cios
b86f246095
Fix code inspection failure
2024-09-19 19:24:05 +02:00
Daniel Cios
c77afe2a13
Add tests
2024-09-19 17:27:26 +02:00
Dean Herbert
bd8addfb5f
Merge pull request #29897 from bdach/editor/setup-screen-slider
...
Implement "form" slider bar control
2024-09-19 19:07:14 +09:00
Dean Herbert
188a430418
Merge branch 'master' into grids-3
2024-09-19 18:21:05 +09:00
Bartłomiej Dach
2d3b027f85
Add test case covering desired behaviour
2024-09-18 15:18:13 +02:00
Bartłomiej Dach
12bd516a57
Shuffle playback order in global playlist by default
...
RFC. Closes https://github.com/ppy/osu/issues/18169 .
Implements the given proposal of keeping the current stable order but
adding a shuffle facility to the now playing overlay, and enabling it by
default.
There are more changes I want to make here but I'd like this to get
discussion first, because I am likely to continue putting this sort of
selection logic into `MusicController` and I just want to confirm nobody
is going to have a problem with that.
In particular this is not sharing the randomisation implementation with
beatmap carousel because it doesn't generalise nicely (song select cares
about the particular *beatmap difficulties* selected to rewind properly,
while the music controller only cares about picking a *beatmap set*).
2024-09-18 14:19:55 +02:00
Bartłomiej Dach
d506d8a150
Implement TabbableContentContainer for slider control
2024-09-18 11:32:55 +02:00
