65490 Commits

This Branch

This Branch

All Branches

• Remove usage of case-when
  Dean Herbert · 2023-12-05 16:58:16 +09:00
  02178d8e61
• Use DangerousActionDialog
  Dean Herbert · 2023-12-05 16:54:44 +09:00
  f317e06da1
• Merge pull request #25675 from vegguid/editor-setup-show-filename

  Changed the LabelledFileChooser in the setup to show the file name of the file that is was selected

  Dean Herbert · 2023-12-05 16:38:07 +09:00
  7b9c9a3bfd
• Match stable precision when generating catch bananas
  Dan Balasescu · 2023-12-05 15:39:26 +09:00
  3aaba3183b
• Search terms before performing other criteria checks

  Very minor, but putting the more common case towards the
  start of the method allows early return.

  Dean Herbert · 2023-12-05 15:28:56 +09:00
  45e499778f
• Avoid list construction when doing filtering
  Dean Herbert · 2023-12-05 15:26:14 +09:00
  42010574b5
• Fix legacy tick distance in JuiceStream generation
  Dan Balasescu · 2023-12-05 15:10:03 +09:00
  7d602c792d
• Avoid sorting items when already in the correct sort order
  Dean Herbert · 2023-12-05 14:47:32 +09:00
  27e778ae09
• Use ordinal comparison when searching at song select

  Bypasses various overheads. In theory should be fine? (until it's not on some language)

  Dean Herbert · 2023-12-05 14:14:13 +09:00
  7fda38d0b0
• Replicate integer calculations for tiny tick conversion
  Dan Balasescu · 2023-12-05 11:58:00 +09:00
  b90de83f33
• Cleanup pass
  Andrei Zavatski · 2023-12-05 02:48:11 +03:00
  68907fe1ba
• Changed file chooser in resource selection to show file name when file is selected
  Guido · 2023-12-04 22:51:56 +01:00
  8756dd25c6
• Fix ArgonHealthDisplay not displaying miss correctly during initial transition
  Salman Ahmed · 2023-12-04 23:55:31 +03:00
  629e64d50a
• Remove method for being unused
  Salman Ahmed · 2023-12-04 23:24:28 +03:00
  4d82a55594
• Fix ArgonHealthDisplay sometimes behaving weirdly on miss judgements
  Salman Ahmed · 2023-12-04 23:24:28 +03:00
  5723715ea0
• Merge pull request #25671 from Susko3/uncomment-net6.0-code

  Uncomment net6.0 code and remove old code in `BeatmapListingOverlay`

  Bartłomiej Dach · 2023-12-04 21:06:54 +01:00
  1292c322c0
• Add visual test case for late miss in argon health display
  Salman Ahmed · 2023-12-04 23:01:11 +03:00
  17577a6606
• Uncomment net6.0 code and remove old code
  Susko3 · 2023-12-04 20:17:22 +01:00
  0e47492858
• Merge pull request #25665 from bdach/skin-editor-breakage

  Fix several edge cases in skin editor gameplay scene opening flow

  Bartłomiej Dach · 2023-12-04 16:48:41 +01:00
  f0364f01ea
• Remove unused using statement
  Dean Herbert · 2023-12-04 23:06:08 +09:00
  c5a08a0711
• Trim unused resolved bindable
  Bartłomiej Dach · 2023-12-04 15:01:23 +01:00
  5512298d60
• Source autoplay mod from beatmap about to be presented rather than ambient global
  Bartłomiej Dach · 2023-12-04 14:42:51 +01:00
  8754fa40f4
• Do not attempt to load gameplay scene if current beatmap is dummy
  Bartłomiej Dach · 2023-12-04 14:42:51 +01:00
  063694f544
• Fix endless player not handling load failure
  Bartłomiej Dach · 2023-12-04 14:42:51 +01:00
  9d39b70e38
• Do not set initial activity in skin editor endless player

  Seems like an overreach to say that the user is "watching a replay"
  there.

  Bartłomiej Dach · 2023-12-04 14:42:51 +01:00
  055fb5bd8f
• Add test coverage for crashing on wrong ruleset
  Bartłomiej Dach · 2023-12-04 14:42:51 +01:00
  43312619e3
• Add test coverage for crashing on dummy beatmap
  Bartłomiej Dach · 2023-12-04 14:42:42 +01:00
  7c041df0f1
• Add test coverage for crashing on empty beatmap
  Bartłomiej Dach · 2023-12-04 14:42:40 +01:00
  d3e94cd5bf
• Extract beatmap import steps from gameplay scene switch helper
  Bartłomiej Dach · 2023-12-04 13:34:36 +01:00
  7deff70b4a
• Prioritise hyperfruit over non-hyperfruit if simultaneous

  In case of simultaneous hyperfruit and non-hyperfruit - which happen to
  occur on some aspire maps - the desired behaviour is to hyperdash. This
  did not previously occur, due to annoying details in how
  `HitObjectContainer` is structured.
  
  `HitObjectContainer`'s drawable comparer determines the order of
  updating the objects. One could say that forcing the hyperfruit to be
  updated last, after normal fruit, could help; unfortunately this is
  complicated by the existence of juice streams and the fact that while a
  juice stream can be terminated by a normal fruit that is coincidental
  with a hyperfruit, the two are not comparable directly using the
  comparer in any feasible way.
  
  Therefore, apply a `Catcher`-level workaround that intends to handle
  this locally; in short, if a hyperdash was toggled in a given frame, it
  cannot be toggled off again in the same frame. This yields the desired
  behaviour.

  Bartłomiej Dach · 2023-12-04 09:30:18 +01:00
  fcb6f40666
• Add test coverage for missing hyperdashes on simultaneous notes
  Bartłomiej Dach · 2023-12-04 09:26:23 +01:00
  bb198e0c5a
• Merge branch 'master' into catch-hyperdash-stable-sort
  Bartłomiej Dach · 2023-12-04 09:05:42 +01:00
  0652ea316d
• Add deceleration and rework depth handling
  Andrei Zavatski · 2023-12-04 10:26:43 +03:00
  ec5c7d7830
• Replicate integer calculations for catch hyperdash generation
  Dan Balasescu · 2023-12-04 14:32:14 +09:00
  6f73d78bc9
• Add failing test
  Dan Balasescu · 2023-12-04 14:30:08 +09:00
  c755bcbec4
• Merge pull request #25636 from Susko3/fix-older-android-storage

  Request `READ_EXTERNAL_STORAGE` on older android versions

  Dean Herbert · 2023-12-04 12:11:08 +09:00
  36b1369a4e
• Add inline comment matching framework
  Dean Herbert · 2023-12-04 12:10:31 +09:00
  c2a4a6d8cb
• Merge pull request #25649 from smoogipoo/remove-mania-drain-again

  Once again remove Mania passive HP drain

  Dean Herbert · 2023-12-04 12:03:32 +09:00
  e06d5f5875
• Fix countdown button being enabled
  Dan Balasescu · 2023-12-04 11:00:11 +09:00
  8587652869
• Add comments to test
  Dan Balasescu · 2023-12-04 10:20:53 +09:00
  9ccd33a1ec
• Correctly implement button enabled state
  Dan Balasescu · 2023-12-04 10:18:37 +09:00
  c2644a5d5e
• Adjust with framework changes
  Dan Balasescu · 2023-12-04 08:51:21 +09:00
  b56a78c6ec
• Fix test cases
  OliBomby · 2023-12-03 22:42:48 +01:00
  13b7f2fa42
• Improve commenting

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dan Balasescu · 2023-12-04 06:08:31 +09:00
  d0acb7f4f9
• Update SliderPlacementBlueprint.cs
  OliBomby · 2023-12-03 22:06:07 +01:00
  060141866c
• Dont snap expected distance while drawing

  This makes it 10 billion times smoother to draw, very nice

  OliBomby · 2023-12-03 22:03:51 +01:00
  b3d1a9ee2e
• call builder finish before ending curve
  OliBomby · 2023-12-03 21:43:37 +01:00
  ca55a7b2bf
• Remove the Linear segment simplification because it just makes things harder to edit afterwards if it made some segment linear type when you actually intended there to be some curve
  OliBomby · 2023-12-03 21:22:04 +01:00
  bcf2effae9
• fix the linear segment
  OliBomby · 2023-12-03 21:13:27 +01:00
  34b5264616
• update comment
  OliBomby · 2023-12-03 21:10:01 +01:00
  ba2cc0243c