394 Commits

• Adjust xmldoc to explicitly metnion it only affects end user control
  Dean Herbert · 2023-07-30 13:52:58 +09:00
  7138291636
• Allow screens to change the ability to interact with the global track
  Dean Herbert · 2023-07-25 20:20:53 +09:00
  6146f30541
• Rename AllowTrackAdjustments to more understandable ApplyModTrackAdjustments
  Dean Herbert · 2023-07-25 20:20:53 +09:00
  157b1f301b
• Apply more correct fix for double-playing menu track
  Dean Herbert · 2023-06-20 18:35:51 +09:00
  2e02b4a85b
• Partial everything
  Dan Balasescu · 2022-11-27 00:00:27 +09:00
  7bc8908ca9
• Move MusicController binds to LoadComplete for added thread safety
  Dean Herbert · 2022-09-26 15:42:37 +09:00
  4e9b25d8b0
• Fix editor potentially using a track post-disposal

  This changes the editor to track the current track as it is *loaded* by
  `MusicController`, rather than haphazardly following the current global
  `WorkingBeatmap` (with a potentially unloaded track) or relying on local
  immediate-load behaviour (as implemented in `ResourcesSection`).

  Dean Herbert · 2022-08-01 16:53:49 +09:00
  2f60f91a0e
• Use fire-and-forget async operations on global track

  This avoids any blocking overhead caused by a backlogged audio thread.
  Test seem to pass so might be okay?
  
  Note that order is still guaranteed due to the `ensureUpdateThread`
  queueing system framework-side.

  Dean Herbert · 2022-07-07 17:15:45 +09:00
  7ef03dd2cb
• Fix typo
  Dan Balasescu · 2022-06-27 20:40:02 +09:00
  6c6de9ce53
• Add various logging of global WorkingBeatmap state changes
  Dean Herbert · 2022-06-27 18:41:31 +09:00
  50c1c066de
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Use == instead of ??
  Salman Ahmed · 2022-05-20 16:08:31 +03:00
  abf9039109
• Refactor track transferring logic for ability to override and disallow
  Salman Ahmed · 2022-05-20 14:43:07 +03:00
  c78d90ccbd
• Remove unnecessary UnbindAdjustments call

  It is not necessary given that `CurrentTrack` already removes all adjustments first.

  Salman Ahmed · 2022-05-10 20:49:44 +03:00
  9446be2511
• Reinstantiate mod adjustments layer for safety against previous mods
  Salman Ahmed · 2022-05-10 20:46:33 +03:00
  36a7644164
• Define local adjustments component for mods in MusicController

  Isolates `CurrentTrack` from being directly adjusted by the mod, which could lead to issues depending on how the mod adds adjustments (i.e. `ModTimeRamp`, which adds adjustments based on changes to a setting bindable).

  Salman Ahmed · 2022-05-10 18:24:29 +03:00
  725ff93f34
• Completely remove subscription from MusicController
  Dean Herbert · 2022-01-25 16:53:02 +09:00
  1a776a9587
• Stop detaching and exposing beatmaps from MusicController
  Dean Herbert · 2022-01-25 16:51:21 +09:00
  958cfde608
• Update remaining cases of clashes with realm.Write and realm.RegisterForNotifications
  Dean Herbert · 2022-01-25 13:09:48 +09:00
  d7342880f5
• Merge branch 'master' into realm-clean-up
  Bartłomiej Dach · 2022-01-24 19:15:31 +01:00
  da771044a7
• Merge branch 'master' into music-controller-less-population
  Dean Herbert · 2022-01-24 20:44:37 +09:00
  3bc86ee68f
• Rename RealmContextFactory to RealmAccess
  Dean Herbert · 2022-01-24 20:38:07 +09:00
  6eb2c28e41
• Rename register methods to better explain their purpose
  Dean Herbert · 2022-01-24 14:37:36 +09:00
  40aa873190
• Fix one remaining instance of realm query as property
  Dean Herbert · 2022-01-23 23:20:03 +09:00
  351c766ea1
• Update all usages of QueryAsyncWithNotifications to use new Register pathway
  Dean Herbert · 2022-01-23 20:28:04 +09:00
  e9e3e024a1
• Remove unnecessary exception/check
  Dean Herbert · 2022-01-21 20:07:43 +09:00
  a86c0014fe
• Remove pointless initial MusicController beatmap set population

  Looks to pass tests and all usages look safe enough.

  Dean Herbert · 2022-01-21 20:05:35 +09:00
  63226f7def
• Update existing subscriptions to new style

  Fix missing detach calls in `MusicController`

  Dean Herbert · 2022-01-21 20:05:03 +09:00
  1f157d729d
• Remove left-over methods in MusicController
  Dean Herbert · 2022-01-14 19:55:49 +09:00
  3a95425a9e
• Update MusicController to handle deletions more correctly
  Dean Herbert · 2022-01-12 17:49:11 +09:00
  017285b694
• Fix intro screen hitting null reference if intro beatmap is unavailable
  Dean Herbert · 2022-01-12 17:49:11 +09:00
  e8dcbaf29a
• Temporarily disable WorkingBeatmapCache and fix multiple invalid data flows
  Dean Herbert · 2022-01-12 17:00:16 +09:00
  33060990b7
• Start introducing ILive
  Dean Herbert · 2022-01-12 17:00:16 +09:00
  1d536fd0bc
• "Update" MusicController
  Dean Herbert · 2022-01-12 17:00:16 +09:00
  abd72c496b
• Update model manager and many related classes to get things compiling again
  Dean Herbert · 2022-01-12 17:00:00 +09:00
  00e3af3366
• Fix incorrect delgate capture leading to slow leak of audio tracks

  During profile, it was found that the `Completed` delegate was
  incorrectly also capturing `lastTrack`, leading to an unexpected
  reference chain that led to a memory leak over a long period of time.
  
  This solves the issue by moving the delegate construction to its own
  method, where it won't capture the other variables.

  Dean Herbert · 2021-12-24 18:39:29 +09:00
  842d508aee
• Update cases where equality can be used instead of primary key equality
  Dean Herbert · 2021-11-24 12:49:57 +09:00
  729f681938
• Revert weird event flow in model manager/importers
  Dean Herbert · 2021-11-05 19:12:49 +09:00
  54f72d68ca
• Apply batch fixing of built-in types using var
  Dean Herbert · 2021-10-27 13:04:41 +09:00
  6944151486
• Reset all types of adjustments in MusicController; Rename AllowRateAdjustments to AllowTrackAdjustments
  Henry Lin · 2021-07-29 15:39:26 +08:00
  89e8296eb1
• Remove previous consumption logic in GetWorkingBeatmap

  This should not be required since the introduction of `workingCache`,
  which does the same thing in a more global way.

  Dean Herbert · 2021-05-31 14:11:58 +09:00
  06bd696cc2
• Rename IsUserPaused -> UserPauseRequested
  smoogipoo · 2020-11-02 16:08:59 +09:00
  6f623d8cca
• Add matching requestedByUser parameter to Play method
  Dean Herbert · 2020-11-02 15:01:30 +09:00
  8f2cd0e8c5
• Change default value of requestedByUser to false
  Dean Herbert · 2020-11-02 14:56:50 +09:00
  d2f6303988
• Add flag parameter to allow non-user-pause via music controller
  Bartłomiej Dach · 2020-10-31 16:07:54 +01:00
  941e8525af
• Add check to ensure MusicController doesn't play a delete pending beatmap's track
  Dean Herbert · 2020-10-09 13:11:24 +09:00
  c86b37f60d
• Rename reload method to not mention beatmap unnecessarily
  Dean Herbert · 2020-09-25 12:27:08 +09:00
  a17eac3692
• Add basic track reloading support while inside the editor
  Dean Herbert · 2020-09-24 20:56:35 +09:00
  978f6edf38
• Remove unnecessary RunTask calls
  Dean Herbert · 2020-09-08 18:26:13 +09:00
  ad5d6117c7
• Merge branch 'master' into fix-music-controller-regressed
  Dean Herbert · 2020-09-04 20:10:43 +09:00
  b8e5acfef1