71 Commits

• Update R# + fix inspections
  Dan Balasescu · 2024-02-02 21:00:28 +09:00
  b44f77cee1
• Merge pull request #25522 from bdach/no-concurrent-connections

  Implement flow allowing disconnection from online services when another client instance for same user is detected

  Dean Herbert · 2023-11-28 19:09:38 +09:00
  537c9e031d
• Revert incorrect xmldoc change
  Bartłomiej Dach · 2023-11-27 11:35:10 +09:00
  7f788058cd
• Reduce access to various fields and events in SpectatorClient

  Restore some `virtual` specs to appease Moq

  Dean Herbert · 2023-11-24 14:26:09 +09:00
  ed5375536f
• Centralise and improve messaging around online state

  When the server requests a disconnect due to a user connecting
  via a second device, the client will now log the user out on the first
  device and show a notification informing them of the cause of
  disconnection.

  Bartłomiej Dach · 2023-11-21 15:15:46 +09:00
  42fada578e
• Implement client-side disconnection flow
  Bartłomiej Dach · 2023-11-21 15:15:45 +09:00
  1c612e2e0c
• Make ScoreInfo.BeatmapInfo nullable
  Dean Herbert · 2023-07-04 14:50:34 +09:00
  d74b1e148d
• Add score processor statistics to replay header
  Dan Balasescu · 2023-05-19 16:29:24 +09:00
  6c6f8621c1
• Fix intermittent failure in tests with restarting player instances
  Salman Ahmed · 2023-01-15 16:06:06 +03:00
  13c1b8f5a4
• Add score processed callback to spectator client
  Bartłomiej Dach · 2022-12-20 21:23:50 +01:00
  b03291330f
• Merge branch 'master' into beginplaying-score-token
  Bartłomiej Dach · 2022-12-13 17:15:24 +01:00
  849245b90c
• Move score token to BeginPlaying
  Dan Balasescu · 2022-12-12 13:59:27 +09:00
  caa0b7c290
• Store maximum statistics to spectator state
  Dan Balasescu · 2022-12-09 20:15:07 +09:00
  e9998f1690
• Add score token to spectator state
  Dan Balasescu · 2022-12-09 19:09:51 +09:00
  4a65f5c864
• Partial everything
  Dan Balasescu · 2022-11-27 00:00:27 +09:00
  7bc8908ca9
• watchedUsers -> watchedUsersRefCounts
  Salman Ahmed · 2022-08-25 09:50:52 +03:00
  6840e906e7
• Fix spectator client not handling multiple watch calls properly
  Salman Ahmed · 2022-08-24 10:02:21 +03:00
  7e5086c8d7
• Revert blocking call when sending spectator frames

  There are a lot of these requests, and we don't really care about
  waiting on them to finish sending. This may have negatively affected
  send performance for users with very high latency.
  
  Reverts part of 0533249d11.
  
  Addresses concerns in https://github.com/ppy/osu/discussions/19429#discussioncomment-3276400.

  Dean Herbert · 2022-07-29 12:24:54 +09:00
  fd09155990
• Reword comment slightly
  Salman Ahmed · 2022-07-25 04:39:14 +03:00
  e0266b0d81
• Fix players potentially not displaying in spectator after restart
  Salman Ahmed · 2022-07-25 04:21:53 +03:00
  f5a5887669
• Use debug.assert for better readable.
  andy840119 · 2022-07-03 19:27:56 +08:00
  8c2f4b48fc
• Use AsNonNull() instead.
  andy840119 · 2022-07-02 19:48:32 +08:00
  0a1543c6e8
• pretend that the beatmap property will not be null.

  Not really throw exception will be the better way?

  andy840119 · 2022-07-02 13:20:46 +08:00
  c6d0f0f81b
• Handle task exception outside of schedule to avoid unobserved exceptions
  Dean Herbert · 2022-06-28 15:09:28 +09:00
  22b254e5c5
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Merge branch 'scoreprocessor-cleanup' into multiplayer-leaderboard-user-mods-2
  Dan Balasescu · 2022-05-31 19:53:37 +09:00
  13d85b8cc7
• Use new score processor in MultiplayerGameplayLeaderboard
  Dan Balasescu · 2022-05-30 19:26:26 +09:00
  22d998dc2a
• Send ScoreProcessor statistics in SpectatorState
  Dan Balasescu · 2022-05-30 19:26:26 +09:00
  a052e09ac3
• Add test coverage of spectator requests
  Dean Herbert · 2022-04-11 19:27:14 +09:00
  09d560c93e
• Expose mocked members as virtual on Multiplayer and SpectatorClient
  Dean Herbert · 2022-04-11 19:04:15 +09:00
  34457b4742
• Remove verbose logging from SpectatorClient for now
  Dean Herbert · 2022-02-25 22:25:36 +09:00
  67082b8c5d
• Use Logger.Log instead of console
  Dan Balasescu · 2022-02-25 20:18:22 +09:00
  8eef1774d5
• Group SpectatorClient private fields together
  Dean Herbert · 2022-02-24 02:31:55 +09:00
  3f2ef030e4
• Fix frames potentially getting lost due to non-matching Schedule usage
  Dean Herbert · 2022-02-24 02:28:13 +09:00
  694c6ad872
• Fix bundle send logic not correctly waiting for task completion (due to nested schedule)
  Dean Herbert · 2022-02-24 02:23:48 +09:00
  47b84295a6
• Add note about reconnection being insufficient currently
  Dean Herbert · 2022-02-24 02:23:48 +09:00
  cff6f85472
• Add support to SpectatorClient to resend failed frame bundles
  Dean Herbert · 2022-02-24 02:21:29 +09:00
  5ff4d3f8e5
• Unify namings across the board
  Dan Balasescu · 2022-02-09 12:10:07 +09:00
  ffc4c64f7e
• Refactorings
  Dan Balasescu · 2022-02-08 21:29:43 +09:00
  886d1d2df6
• Rename completed state to passed
  Dan Balasescu · 2022-02-08 20:29:49 +09:00
  4c76027178
• Add back playing users list
  Dan Balasescu · 2022-02-02 23:19:43 +09:00
  81a22dbd29
• Rename PlayingUserStates -> WatchingUserStates
  Dan Balasescu · 2022-02-02 23:11:29 +09:00
  fcbba3d948
• Merge branch 'master' into spectator-state-rework
  Dan Balasescu · 2022-02-02 18:57:04 +09:00
  6d3bc005ea
• Rework spectator components to use new user state
  Dan Balasescu · 2022-02-01 21:53:25 +09:00
  f4210f7a30
• Give SpectatorState a user state
  Dan Balasescu · 2022-02-01 21:51:05 +09:00
  41007169f7
• Remove PlayingUsers list from SpectatorClient
  Dan Balasescu · 2022-02-01 14:42:30 +09:00
  502e6af008
• Give last bundled replay frame the frame header
  Dan Balasescu · 2022-01-31 18:53:47 +09:00
  4727aeda01
• Purge final spectator frames before ending play
  Dan Balasescu · 2022-01-28 22:26:05 +09:00
  3037a3a769
• Add a paired schedule in SpectatorClient.BeginPlaying

  Optimally, I would like to remove the `Schedule` in `EndPlaying`, but it
  turns out quite a few test are relying on this at very least. Adding a
  paired schedule ensure that order of operations is correct, at least.

  Dean Herbert · 2021-12-06 17:07:19 +09:00
  7a333ffdcc
• Rename BeatmapInfo.OnlineBeatmapID to OnlineID to match interface
  Dean Herbert · 2021-11-12 17:46:24 +09:00
  6a098a8634