Bartłomiej Dach
03cdfd0660
Fix timeline break piece crashing on drag if there are no objects before start or after end
...
This fixes the direct cause of https://github.com/ppy/osu/issues/28577 .
2024-06-25 12:25:37 +02:00
Dean Herbert
c5c30949d2
Merge pull request #28570 from bdach/fix-upscroll
...
Fix legacy skin hold note bodies not appearing when scrolling upwards
2024-06-25 19:08:23 +09:00
PercyDan54
2de0852551
Fix transient rank value applied to bindable
2024-06-25 18:06:50 +08:00
Dean Herbert
a042b6e141
Merge pull request #28568 from bdach/fix-classic-slider-drawable-judgement-position
...
Fix incorrect slider judgement positions when classic mod is active
2024-06-25 19:04:05 +09:00
Bartłomiej Dach
0d2a47167c
Fix crash on calculating playlist duration when rate-changing mods are present
...
Regressed in https://github.com/ppy/osu/pull/28399 .
To reproduce, enter a playlist that has an item with a rate-changing mod
(rather than create it yourself).
This is happening because `APIRuleset` has `CreateInstance()`
unimplemented:
b4cefe0cc2/osu.Game/Online/API/Requests/Responses/APIBeatmap.cs (L159)
2024-06-25 11:28:10 +02:00
Bartłomiej Dach
1eac0c622a
Fix legacy skin hold note bodies not appearing when scrolling upwards
...
- Closes https://github.com/ppy/osu/issues/28567 .
- Regressed in https://github.com/ppy/osu/pull/28466 .
Bit of a facepalm moment innit...
2024-06-25 10:35:36 +02:00
Bartłomiej Dach
2cb18820ea
Fix incorrect slider judgement positions when classic mod is active
...
Regressed in https://github.com/ppy/osu/pull/27977 .
Bit ad-hoc but don't see how to fix without just reverting the change.
2024-06-25 10:07:58 +02:00
Dean Herbert
b4cefe0cc2
Update rider vcsConfiguration
...
Updated in recent rider versions
2024-06-25 15:50:11 +09:00
Dean Herbert
2de42854c3
Fix corner radius looking bad when graph bars are too short
2024-06-25 15:43:52 +09:00
Salman Ahmed
a277d9df13
Kill focus from components when clicking on an empty space in the panel
2024-06-25 07:13:36 +03:00
Salman Ahmed
7ddb6cb7e7
Scroll mod setting dropdown into view when open
2024-06-25 06:56:48 +03:00
Salman Ahmed
3f06a0ef9e
Block certain operations when customisation panel is open
...
Normally I would just block keyboard input from going past `ModCustomisationPanel`, but it's a little complicated here since I'm dealing with global action key binding presses, and I also still want actions like `GlobalAction.Back` to get past the customisation panel even if it's expanded.
2024-06-25 06:16:46 +03:00
Salman Ahmed
57ee794398
Add extra margin to avoid 1px artifacts
2024-06-25 06:08:13 +03:00
Salman Ahmed
0a72394c8a
Fix customisation panel conflicting with beatmap attributes when collapsed
2024-06-25 06:04:39 +03:00
Bartłomiej Dach
66b093b17e
Implement score breakdown display for daily challenge screen
2024-06-24 10:09:10 +02:00
Dan Balasescu
442705bc0c
Merge pull request #28559 from peppy/fix-key-binding-corruption
...
Fix scale control key binding breaking previous defaults
2024-06-24 11:46:43 +09:00
Salman Ahmed
7cbd04db9c
Merge branch 'master' into fix-key-binding-corruption
2024-06-24 05:30:21 +03:00
Dean Herbert
1dc9f10235
Fix scale control key binding breaking previous defaults
...
Oops from ppy/osu#28309 .
2024-06-24 09:46:23 +08:00
Salman Ahmed
2efafcaf5b
Remove stale comment
2024-06-23 08:46:55 +03:00
Salman Ahmed
1298b98534
Update test coverage
2024-06-23 08:22:54 +03:00
Salman Ahmed
e23da93c09
Use new display on mod select overlay and remove old display
2024-06-23 08:22:50 +03:00
Salman Ahmed
04efa61156
Add different display for mod customisation
2024-06-23 08:22:13 +03:00
Dean Herbert
3bf742bda2
Merge pull request #28537 from bdach/hit-animations
...
Adjust behaviour of hit animations toggle to match user expectations
2024-06-23 11:58:04 +09:00
Dean Herbert
c58bb62408
Merge branch 'master' into hit-animations
2024-06-23 04:32:47 +09:00
Dean Herbert
df43a1c6cc
Add note about every-frame-transforms
2024-06-23 03:31:40 +08:00
Jamie Taylor
2ffeb1b361
Add fallback behaviour for custom rulesets
2024-06-23 02:20:51 +09:00
Dean Herbert
80907acaa6
Update resources
2024-06-22 22:01:05 +08:00
Jamie Taylor
0d11b2b91c
Replace manual usages of AudioFilter with new ducking methods
2024-06-22 01:57:14 +09:00
Jamie Taylor
a56751511e
Apply a ducking effect to the currently playing track when switching ruleset
2024-06-22 01:36:30 +09:00
Bartłomiej Dach
8bbbedaec3
Merge pull request #28540 from ssz7-ch2/fix-typo
...
Fix typo in ScoreProcessor
2024-06-21 08:32:01 +02:00
sometimes
89d3f67eb3
fix accuracyProcess typo
2024-06-20 22:06:00 -04:00
Olivier Schipper
4c6741e8aa
Fix exception type
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2024-06-20 17:27:38 +02:00
Olivier Schipper
74399542d2
Use math instead of hardcoded constant values
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2024-06-20 17:27:15 +02:00
Bartłomiej Dach
ad2cd0ba8f
Adjust behaviour of hit animations toggle to match user expectations
2024-06-20 13:42:32 +02:00
Dean Herbert
57774ae767
Merge branch 'master' into slider-anchor-type-switching
2024-06-20 19:01:22 +09:00
Dean Herbert
cd4dce2c7e
Merge pull request #28478 from bdach/timeline-drag-selection-crash
...
Fix crash on drag selection via timeline while placement is active
2024-06-20 19:00:45 +09:00
Dean Herbert
14104e57d4
Merge branch 'master' into timeline-drag-selection-crash
2024-06-20 15:16:10 +09:00
Dean Herbert
0eb533f2fd
Merge pull request #28444 from bdach/scrolling-ruleset-editor-reloads
...
Reload scrolling hitobject composer on control point changes
2024-06-20 15:15:26 +09:00
OliBomby
f2bd6fac47
fix codefactor
2024-06-19 21:10:30 +02:00
OliBomby
d5397a2139
fix alpha value in disabled state
2024-06-19 20:59:14 +02:00
OliBomby
ce4567f87b
adjust rotation bounds based on grid type
2024-06-19 20:46:55 +02:00
Dean Herbert
9eb6752033
Merge pull request #28528 from bdach/break-autogeneration
2024-06-19 23:46:05 +09:00
Dean Herbert
a718af8af5
Adjust break colours to match closer to stable
2024-06-19 22:02:10 +08:00
Bartłomiej Dach
617c1341d7
Make (Manual)BreakPeriod a class again
...
CodeFileSanity doesn't like records and it being a record wasn't doing
much anymore anyway.
2024-06-19 14:53:09 +02:00
Dean Herbert
00443403b6
Merge branch 'master' into break-autogeneration
2024-06-19 21:49:17 +09:00
Dean Herbert
32a7885f10
Merge pull request #28523 from bdach/break-display-and-adjustment
...
Display breaks on editor timeline & allow manually adjusting their duration
2024-06-19 21:48:54 +09:00
Dean Herbert
00a866b699
Change colour to match bottom timeline (and adjust tween sligthly)
2024-06-19 20:30:43 +08:00
Bartłomiej Dach
8757e08c2c
Fix test failures due to automatic break generation kicking in
2024-06-19 11:32:08 +02:00
Bartłomiej Dach
2d9c3fbed2
Remove no-longer-necessary null propagation
2024-06-19 11:21:57 +02:00
Bartłomiej Dach
4390798761
Add test coverage for automatic break generation
2024-06-19 11:14:38 +02:00
