Dean Herbert
ad6af1d9b7
Ensure only run once
2023-11-22 12:03:42 +09:00
Dean Herbert
fe15b26bd2
Refactor to use API state instead of logged in user state
2023-11-22 12:02:37 +09:00
Dean Herbert
04640b6fb0
Improve commenting around IHasCombo interfaces
...
Following discusion with smoogi IRL.
2023-11-22 10:44:29 +09:00
Dean Herbert
7bdee96c07
Merge pull request #25533 from bdach/aaaannndddrroooiiiddd
2023-11-22 08:44:43 +09:00
Poyo
3a0586a8f5
Rewrite backwards assertion
2023-11-21 15:19:04 -08:00
Poyo
0cf925dadf
Use better fallback
...
Seems better to use the rate from a non-gameplay clock than to arbitrarily apply 1.
2023-11-21 15:18:04 -08:00
Bartłomiej Dach
aa72407065
Fix android compile failures due to invalid java version
...
See https://github.com/ppy/osu-framework/pull/6057 .
2023-11-22 07:55:41 +09:00
Bartłomiej Dach
c98be5823d
Update framework
2023-11-22 07:52:28 +09:00
yesseruser
b2f74325ef
Added a BaseDrawableFlag without a tooltip, and used it.
...
The BaseDrawableFlag is used in a BaseUpdateableFlag so the tooltip is not shown, the ClickableUpdateableFlag still shows the tooltip.
2023-11-21 19:51:35 +01:00
yesseruser
cd7e0bf620
Created and implemened a BaseUpdateableFlag.
...
The tooltip still shows.
2023-11-21 19:27:33 +01:00
yesseruser
671177e871
Renamed UpdateableFlag to ClickableUpdateableFlag.
2023-11-21 19:02:23 +01:00
Dan Balasescu
8302ebcf1a
Remove default DrainRate value
2023-11-21 19:18:02 +09:00
Dan Balasescu
4b5ef8328b
Merge pull request #25521 from Syriiin/fix/refactor-miss
...
Fix implicitly used method being named incorrectly
2023-11-21 18:00:19 +09:00
Dean Herbert
aa749aeb73
Save any unsaved changes in the skin editor when game changes screens
...
Closes https://github.com/ppy/osu/issues/25494 .
2023-11-21 17:49:57 +09:00
Bartłomiej Dach
85bddab52b
Refactor OnlineStatusNotifier to be more local
2023-11-21 17:36:29 +09:00
Dean Herbert
21bf288277
Merge pull request #25520 from peppy/context-menu-spacers
...
Allow context menus to have visible spacers
2023-11-21 16:56:36 +09:00
Bartłomiej Dach
bf972a04ee
Merge pull request #25409 from Tom94/bspline-sliders
...
Add free-hand drawing of sliders to the editor
2023-11-21 16:28:14 +09:00
Bartłomiej Dach
ed38746823
Fix spacer appearing on top of menu
2023-11-21 16:14:41 +09:00
Bartłomiej Dach
d83b2e24e7
Merge pull request #25371 from RatinFX/open-editor-timestamp
...
Implement opening editor timestamp links
2023-11-21 15:48:36 +09:00
Dean Herbert
4b2d8aa6a6
Add ToString on PathType for better test output
2023-11-21 15:38:12 +09:00
Dean Herbert
cc33e12125
Fix dragging after one point already placed incorrectly entering drawing mode
2023-11-21 15:38:12 +09:00
Dean Herbert
1660eb3c15
Add failing test coverage of drag after point placement
2023-11-21 15:38:12 +09:00
Dean Herbert
a210469956
Reorder methods
2023-11-21 15:38:12 +09:00
Dean Herbert
016de7be6a
Simplify drag handling code in SliderPlacementBlueprint
2023-11-21 15:38:12 +09:00
Dean Herbert
cf6f66b84f
Remove redundant Clear() call
2023-11-21 15:38:12 +09:00
Dean Herbert
92728ea564
Simplify toolbox initialisation
2023-11-21 15:38:12 +09:00
Dean Herbert
ba6fbbe43c
Update framework
2023-11-21 15:38:12 +09:00
Dean Herbert
3d094f84ad
Fix incorrect parsing of BSpline curve types
2023-11-21 15:38:12 +09:00
Dean Herbert
9c3f9db318
Add failing test coverage of BSpline encoding parse failure
2023-11-21 15:38:12 +09:00
Dean Herbert
7bedbe4264
Apply NRT to SliderPlacementBlueprint tests
2023-11-21 15:38:12 +09:00
Dean Herbert
5175464c18
Update test coverage (and add test coverage of curve drawing)
2023-11-21 15:38:12 +09:00
Dean Herbert
e69e78ad41
Refactor b-spline path conversion code to better handle linear segments
2023-11-21 15:38:12 +09:00
Dean Herbert
0a5444d091
Fix using the incorrect position for the first point
2023-11-21 15:38:12 +09:00
Dean Herbert
314a7bf6f1
Simplify AddOnce call to avoid self argument
2023-11-21 15:38:12 +09:00
Bartłomiej Dach
aa3ff151c0
Fix RoomManager attempting to part room when not online
2023-11-21 15:15:46 +09:00
Bartłomiej Dach
42fada578e
Centralise and improve messaging around online state
...
When the server requests a disconnect due to a user connecting
via a second device, the client will now log the user out on the first
device and show a notification informing them of the cause of
disconnection.
2023-11-21 15:15:46 +09:00
Bartłomiej Dach
2391035e49
Remove redundant api field from HubClientConnector
2023-11-21 15:15:46 +09:00
Bartłomiej Dach
1c612e2e0c
Implement client-side disconnection flow
2023-11-21 15:15:45 +09:00
Dean Herbert
7c5345bf7e
Use SimpleErrorNotification for error display
2023-11-21 15:10:41 +09:00
Dean Herbert
917a68eac3
Adjust localisablel strings and keys
2023-11-21 15:08:15 +09:00
Dean Herbert
3afaafb1d9
Reorder and simplify private helper methods
2023-11-21 15:05:51 +09:00
Samuel Cattini-Schultz
c9ee29028f
Fix implicitly used method being named incorrectly
2023-11-21 16:54:20 +11:00
Dean Herbert
9718a80249
Add visible spacer between "inherit" and other curve types
2023-11-21 14:24:19 +09:00
Dean Herbert
405ab499e9
Allow context menus to have visible spacers
2023-11-21 14:24:10 +09:00
Dean Herbert
3680024e31
Fix tolerance not being transferred to blueprint in all cases
2023-11-21 11:15:00 +09:00
Stedoss
826c82de47
Add unit test for handling login state in UserProfileOverlay
2023-11-21 01:56:37 +00:00
Stedoss
ec7b82f5e8
Change early return to check for online State instead of IsLoggedIn
2023-11-21 01:55:08 +00:00
Stedoss
5514a53df1
Pass ruleset to callback to prevent ruleset desync
2023-11-21 01:04:46 +00:00
Dean Herbert
e9f371a581
Refactor slider settings class
2023-11-21 09:59:49 +09:00
Dean Herbert
638c8f1adc
Get rid of weird cruft and non-standard flow
2023-11-21 00:25:23 +09:00
